New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648490 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 518807



Sign in to add a comment

Implement takePhoto() method for Win devices

Project Member Reported by mcasas@chromium.org, Sep 20 2016

Issue description

VideoCaptureDevice::takePhoto() [1] is not implemented in
VideoCaptureDeviceWin.  Implement it in said class.

[1] https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device.h?q=VideoCaptureDevice::takePhoto&sq=package:chromium&l=198&dr=Ss

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ff7e8f966c0c56019cb51cdbb93316a772191b6

commit 3ff7e8f966c0c56019cb51cdbb93316a772191b6
Author: mcasas <mcasas@chromium.org>
Date: Wed Sep 21 00:17:01 2016

ImageCapture: Implement takePhoto() for Windows

This CL implements VideoCaptureDevice::TakePhoto() for
Windows DirectShow (which is essentially used for all
Windows re. video capture). For that, the V4L2CaptureDelegate::GetPhotoBlob() is factored out
into media/capture/video/blob_utils.{cc,h}, and renamed
to Blobify().

BUG= 648490 
TEST=Enabled VideoCaptureDeviceTest::TakePhoto in Win.
All other ImageCapture related tests still passing.

Review-Url: https://codereview.chromium.org/2354783002
Cr-Commit-Position: refs/heads/master@{#419915}

[modify] https://crrev.com/3ff7e8f966c0c56019cb51cdbb93316a772191b6/media/capture/BUILD.gn
[add] https://crrev.com/3ff7e8f966c0c56019cb51cdbb93316a772191b6/media/capture/video/blob_utils.cc
[add] https://crrev.com/3ff7e8f966c0c56019cb51cdbb93316a772191b6/media/capture/video/blob_utils.h
[modify] https://crrev.com/3ff7e8f966c0c56019cb51cdbb93316a772191b6/media/capture/video/linux/v4l2_capture_delegate.cc
[modify] https://crrev.com/3ff7e8f966c0c56019cb51cdbb93316a772191b6/media/capture/video/linux/v4l2_capture_delegate.h
[modify] https://crrev.com/3ff7e8f966c0c56019cb51cdbb93316a772191b6/media/capture/video/video_capture_device_unittest.cc
[modify] https://crrev.com/3ff7e8f966c0c56019cb51cdbb93316a772191b6/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/3ff7e8f966c0c56019cb51cdbb93316a772191b6/media/capture/video/win/video_capture_device_win.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63038c90b7a3419742d4c6781f47560a4dfb63f9

commit 63038c90b7a3419742d4c6781f47560a4dfb63f9
Author: mcasas <mcasas@chromium.org>
Date: Thu Sep 22 23:09:11 2016

Video Capture Device Win: cleanup error logging

While writing other code, I found out that the error logging
in VCDWin is cumbersome: it is too verbose on Init() and
doesn't dump the HRESULT while capturing.

So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs
an error message _and_ the stringified HRESULT. It also
sends an HRESULT to SetErrorMessage() to dump it on
stdout.

In my experience, all these loggings are only used
by developers to try and guess what goes wrong in Win
bots when those fail, so the less release code they take
up the better.

BUG= 405016 ,  648490 

Review-Url: https://codereview.chromium.org/2365533004
Cr-Commit-Position: refs/heads/master@{#420493}

[modify] https://crrev.com/63038c90b7a3419742d4c6781f47560a4dfb63f9/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/63038c90b7a3419742d4c6781f47560a4dfb63f9/media/capture/video/win/video_capture_device_win.h

Comment 3 by mcasas@chromium.org, Sep 22 2016

Status: Fixed (was: Started)
Cc: anatolid@chromium.org
Can the owner please set a milestone label to this issue?

FYI, the last CL associated with this issue has been added after the M54 branch was created and before the M55 branch was created, so perhaps it should be labelled as M55?
Labels: M-55

Comment 6 by mcasas@chromium.org, Oct 24 2016

Labels: -M-55

Comment 7 by sshru...@google.com, Nov 23 2016

Components: -Blink>MediaStream>ImageCapture Blink>ImageCapture

Sign in to add a comment