Implement takePhoto() method for Win devices |
||||||
Issue descriptionVideoCaptureDevice::takePhoto() [1] is not implemented in VideoCaptureDeviceWin. Implement it in said class. [1] https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device.h?q=VideoCaptureDevice::takePhoto&sq=package:chromium&l=198&dr=Ss
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63038c90b7a3419742d4c6781f47560a4dfb63f9 commit 63038c90b7a3419742d4c6781f47560a4dfb63f9 Author: mcasas <mcasas@chromium.org> Date: Thu Sep 22 23:09:11 2016 Video Capture Device Win: cleanup error logging While writing other code, I found out that the error logging in VCDWin is cumbersome: it is too verbose on Init() and doesn't dump the HRESULT while capturing. So: This CL adds a macro DLOG_IF_WITH_HRESULT() that logs an error message _and_ the stringified HRESULT. It also sends an HRESULT to SetErrorMessage() to dump it on stdout. In my experience, all these loggings are only used by developers to try and guess what goes wrong in Win bots when those fail, so the less release code they take up the better. BUG= 405016 , 648490 Review-Url: https://codereview.chromium.org/2365533004 Cr-Commit-Position: refs/heads/master@{#420493} [modify] https://crrev.com/63038c90b7a3419742d4c6781f47560a4dfb63f9/media/capture/video/win/video_capture_device_win.cc [modify] https://crrev.com/63038c90b7a3419742d4c6781f47560a4dfb63f9/media/capture/video/win/video_capture_device_win.h
,
Sep 22 2016
,
Oct 18 2016
Can the owner please set a milestone label to this issue? FYI, the last CL associated with this issue has been added after the M54 branch was created and before the M55 branch was created, so perhaps it should be labelled as M55?
,
Oct 21 2016
,
Oct 24 2016
,
Nov 23 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Sep 21 2016