New issue
Advanced search Search tips

Issue 648480 link

Starred by 1 user
Status: Fixed
Owner:
steve...@chromium.org
Closed: Sep 2016
Cc:
lgcheng@google.com
pav...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"MigrationSingleClientTest.AllTypesWithNigoriAtOnce" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 20 2016 
"MigrationSingleClientTest.AllTypesWithNigoriAtOnce" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJNaWdyYXRpb25TaW5nbGVDbGllbnRUZXN0LkFsbFR5cGVzV2l0aE5pZ29yaUF0T25jZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by hbos@chromium.org, Sep 20 2016

Cc: lgcheng@google.com pav...@chromium.org
Labels: -Sheriff-Chromium
Owner: steve...@chromium.org
[triage] Assigning and CC'ing folks who recently touched/reviewed this test file, can you take a look or triage?
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76ad59ea95d48f29f5b8658d467d6323789f1b51

commit 76ad59ea95d48f29f5b8658d467d6323789f1b51
Author: hbos <hbos@chromium.org>
Date: Tue Sep 20 14:53:06 2016

Disable flaky MigrationSingleClientTest tests.

These are reported as flaky. Though locally they fail every time?

Disabling:
- MigrationSingleClientTest.AllTypesAtOnce
- MigrationSingleClientTest.AllTypesAtOnceTriggerNotification
- MigrationSingleClientTest.AllTypesWithNigoriAtOnce
- MigrationSingleClientTest.BookmarksPrefsBoth
- MigrationSingleClientTest.BookmarksPrefsIndividually
- MigrationSingleClientTest.NigoriOnly
- MigrationSingleClientTest.PrefsNigoriBoth
- MigrationSingleClientTest.PrefsOnlyModifyBookmark
- MigrationSingleClientTest.PrefsOnlyModifyPref
- MigrationSingleClientTest.PrefsOnlyTriggerNotification

With this, *ALL* MigrationSingleClientTests that were not already
disabled are disabled. This bug needs to be investigated and the tests
re-enabled.

BUG= 648480 
NOTRY=True
TBR=lgcheng,stevenjb,pavely

Review-Url: https://codereview.chromium.org/2353953002
Cr-Commit-Position: refs/heads/master@{#419757}

[modify] https://crrev.com/76ad59ea95d48f29f5b8658d467d6323789f1b51/chrome/browser/sync/test/integration/migration_test.cc

Comment 3 by ymalik@chromium.org, Sep 20 2016 

 Issue 648479  has been merged into this issue.

Comment 4 by ymalik@chromium.org, Sep 20 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f58e5fea14e496cc7bf2b4af814e1c4726b07f87

commit f58e5fea14e496cc7bf2b4af814e1c4726b07f87
Author: ymalik <ymalik@chromium.org>
Date: Tue Sep 20 15:15:55 2016

Revert of Disable flaky MigrationSingleClientTest tests. (patchset #1 id:1 of https://codereview.chromium.org/2353953002/ )

Reason for revert:
No need to disable these tests as the flakyness was fixed by https://codereview.chromium.org/2338213009

Original issue's description:
> Disable flaky MigrationSingleClientTest tests.
>
> These are reported as flaky. Though locally they fail every time?
>
> Disabling:
> - MigrationSingleClientTest.AllTypesAtOnce
> - MigrationSingleClientTest.AllTypesAtOnceTriggerNotification
> - MigrationSingleClientTest.AllTypesWithNigoriAtOnce
> - MigrationSingleClientTest.BookmarksPrefsBoth
> - MigrationSingleClientTest.BookmarksPrefsIndividually
> - MigrationSingleClientTest.NigoriOnly
> - MigrationSingleClientTest.PrefsNigoriBoth
> - MigrationSingleClientTest.PrefsOnlyModifyBookmark
> - MigrationSingleClientTest.PrefsOnlyModifyPref
> - MigrationSingleClientTest.PrefsOnlyTriggerNotification
>
> With this, *ALL* MigrationSingleClientTests that were not already
> disabled are disabled. This bug needs to be investigated and the tests
> re-enabled.
>
> BUG= 648480 
> NOTRY=True
> TBR=lgcheng,stevenjb,pavely
>
> Committed: https://crrev.com/76ad59ea95d48f29f5b8658d467d6323789f1b51
> Cr-Commit-Position: refs/heads/master@{#419757}

TBR=lgcheng@google.com,pavely@chromium.org,stevenjb@chromium.org,hbos@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 648480 

Review-Url: https://codereview.chromium.org/2351903003
Cr-Commit-Position: refs/heads/master@{#419766}

[modify] https://crrev.com/f58e5fea14e496cc7bf2b4af814e1c4726b07f87/chrome/browser/sync/test/integration/migration_test.cc

Comment 6 by ymalik@chromium.org, Sep 20 2016 

 Issue 648478  has been merged into this issue.
►

Sign in to add a comment