Build failure - check on ColorSpace enum boundary |
||||
Issue descriptionCaused by https://codereview.chromium.org/2338213009/ which was reverted here: https://codereview.chromium.org/2352903002 Link to build or pfq page. https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/17323 Snippet of log that contains the failure. [4590:14851:0919/144840:FATAL:gfx_param_traits_macros.h(19)] Check failed: (static_cast<int>(value) >= static_cast<int>(0) && static_cast<int>(value) <= static_cast<int>(gfx::ColorSpace::PrimaryID::LAST)). 0 libbase.dylib 0x000000011e3cc19e _ZN4base5debug10StackTraceC2Ev + 30 1 libbase.dylib 0x000000011e3cc205 _ZN4base5debug10StackTraceC1Ev + 21 2 libbase.dylib 0x000000011e4636e0 _ZN7logging10LogMessageD2Ev + 80 3 libbase.dylib 0x000000011e461295 _ZN7logging10LogMessageD1Ev + 21 4 libgfx_ipc_color.dylib 0x00000001382053ca _ZN3IPC11ParamTraitsIN3gfx10ColorSpace9PrimaryIDEE5WriteEPN4base6PickleERKS3_ + 250 5 libgfx_ipc_color.dylib 0x0000000138204dcd _ZN3IPCL10WriteParamIN3gfx10ColorSpace9PrimaryIDEEEvPN4base6PickleERKT_ + 29 6 libgfx_ipc_color.dylib 0x0000000138204d0d _ZN3IPC11ParamTraitsIN3gfx10ColorSpaceEE5WriteEPN4base6PickleERKS2_ + 29
,
Sep 20 2016
Do we understand how this made it through the CQ?
,
Sep 20 2016
,
Sep 20 2016
I don't think it's understood how this made it through the CQ. Note that Patch Set 3 was the one that was CQ'd. The mac_chromium_rel_ng tryjob for that patch went through successfully.
,
Sep 20 2016
Interesting indeed. Perhaps some other CL went through around same time that actually caused some specific ColorSpace enum value to be used on Mac?
,
Sep 20 2016
I landed https://codereview.chromium.org/2336853002/ around the same time, but all of that should be behind a flag.
,
Sep 21 2016
Indeed, mac_chromium_rel_ng was ran on PS#3 of https://codereview.chromium.org/2338213009/ at ~12 PM and landed 14:18 MTV time. https://codereview.chromium.org/2336853002 landed ~14:02 MTV time.
,
Sep 28 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dim...@chromium.org
, Sep 20 2016