Today, our download notifications have a period. To follow the spec, we should remove this period for all download notifications including files and pages.
Oh, forgot these were for notifications. Min: do you know where these strings are?
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chrome_strings.grd?q=download_pending&sq=package:chromium&dr=C&l=1663
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4876f0de97118aedbba17f973387bab3f539120a commit 4876f0de97118aedbba17f973387bab3f539120a Author: dfalcantara <dfalcantara@chromium.org> Date: Wed Sep 21 00:42:20 2016 [Download Home] Open supported files in Custom Tabs Downloads stuff: * Add a function to DownloadManagerService that queries whether a MIME type is supported for display in Chrome. * When opening a file via Download Home, query whether the file type is supported. If so, send it to a new tab instead of Intenting out. * Move Share and View intent code out to DownloadUtils and expose constants everywhere to allow this to happen. * Removed periods from download notification Strings. Custom Tab stuff: * Added a "media viewer" intent extra that makes Custom Tabs opened by Download Home hide unnecessary menu items. BUG=616324, 648454 Review-Url: https://codereview.chromium.org/2343363005 Cr-Commit-Position: refs/heads/master@{#419921} [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/BackendProvider.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadFilter.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/browser/android/download/download_manager_service.cc [modify] https://crrev.com/4876f0de97118aedbba17f973387bab3f539120a/chrome/browser/android/download/download_manager_service.h
Comment 1 by dfalcant...@chromium.org
, Sep 19 2016Status: Assigned (was: Untriaged)