New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648448 link

Starred by 1 user
Status: Fixed
Owner:
dpranke@chromium.org
Closed: Sep 2016
Cc:
jam@chromium.org
█ phajdan.jr@chromium.org
█ brettw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

`gn analyze` incorrectly skipped a GN-only change

Project Member Reported by dpranke@chromium.org, Sep 19 2016 
In https://codereview.chromium.org/2355503003/#ps20001 , `analyze` incorrectly decided that no compile was necessary.

It looks like this happened because we check whether any targets were affected *before* checking if any build files were modified :(.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/253b1190a67b4ccac5c8b2583e6b19c6a1c5e3f9

commit 253b1190a67b4ccac5c8b2583e6b19c6a1c5e3f9
Author: dpranke <dpranke@chromium.org>
Date: Tue Sep 20 02:52:56 2016

Fix a bug in `gn analyze` related to build-only changes.

`gn analyze` would incorrectly claim that no compile was necessary
if given a list of files that included build file changes but not
any source file changes.

R=brettw@chromium.org
BUG= 648448 

Review-Url: https://codereview.chromium.org/2355713002
Cr-Commit-Position: refs/heads/master@{#419662}

[modify] https://crrev.com/253b1190a67b4ccac5c8b2583e6b19c6a1c5e3f9/tools/gn/analyzer.cc
[modify] https://crrev.com/253b1190a67b4ccac5c8b2583e6b19c6a1c5e3f9/tools/gn/analyzer_unittest.cc

Comment 2 by dpranke@chromium.org, Sep 21 2016

Status: Fixed (was: Started)
This should be fixed in r419905 w/ the GN roll:

https://codereview.chromium.org/2354123002/

Comment 3 by dpranke@chromium.org, Sep 21 2016 

Whoops, the comment in #2 was meant for  bug 648532 , but this bug is also fixed.
►

Sign in to add a comment