New issue
Advanced search Search tips

Issue 648442 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 638989



Sign in to add a comment

Migrate existing cc remote implementation to use the embedder interface.

Project Member Reported by khushals...@chromium.org, Sep 19 2016

Issue description

The integration points for Blimp on the client and engine need to move out of cc internals. On the engine this would involve implementing the LayerTreeHost interface for blimp and sharing the frame output in proto format with the blimp layer. There are also a lot of interfaces that we use which need to be re-structured as a part of this.

ImageSerializationProcessor: This mostly has interfaces for Engine/Client Picture caches, which are somewhat convoluted because we weren't doing the necessary state tracking inside cc at all. The purpose of these interfaces is just to track the SkPictures used in the current frame, so we can send the diff from the previous frame. I was thinking about structuring the way frame data is shared from cc in the following way:

struct CompositorProtoState {
// Serialized state stored in the LayerTree.
std::unique_ptr<cc::proto::LayerTreeState> layer_tree;

// List of serialized state for the dirty layers. This includes the Inputs in the Layer,
// and the serialized display list. For SkPictures, when we serialize we put the picture's
// unique id for the picture.
std::vector<cc::proto::LayerState> dirty_layers;

// The set of pictures used in this frame.
std::unordered_set<sk_sp<SkPicture>> pictures_;
}

Ideally cc shouldn't have to know about the caching being done in blimp. We'll be generating much more granular deltas from the cc protos for other state as well anyway. Slightly iffy part here is going to be that we might end up having to put what the final frame proto sent to the client looks like in cc, because we can't include protos from other directories right now. :/

RemoteProtoChannel: Its implemented by the RenderWidgetCompositor and is used to IPC compositor proto messages out to the browser. We shouldn't send bytes to/from the renderer anymore for the control messages. Especially because a lot of synchronization/scheduling details that were hidden inside cc protos up till now are now going to be done by blimp.

The other part is the sync protocol. I was thinking that for the transition, we can keep the protocol somewhat consistent with what we have right now. Both the engine and client can send state updates, but have to wait for an Ack from the peer before sending another update. And the ack can piggyback on a state update, so the ack for scroll/scale state from the engine can come with a frame update. This will change a lot when we start adding throttling policy to the frame scheduling logic.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d31bac41bbabd01f14eff89f0fc37cd9016c225

commit 8d31bac41bbabd01f14eff89f0fc37cd9016c225
Author: khushalsagar <khushalsagar@chromium.org>
Date: Mon Oct 03 22:07:51 2016

cc/blimp: Add a LayerTreeHostRemote implementation.

This sets up the framework for a LayerTreeHostRemote that implements
the LayerTreeHost API when the compositor is running across a network
boundary.

This change only sets the framework for running/scheduling main frame
updates and pushing the serialized state using the
CompositorProtoStateSink. Subsequent patches will add state
serialization.

BUG= 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2362073002
Cr-Commit-Position: refs/heads/master@{#422555}

[modify] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/BUILD.gn
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/blimp/compositor_proto_state.cc
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/blimp/compositor_proto_state.h
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/blimp/layer_tree_host_remote.cc
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/blimp/layer_tree_host_remote.h
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/blimp/layer_tree_host_remote_unittest.cc
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/blimp/remote_compositor_bridge.cc
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/blimp/remote_compositor_bridge.h
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/blimp/remote_compositor_bridge_client.h
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/test/fake_remote_compositor_bridge.cc
[add] https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225/cc/test/fake_remote_compositor_bridge.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3f23433d9db7b305ae57ae67a215477a5ffa162

commit f3f23433d9db7b305ae57ae67a215477a5ffa162
Author: horo <horo@chromium.org>
Date: Mon Oct 03 23:45:59 2016

Revert of cc/blimp: Add a LayerTreeHostRemote implementation. (patchset #16 id:300001 of https://codereview.chromium.org/2362073002/ )

Reason for revert:
cc_unittests on Mac-10.9 failing on chromium.mac/Mac10.9 Tests (dbg)
BUG= 652502 

BeginFrameArgsTest.Helpers (run #1):
[ RUN      ] BeginFrameArgsTest.Helpers
../../cc/output/begin_frame_args_unittest.cc:66: Failure
Value of: ::testing::PrintToString(args1)
  Actual: "64-byte object <B6-66 E8-02 01-00 00-00 F6-73 E8-02 01-00 00-00 16-00 00-00 A9-7F 00-00 E1-9C BD-01 01-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 FF-FF FF-FF FF-FF FF-FF 01-00 00-00 01-7F 00-00>"
Expected: std::string("BeginFrameArgs(NORMAL, 0, 0, -1us)")
Which is: "BeginFrameArgs(NORMAL, 0, 0, -1us)"
../../cc/output/begin_frame_args_unittest.cc:68: Failure
Value of: ::testing::PrintToString(args2)
  Actual: "64-byte object <B6-66 E8-02 01-00 00-00 F6-73 E8-02 01-00 00-00 1A-00 00-00 01-00 00-00 3B-9F BD-01 01-00 00-00 01-00 00-00 00-00 00-00 02-00 00-00 00-00 00-00 03-00 00-00 00-00 00-00 01-00 00-00 01-7F 00-00>"
Expected: std::string("BeginFrameArgs(NORMAL, 1, 2, 3us)")
Which is: "BeginFrameArgs(NORMAL, 1, 2, 3us)"
[  FAILED  ] BeginFrameArgsTest.Helpers (1 ms)

Original issue's description:
> cc/blimp: Add a LayerTreeHostRemote implementation.
>
> This sets up the framework for a LayerTreeHostRemote that implements
> the LayerTreeHost API when the compositor is running across a network
> boundary.
>
> This change only sets the framework for running/scheduling main frame
> updates and pushing the serialized state using the
> CompositorProtoStateSink. Subsequent patches will add state
> serialization.
>
> BUG= 648442 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225
> Cr-Commit-Position: refs/heads/master@{#422555}

TBR=wez@chromium.org,dtrainor@chromium.org,danakj@chromium.org,khushalsagar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 648442 

Review-Url: https://codereview.chromium.org/2384333002
Cr-Commit-Position: refs/heads/master@{#422603}

[modify] https://crrev.com/f3f23433d9db7b305ae57ae67a215477a5ffa162/cc/BUILD.gn
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/blimp/compositor_proto_state.cc
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/blimp/compositor_proto_state.h
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/blimp/layer_tree_host_remote.cc
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/blimp/layer_tree_host_remote.h
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/blimp/layer_tree_host_remote_unittest.cc
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/blimp/remote_compositor_bridge.cc
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/blimp/remote_compositor_bridge.h
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/blimp/remote_compositor_bridge_client.h
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/test/fake_remote_compositor_bridge.cc
[delete] https://crrev.com/7f060555f918f54ddb5791850182aa11906183cb/cc/test/fake_remote_compositor_bridge.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0

commit bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0
Author: khushalsagar <khushalsagar@chromium.org>
Date: Tue Oct 04 02:49:06 2016

cc/blimp: Add a LayerTreeHostRemote implementation.

This sets up the framework for a LayerTreeHostRemote that implements
the LayerTreeHost API when the compositor is running across a network
boundary.

This change only sets the framework for running/scheduling main frame
updates and pushing the serialized state using the
CompositorProtoStateSink. Subsequent patches will add state
serialization.

BUG= 648442 , 652502 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225
Review-Url: https://codereview.chromium.org/2362073002
Cr-Original-Commit-Position: refs/heads/master@{#422555}
Cr-Commit-Position: refs/heads/master@{#422679}

[modify] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/BUILD.gn
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/blimp/compositor_proto_state.cc
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/blimp/compositor_proto_state.h
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/blimp/layer_tree_host_remote.cc
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/blimp/layer_tree_host_remote.h
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/blimp/layer_tree_host_remote_unittest.cc
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/blimp/remote_compositor_bridge.cc
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/blimp/remote_compositor_bridge.h
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/blimp/remote_compositor_bridge_client.h
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/test/fake_remote_compositor_bridge.cc
[add] https://crrev.com/bc0b8bebb01af4c46a742a9e119a5eb39ee9aff0/cc/test/fake_remote_compositor_bridge.h

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c4d7f1fac75e0d294b10f7ba465d99469b81d55

commit 0c4d7f1fac75e0d294b10f7ba465d99469b81d55
Author: khushalsagar <khushalsagar@chromium.org>
Date: Tue Oct 04 23:41:17 2016

cc/blimp: Set up the framework for state serialization.

1) Split the inputs and rest of the fields in the protos so we only
serialize the inputs for the new serialization code.
2) Add a CompositorStateDeserializer to deserialize compositor protos.

BUG= 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2375363002
Cr-Commit-Position: refs/heads/master@{#423001}

[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/BUILD.gn
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/compositor_proto_state.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/compositor_proto_state.h
[add] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/compositor_state_deserializer.cc
[add] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/compositor_state_deserializer.h
[add] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/compositor_state_deserializer_client.h
[add] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/compositor_state_deserializer_unittest.cc
[add] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/layer_factory.h
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/layer_tree_host_remote.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/blimp/layer_tree_host_remote.h
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/layer.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/layer.h
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/layer_proto_converter.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/layer_proto_converter.h
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/layer_proto_converter_unittest.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/layer_unittest.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/picture_layer.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/picture_layer.h
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/solid_color_scrollbar_layer.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/layers/solid_color_scrollbar_layer.h
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/proto/compositor_message.proto
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/proto/layer.proto
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/proto/layer_tree.proto
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/proto/layer_tree_host.proto
[add] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/test/remote_client_layer_factory.cc
[add] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/test/remote_client_layer_factory.h
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/trees/layer_tree.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/trees/layer_tree.h
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/trees/layer_tree_host_in_process.cc
[modify] https://crrev.com/0c4d7f1fac75e0d294b10f7ba465d99469b81d55/cc/trees/layer_tree_host_unittest_serialization.cc

Blocking: 638989
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c45674e6ea22517379009bf8fcf3fc44288c11a5

commit c45674e6ea22517379009bf8fcf3fc44288c11a5
Author: khushalsagar <khushalsagar@chromium.org>
Date: Mon Oct 10 22:55:12 2016

cc/blimp: Add (de)-serialization for PictureLayer and ScrollbarLayer.

This adds support for serializing these layers from the new code path
and brings us in parity with what the data the existing code serializes.

BUG= 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2397843003
Cr-Commit-Position: refs/heads/master@{#424271}

[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/BUILD.gn
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/compositor_state_deserializer.cc
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/compositor_state_deserializer.h
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/compositor_state_deserializer_unittest.cc
[add] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/deserialized_content_layer_client.cc
[add] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/deserialized_content_layer_client.h
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/layer_factory.h
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/layer_tree_host_remote.cc
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/layer_tree_host_remote.h
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/blimp/layer_tree_host_remote_unittest.cc
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/layers/layer.cc
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/layers/layer.h
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/layers/layer_unittest.cc
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/layers/picture_layer.cc
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/layers/solid_color_scrollbar_layer.cc
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/layers/solid_color_scrollbar_layer.h
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/proto/layer.proto
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/test/remote_client_layer_factory.cc
[modify] https://crrev.com/c45674e6ea22517379009bf8fcf3fc44288c11a5/cc/test/remote_client_layer_factory.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f3826f1afa9948747c198f8da4444956677f0f2

commit 1f3826f1afa9948747c198f8da4444956677f0f2
Author: khushalsagar <khushalsagar@chromium.org>
Date: Thu Oct 13 21:38:26 2016

cc/blimp: Set up hooks for scroll/scale sync.

Sets up a hook on the RemoteCompositorBridgeClient to pipe scroll/scale
updates from the client and apply to the LayerTreeHostClient. Also sets
up proxying of these through the LayerTreeHostRemoteForTesting for
LayerTreeTests.

BUG= 653371 , 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2404953002
Cr-Commit-Position: refs/heads/master@{#425172}

[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/blimp/layer_tree_host_remote.cc
[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/blimp/layer_tree_host_remote.h
[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/blimp/layer_tree_host_remote_unittest.cc
[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/blimp/remote_compositor_bridge_client.h
[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/test/fake_remote_compositor_bridge.h
[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/test/layer_tree_host_remote_for_testing.cc
[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/test/layer_tree_host_remote_for_testing.h
[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/test/layer_tree_test.h
[modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/trees/layer_tree_host_unittest_scroll.cc

Cc: klo...@chromium.org khushals...@chromium.org
 Issue 597825  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06

commit d3cbb4d90d7367030d637cbb7b68b2293f6ebe06
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed Oct 26 01:33:51 2016

content/blimp: Set up hooks for enabling LTHRemote in the renderer.

Sets up hooks for requesting a RemoteCompositorBridge from the
ContentRendererClient, which is necessary to create a remote
LayerTreeHost. Also adds an implementation of the Bridge in blimp.

BUG= 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2413063002
Cr-Commit-Position: refs/heads/master@{#427569}

[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/blimp/engine/BUILD.gn
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/blimp/engine/renderer/blimp_content_renderer_client.cc
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/blimp/engine/renderer/blimp_content_renderer_client.h
[add] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/blimp/engine/renderer/blimp_remote_compositor_bridge.cc
[add] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/blimp/engine/renderer/blimp_remote_compositor_bridge.h
[add] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/blimp/engine/renderer/frame_scheduler.cc
[add] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/blimp/engine/renderer/frame_scheduler.h
[add] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/blimp/engine/renderer/frame_scheduler_unittest.cc
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/cc/blimp/layer_tree_host_remote.cc
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/cc/layers/picture_layer.cc
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/cc/proto/compositor_message.proto
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/content/public/common/content_switches.cc
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/content/public/common/content_switches.h
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/d3cbb4d90d7367030d637cbb7b68b2293f6ebe06/content/renderer/gpu/render_widget_compositor.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4245f395cb2607101cc4dc2decf956429eabf3e4

commit 4245f395cb2607101cc4dc2decf956429eabf3e4
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed Oct 26 05:35:04 2016

blimp: Add mode to use the updated compositing path on the client.

Sets up the code to use a threaded LayerTreeHost on the BlimpCompositor
on the client. The compositor now creates a threaded
LayerTreeHostInProcess. The flow of updates is as follows:

1) The engine will send a frame update in the CompositorMessage.
2) On receiving the update, the client requests the LayerTreeHost to
schedule a main frame.
3) When the LayerTreeHost asks its client to update its state, the
frame update in the proto is deserialized using the
CompositorStateDeserializer.

BUG= 648442 

Review-Url: https://codereview.chromium.org/2415633003
Cr-Commit-Position: refs/heads/master@{#427597}

[modify] https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4/blimp/client/core/compositor/blimp_compositor.cc
[modify] https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4/blimp/client/core/compositor/blimp_compositor.h
[modify] https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4/blimp/client/core/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4/blimp/client/core/render_widget/BUILD.gn
[modify] https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4/blimp/client/core/render_widget/blimp_document.cc
[modify] https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4/blimp/client/core/render_widget/blimp_document_manager_unittest.cc
[modify] https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4/blimp/client/core/switches/blimp_client_switches.cc
[modify] https://crrev.com/4245f395cb2607101cc4dc2decf956429eabf3e4/blimp/client/core/switches/blimp_client_switches.h

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2be75f5c7053765d71b23424d94501194c9e6f81

commit 2be75f5c7053765d71b23424d94501194c9e6f81
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed Nov 02 07:45:12 2016

blimp: Use SwapPromises for readback API.

The tests try to grab a snapshot of the compositor output right after
receiving an update from the engine, and so want to make sure that the
CompositorFrame on which the request is made is from the source frame
that came from the engine.

This is done by reading the commit messages before giving them to
the compositor, and keeping a track of frames drawn for commits made
to ensure that a request is made after the drawn frame reaches the
main thread.

The tracking logic is messy, and requires unnecessary commit tracking,
which especially gets confusing with the mode that uses a threaded
compositor on the client, since each commit/draw no longer maps to
an update from the engine.

This patch replaces that logic with SwapPromises, which is the API
meant to be used for tracking the progress of a frame through the
cc pipeline. The existing logic is still retained for the old code
path, since using SwapPromises requires local commits, which can't
be done in that mode.

BUG= 648442 

Review-Url: https://codereview.chromium.org/2459823003
Cr-Commit-Position: refs/heads/master@{#429230}

[modify] https://crrev.com/2be75f5c7053765d71b23424d94501194c9e6f81/blimp/client/core/compositor/blimp_compositor.cc
[modify] https://crrev.com/2be75f5c7053765d71b23424d94501194c9e6f81/blimp/client/core/compositor/blimp_compositor.h
[modify] https://crrev.com/2be75f5c7053765d71b23424d94501194c9e6f81/blimp/client/core/contents/blimp_contents_view_impl.cc
[modify] https://crrev.com/2be75f5c7053765d71b23424d94501194c9e6f81/blimp/client/core/render_widget/blimp_document_manager.cc
[modify] https://crrev.com/2be75f5c7053765d71b23424d94501194c9e6f81/blimp/client/core/render_widget/blimp_document_manager.h

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f

commit c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f
Author: khushalsagar <khushalsagar@chromium.org>
Date: Fri Nov 04 05:53:13 2016

cc/blimp: Add synchronization for scroll/scale state.

Add the protocol messages and the primitives to synchronize mutations
to scroll and scale state on the engine and client. The protocol has
been kept largely consistent with the message passing between the main
and impl thread, as follows:

1) Both the engine and client can send an update to the other peer at
any time, but must wait for an ack from the other peer before sending
another update.

2) If the engine receives an update from the client, it must send the
resulting frame with the acknowledgement for this update. This is
consistent with the behaviour in the threaded compositor where the
main thread always responds with a BeginMainFrameAborted or commit
for deltas sent from the impl thread.

However, as opposed to the threaded compositor, the communication
between the engine and client is completely asynchronous. Enabling
this requires state tracking on the client to track the deltas
seen by the engine, when pushing the resulting frame update to
the impl thread, so the impl thread can apply those deltas
post-commit instead of expecting the main thread to reflect these
values. The change adds a SyncedPropertyRemote primitive, which acts
as the main thread equivalent of SyncedProperty, to perform this for
all state that can be modified on the engine or client.

BUG= 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2445093002
Cr-Commit-Position: refs/heads/master@{#429801}

[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/core/compositor/BUILD.gn
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/core/compositor/blimp_compositor.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/core/compositor/blimp_compositor.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/core/compositor/blimp_compositor_unittest.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/core/render_widget/blimp_document.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/core/render_widget/blimp_document_manager_unittest.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/test/compositor/BUILD.gn
[add] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/test/compositor/blimp_compositor_with_fake_host.cc
[add] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/client/test/compositor/blimp_compositor_with_fake_host.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/engine/BUILD.gn
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/engine/app/settings_manager.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/engine/renderer/blimp_remote_compositor_bridge.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/engine/renderer/blimp_remote_compositor_bridge.h
[add] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/engine/renderer/blimp_remote_compositor_bridge_unittest.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/engine/renderer/frame_scheduler.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/engine/renderer/frame_scheduler.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/blimp/engine/renderer/frame_scheduler_unittest.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/BUILD.gn
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/compositor_state_deserializer.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/compositor_state_deserializer.h
[delete] https://crrev.com/5b9d52e8a6ec9c11a675bae21c7d1b0448689fb6/cc/blimp/compositor_state_deserializer_client.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/compositor_state_deserializer_unittest.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/layer_tree_host_remote.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/layer_tree_host_remote.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/layer_tree_host_remote_unittest.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/remote_compositor_bridge_client.h
[add] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/synced_property_remote.h
[add] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/blimp/synced_property_remote_unittest.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/proto/BUILD.gn
[add] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/proto/client_state_update.proto
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/proto/compositor_message.proto
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/test/layer_tree_host_remote_for_testing.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/test/layer_tree_host_remote_for_testing.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/trees/layer_tree.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/trees/layer_tree.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/trees/layer_tree_host_common.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/trees/layer_tree_host_in_process.cc
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/trees/layer_tree_host_in_process.h
[modify] https://crrev.com/c48291b306dcaf99e5bf33451a30f9ac4fc7ab0f/cc/trees/layer_tree_host_unittest_scroll.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8cab90b9d0ffccd136c0d8135444951b7a24f0e

commit f8cab90b9d0ffccd136c0d8135444951b7a24f0e
Author: khushalsagar <khushalsagar@chromium.org>
Date: Fri Nov 04 19:21:22 2016

blimp: Enable the updated compositing path by default.

Set up the engine and client side flags on startup for enabling the mode
by default.

BUG= 648442 

Review-Url: https://codereview.chromium.org/2476873002
Cr-Commit-Position: refs/heads/master@{#429972}

[modify] https://crrev.com/f8cab90b9d0ffccd136c0d8135444951b7a24f0e/blimp/client/core/context/blimp_client_context_impl.cc
[modify] https://crrev.com/f8cab90b9d0ffccd136c0d8135444951b7a24f0e/blimp/engine/app/blimp_engine_config.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb

commit 4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed Nov 09 19:07:28 2016

content/blimp: Remove unused compositing mode switches.

Removing the unnecessary switches/code since the updated code path is
used by default. This removes the content and blimp side of the code.
The next patch will remove code in cc.

BUG= 648442 

Review-Url: https://codereview.chromium.org/2489033002
Cr-Commit-Position: refs/heads/master@{#430996}

[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/blimp/client/core/compositor/blimp_compositor.cc
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/blimp/client/core/compositor/blimp_compositor.h
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/blimp/client/core/context/blimp_client_context_impl.cc
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/blimp/client/core/render_widget/blimp_document.cc
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/blimp/client/core/switches/blimp_client_switches.cc
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/blimp/client/core/switches/blimp_client_switches.h
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/blimp/client/test/compositor/blimp_compositor_with_fake_host.cc
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/blimp/engine/app/blimp_engine_config.cc
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/content/public/common/content_switches.cc
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/content/public/common/content_switches.h
[modify] https://crrev.com/4fd21d5ba7992fac71db4f5f1a8f13b5bc4a8dfb/content/renderer/gpu/render_widget_compositor.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7eae9db07da0e2198fd95936046d719c7e78753

commit c7eae9db07da0e2198fd95936046d719c7e78753
Author: khushalsagar <khushalsagar@chromium.org>
Date: Sat Nov 12 04:43:42 2016

cc: Remove client/engine LayerTreeHostInProcess.

Remove all unused code in LayerTreeHostInProcess for the remote mode.
All code for this is now in cc/blimp, so this removes the code for the
deprecated path. Clean up for proto conversion code is going to be in
a subsequent patch.

BUG= 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2494623002
Cr-Commit-Position: refs/heads/master@{#431772}

[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/blimp/client/core/compositor/blimp_compositor.h
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/blimp/engine/renderer/blimp_content_renderer_client.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/blimp/engine/renderer/blimp_content_renderer_client.h
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/blimp/engine/renderer/blimp_remote_compositor_bridge.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/blimp/engine/renderer/blimp_remote_compositor_bridge.h
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/blimp/engine/renderer/blimp_remote_compositor_bridge_unittest.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/BUILD.gn
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/blimp/compositor_state_deserializer_unittest.cc
[add] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/blimp/layer_tree_host_unittest_serialization.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/test/fake_layer_tree_host.h
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/test/layer_tree_host_remote_for_testing.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/test/layer_tree_test.h
[add] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/test/remote_compositor_test.cc
[add] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/test/remote_compositor_test.h
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/test/remote_proto_channel_bridge.cc
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/test/remote_proto_channel_bridge.h
[add] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/test/serialization_test_utils.cc
[add] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/test/serialization_test_utils.h
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/trees/layer_tree.h
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/trees/layer_tree_host_in_process.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/trees/layer_tree_host_in_process.h
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/trees/layer_tree_host_unittest_remote_server.cc
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/trees/layer_tree_host_unittest_serialization.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/trees/proxy_main.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/cc/trees/proxy_main.h
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/trees/remote_channel_impl.cc
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/trees/remote_channel_impl.h
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/trees/remote_channel_main.cc
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/trees/remote_channel_main.h
[delete] https://crrev.com/4ff7b40b01046d703b33c4c96a491fdb923d20cd/cc/trees/remote_proto_channel.h
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/content/public/renderer/BUILD.gn
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/content/public/renderer/content_renderer_client.h
[add] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/content/public/renderer/remote_proto_channel.h
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753/content/renderer/gpu/render_widget_compositor.h

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb82c56db89fe47dc93b3fc59294bf61e7e82748

commit bb82c56db89fe47dc93b3fc59294bf61e7e82748
Author: khushalsagar <khushalsagar@chromium.org>
Date: Sat Nov 12 07:52:10 2016

cc: Remove unused proto conversion code.

This removes the unused proto conversion code from layers and updates
the tests.

BUG= 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2493523003
Cr-Commit-Position: refs/heads/master@{#431779}

[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/blimp/client/test/compositor/blimp_compositor_with_fake_host.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/BUILD.gn
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/blimp/layer_tree_host_remote.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/blimp/layer_tree_host_unittest_serialization.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/layers/layer.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/layers/layer.h
[delete] https://crrev.com/4b5e64d3c7aadaffe9131291fe503a46ea0809d3/cc/layers/layer_proto_converter.cc
[delete] https://crrev.com/4b5e64d3c7aadaffe9131291fe503a46ea0809d3/cc/layers/layer_proto_converter.h
[delete] https://crrev.com/4b5e64d3c7aadaffe9131291fe503a46ea0809d3/cc/layers/layer_proto_converter_unittest.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/layers/layer_unittest.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/layers/picture_layer.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/layers/picture_layer.h
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/layers/solid_color_scrollbar_layer.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/layers/solid_color_scrollbar_layer.h
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/playback/recording_source.h
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/test/fake_remote_compositor_bridge.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/test/fake_remote_compositor_bridge.h
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/test/push_properties_counting_layer.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/test/push_properties_counting_layer.h
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/test/remote_compositor_test.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/test/remote_compositor_test.h
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/test/serialization_test_utils.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/test/serialization_test_utils.h
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/trees/layer_tree.cc
[modify] https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748/cc/trees/layer_tree.h

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7

commit 4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7
Author: khushalsagar <khushalsagar@chromium.org>
Date: Sat Nov 12 09:21:48 2016

cc/blimp: Proto Cleanup.

Remove all unused protos and serialization code.

BUG= 648442 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2493853002
Cr-Commit-Position: refs/heads/master@{#431782}

[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/BUILD.gn
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/animation/element_id.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/animation/element_id.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/blimp/compositor_state_deserializer.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/debug/layer_tree_debug_state.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/debug/layer_tree_debug_state.h
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/debug/layer_tree_debug_state_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/layers/heads_up_display_layer.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/layers/heads_up_display_layer.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/output/begin_frame_args.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/output/begin_frame_args.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/output/begin_frame_args_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/output/managed_memory_policy.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/output/managed_memory_policy.h
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/output/managed_memory_policy_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/output/renderer_settings.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/output/renderer_settings.h
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/output/renderer_settings_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/playback/recording_source.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/playback/recording_source.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/playback/recording_source_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/proto/BUILD.gn
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/begin_main_frame_and_commit_state.proto
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/proto/cc_conversions.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/proto/cc_conversions.h
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/commit_earlyout_reason.proto
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/proto/compositor_message.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/compositor_message_to_impl.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/compositor_message_to_main.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/element_id.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/gpu_conversions.cc
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/gpu_conversions.h
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/gpu_conversions_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/proto/layer.proto
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/proto/layer_tree.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/layer_tree_debug_state.proto
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/proto/layer_tree_host.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/managed_memory_policy.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/memory_allocation.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/property_tree.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/recording_source.proto
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/proto/region.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/renderer_settings.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/synced_property.proto
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/synced_property_conversions.cc
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/synced_property_conversions.h
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/proto/synced_property_conversions_unittest.cc
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/scheduler/commit_earlyout_reason.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/scheduler/commit_earlyout_reason.h
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/scheduler/commit_earlyout_reason_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/test/layer_tree_test.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/clip_node.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/clip_node.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/effect_node.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/effect_node.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/layer_tree_host_common.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/property_tree.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/property_tree.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/property_tree_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/proxy_common.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/proxy_common.h
[delete] https://crrev.com/3d9470fdda9685d803ea3b9c481b6659bb9a9edc/cc/trees/proxy_common_unittest.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/scroll_node.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/scroll_node.h
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/transform_node.cc
[modify] https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7/cc/trees/transform_node.h

Status: Fixed (was: Assigned)

Sign in to add a comment