New issue
Advanced search Search tips

Issue 648435 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

WindowServer shouldn't send messages during shutdown

Project Member Reported by sky@chromium.org, Sep 19 2016

Issue description

If the windowserver is shutdown it ends up sending a bunch of messages to the client (mostly deletes). When the windowserver is shutdown it shouldn't send any messages. The client will see the connection loss and can take whatever action is appropriate.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2

commit 20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2
Author: sky <sky@chromium.org>
Date: Tue Sep 20 03:42:42 2016

Makes windowserver not send messages during shutdown

To send messages during shutdown means clients may process messages in
weird order. The windowserver should not send any messages during
shutdown. The client can detect connection loss and take whatever
action is appropriate.

It may be we want a specific message to indicate the windowserver is going
down normally vs a crash, but for now I'm only making it so no
messages are sent.

BUG= 648435 
TEST=covered by test
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2352893002
Cr-Commit-Position: refs/heads/master@{#419670}

[modify] https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2/services/ui/ws/test_utils.cc
[modify] https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2/services/ui/ws/test_utils.h
[modify] https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2/services/ui/ws/window_server.cc
[modify] https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2/services/ui/ws/window_tree.cc
[modify] https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2/services/ui/ws/window_tree.h
[modify] https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2/services/ui/ws/window_tree_binding.cc
[modify] https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2/services/ui/ws/window_tree_binding.h
[modify] https://crrev.com/20e6c7ecccbcd292abc95fe906bd987cf9cb2bf2/services/ui/ws/window_tree_unittest.cc

Comment 2 by sky@chromium.org, Sep 20 2016

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 4 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 5 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment