New issue
Advanced search Search tips

Issue 648423 link

Starred by 2 users
Status: Duplicate
Merged: issue 826218
Owner: ----
Closed: Aug 30
Cc:
yangguo@chromium.org
brucedaw...@chromium.org
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 718157
issue pdfium:559



Sign in to add a comment

build/vs_toolchain.py imports gyp

Project Member Reported by thestig@chromium.org, Sep 19 2016 
We have stopped using GYP in PDFium, but we still need to pull in tools/gyp. PDFium uses Chromium's build/vs_toolchain.py, which calls "import gyp" to read GYP_DEFINES and look for windows_sdk_path.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b24fa5e6df163fc6aaea2fbc9150016af90a2ce

commit 9b24fa5e6df163fc6aaea2fbc9150016af90a2ce
Author: thestig <thestig@chromium.org>
Date: Sat Mar 11 01:46:42 2017

Only import gyp when required in vs_toolchain.py.

Also replace some elifs after returns with ifs.

BUG= 648423 

Review-Url: https://codereview.chromium.org/2745863002
Cr-Commit-Position: refs/heads/master@{#456250}

[modify] https://crrev.com/9b24fa5e6df163fc6aaea2fbc9150016af90a2ce/build/vs_toolchain.py

Comment 2 by machenb...@chromium.org, Feb 15 2018

Cc: yangguo@chromium.org
 Issue 811260  has been merged into this issue.

Comment 3 by machenb...@chromium.org, Feb 15 2018

Blocking: 718157

Comment 4 by thestig@chromium.org, Aug 30

Mergedinto: 826218
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment