New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648422 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

simplify updating of hterm/crosh in CrOS builds

Project Member Reported by vapier@chromium.org, Sep 19 2016

Issue description

since hterm/crosh have largely stabilized at this point, we should update the process of getting updates into CrOS canary builds so we don't have to manually update the crosh_builtin.zip anymore.  this will also improve testing/feedback cycles for hterm releases.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/cf8f7b3684a747d95297e12f019de1b9682be504

commit cf8f7b3684a747d95297e12f019de1b9682be504
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 19 22:03:33 2016

hterm: allow $VCSID to control git rev info

When building via ebuilds, we don't have a full git checkout,
so let the $VCSID env var tell us the git info directly.

BUG= chromium:648422 
TEST=building inside an ebuild gets the right git sha1 info
TEST=building outside an ebuild gets the right git sha1 info

Change-Id: I913413e784fe29476d65a3651879688e5cb8ec1f
Reviewed-on: https://chromium-review.googlesource.com/386718
Reviewed-by: Rob Ginda <rginda@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/cf8f7b3684a747d95297e12f019de1b9682be504/hterm/concat/hterm_resources.concat

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/cf8f7b3684a747d95297e12f019de1b9682be504

commit cf8f7b3684a747d95297e12f019de1b9682be504
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 19 22:03:33 2016

hterm: allow $VCSID to control git rev info

When building via ebuilds, we don't have a full git checkout,
so let the $VCSID env var tell us the git info directly.

BUG= chromium:648422 
TEST=building inside an ebuild gets the right git sha1 info
TEST=building outside an ebuild gets the right git sha1 info

Change-Id: I913413e784fe29476d65a3651879688e5cb8ec1f
Reviewed-on: https://chromium-review.googlesource.com/386718
Reviewed-by: Rob Ginda <rginda@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/cf8f7b3684a747d95297e12f019de1b9682be504/hterm/concat/hterm_resources.concat

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/c94ee0890ac62553cc501e6670bbf10b42059afe

commit c94ee0890ac62553cc501e6670bbf10b42059afe
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 19 22:28:04 2016

nassh: import crosh build script

This is the script we use to build the archive for bundling crosh
into Chromium OS.

BUG= chromium:648422 
TEST=building an image with this code and crosh still works

Change-Id: Ia3e68526ef29ea1755144f780b4122397995075c
Reviewed-on: https://chromium-review.googlesource.com/387066
Reviewed-by: Rob Ginda <rginda@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/c94ee0890ac62553cc501e6670bbf10b42059afe/nassh/bin/mkcrosh.sh

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/266fd571c8049d4a7f36fa298f4ec84c6e6c3f0a

commit 266fd571c8049d4a7f36fa298f4ec84c6e6c3f0a
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 19 22:01:32 2016

add libapps to checkout for hterm/crosh

This repo holds the latest hterm/crosh code.

BUG= chromium:648422 
TEST=`repo sync` checks out the code to the right place
CQ-DEPEND=CL:*288255

Change-Id: I5862fb4807aa005519dc145b20d80963e830cc91
Reviewed-on: https://chromium-review.googlesource.com/387045
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Rob Ginda <rginda@chromium.org>

[modify] https://crrev.com/266fd571c8049d4a7f36fa298f4ec84c6e6c3f0a/full.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/09f7be6f5cb3ee5d90b50c10e8e288be8e951165

commit 09f7be6f5cb3ee5d90b50c10e8e288be8e951165
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 19 22:26:17 2016

crosh-extension: split crosh_builtin into dedicated package

This makes it easy for us to automatically pull in the latest version
from upstream into CrOS.  The previous system required us to bundle a
precompiled archive whenever we wanted to get an update in.

BUG= chromium:648422 
TEST=building an image and crosh still loads/works
CQ-DEPEND=CL:387045, CL:*288255

Change-Id: I7ed370889703cf43c07d46bce723ba3cbeb60085
Reviewed-on: https://chromium-review.googlesource.com/387085
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Rob Ginda <rginda@chromium.org>

[add] https://crrev.com/09f7be6f5cb3ee5d90b50c10e8e288be8e951165/chromeos-base/common-assets/files/chromeos-version.sh
[add] https://crrev.com/09f7be6f5cb3ee5d90b50c10e8e288be8e951165/chromeos-base/crosh-extension/crosh-extension-9999.ebuild
[rename] https://crrev.com/09f7be6f5cb3ee5d90b50c10e8e288be8e951165/virtual/target-chromium-os/target-chromium-os-1-r53.ebuild
[modify] https://crrev.com/09f7be6f5cb3ee5d90b50c10e8e288be8e951165/virtual/target-chromium-os/target-chromium-os-1.ebuild
[add] https://crrev.com/09f7be6f5cb3ee5d90b50c10e8e288be8e951165/chromeos-base/crosh-extension/files/chromeos-version.sh
[modify] https://crrev.com/09f7be6f5cb3ee5d90b50c10e8e288be8e951165/chromeos-base/common-assets/common-assets-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/1db606f84a4b4b131cb0d480c4176d6e008360cd

commit 1db606f84a4b4b131cb0d480c4176d6e008360cd
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 19 22:08:05 2016

crosh_builtin: punt

We've moved to building this dynamically from the latest upstream
source repo now.

BUG= chromium:648422 
TEST=building an image still has a working crosh
CQ-DEPEND=CL:387085

Change-Id: Ib67848116bf600de0ef7fc81c154864a7624bbd9
Reviewed-on: https://chromium-review.googlesource.com/387065
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Rob Ginda <rginda@chromium.org>

[delete] https://crrev.com/7427c1755db44d5a09cfa3d7b778b128a4a57edb/chromeapps/crosh_builtin/rezip.sh
[delete] https://crrev.com/7427c1755db44d5a09cfa3d7b778b128a4a57edb/chromeapps/crosh_builtin/README
[delete] https://crrev.com/7427c1755db44d5a09cfa3d7b778b128a4a57edb/chromeapps/crosh_builtin/crosh_builtin.zip

Comment 7 by vapier@chromium.org, Sep 22 2016

Status: Fixed (was: Started)
should be done now

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)

Sign in to add a comment