Drag and drop: gmail and inbox's drag shadows are enormous |
||||||||||
Issue descriptionSteps to reproduce: 1. enable drag and drop on webview "--enable-touch-drag-drop" 2. open an email thread in gmail 3. long press to select some text 4. long press the same text to start drag and drop 5. observe that the shadow image is way bigger than the text.
,
Sep 20 2016
We didn't apply the page scale when producing the bitmap. The WebView in gmail app has a page scale of 0.42, while my own drag and drop test app has a page scale of 1. I will have a fix out in a brief moment. ppolisetty: could you add this case into your test plan? Basically, make sure the drag shadow image is the same as what you drag in gmail and inbox.
,
Sep 20 2016
hush@, thanks, sure I'll add it.
,
Sep 20 2016
Hello kravula@: This problem is reproducible on Clank too. You just need to go to chrome Settings->Accessiblity-> Check the box for "Force Enable Zoom" Then go to a site and zoom in on the page. You will see that the drag shadow image is too small.
,
Sep 20 2016
kravula@: Please add this test case to chrome's test plan too.
,
Sep 20 2016
,
Sep 20 2016
FYI fix is in code review: https://codereview.chromium.org/2352773003/
,
Sep 20 2016
The bug is reproducible on ChromeOS as well. I tried on kaznacheev@'s chromebook. This is not surprising because the blink code that generates the image does not consider page scale factor.
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adba2165f4c6e1c7d4a78179d6e066aa8e37f938 commit adba2165f4c6e1c7d4a78179d6e066aa8e37f938 Author: hush <hush@chromium.org> Date: Thu Sep 22 02:26:58 2016 Fix the scale of Drag and Drop shadow image. Physical Pixel = CSS pixel * DIP scale * page scale. In the case of our bitmap shadow image, page scale is not applied to it. BUG= 648413 Review-Url: https://codereview.chromium.org/2352773003 Cr-Commit-Position: refs/heads/master@{#420243} [modify] https://crrev.com/adba2165f4c6e1c7d4a78179d6e066aa8e37f938/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/adba2165f4c6e1c7d4a78179d6e066aa8e37f938/third_party/WebKit/Source/core/frame/LocalFrameTest.cpp
,
Sep 22 2016
,
Sep 22 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7cafe4f263044ed309cabf89b0333827199c864 commit b7cafe4f263044ed309cabf89b0333827199c864 Author: Hui Shu <hush@google.com> Date: Thu Sep 22 02:55:06 2016 Fix the scale of Drag and Drop shadow image. Physical Pixel = CSS pixel * DIP scale * page scale. In the case of our bitmap shadow image, page scale is not applied to it. BUG= 648413 Review-Url: https://codereview.chromium.org/2352773003 Cr-Commit-Position: refs/heads/master@{#420243} (cherry picked from commit adba2165f4c6e1c7d4a78179d6e066aa8e37f938) Review URL: https://codereview.chromium.org/2361653003 . Cr-Commit-Position: refs/branch-heads/2840@{#485} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b7cafe4f263044ed309cabf89b0333827199c864/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/b7cafe4f263044ed309cabf89b0333827199c864/third_party/WebKit/Source/core/frame/LocalFrameTest.cpp
,
Sep 22 2016
,
Sep 28 2016
Fix verified on Pixel C/NRD91M, seed/NRD91M, Monochrome: 54.0.2840.42
,
Sep 28 2016
"Chrome on Android" ->Verified in M54-54.0.2840.42 build on Nexus 9/NRD91M
,
Oct 6 2016
Fix verified on Nexus6/NRD91N, Monochrome: 55.0.2882.3
,
Oct 19 2016
Checked on M55 ChromeOS dev on minnie. The text is bigger but not not enormous
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7cafe4f263044ed309cabf89b0333827199c864 commit b7cafe4f263044ed309cabf89b0333827199c864 Author: Hui Shu <hush@google.com> Date: Thu Sep 22 02:55:06 2016 Fix the scale of Drag and Drop shadow image. Physical Pixel = CSS pixel * DIP scale * page scale. In the case of our bitmap shadow image, page scale is not applied to it. BUG= 648413 Review-Url: https://codereview.chromium.org/2352773003 Cr-Commit-Position: refs/heads/master@{#420243} (cherry picked from commit adba2165f4c6e1c7d4a78179d6e066aa8e37f938) Review URL: https://codereview.chromium.org/2361653003 . Cr-Commit-Position: refs/branch-heads/2840@{#485} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b7cafe4f263044ed309cabf89b0333827199c864/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/b7cafe4f263044ed309cabf89b0333827199c864/third_party/WebKit/Source/core/frame/LocalFrameTest.cpp |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by hush@chromium.org
, Sep 19 20161.0 MB
1.0 MB View Download