New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648404 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Input boost not triggered by single-touch touchscreen

Project Member Reported by denniskempin@chromium.org, Sep 19 2016

Issue description

We definitely want to input boost for single-touch touchscreens just as we do for multi-touch.
 
Status: WontFix (was: Started)

Comment 2 by dtor@chromium.org, Sep 19 2016

Status: Started (was: WontFix)
Not only touchscreens, but also stylises and joysticks/gamepads as well.

Comment 3 by dtor@chromium.org, Sep 19 2016

Labels: OS-Chrome
Owner: dtor@chromium.org

Comment 4 by bleung@chromium.org, Sep 19 2016

Cc: bleung@chromium.org
Components: Internals>Input>Touch>Screen

Comment 6 by moch@chromium.org, Sep 21 2016

Cc: moch@chromium.org
Labels: Merge-Request-54
https://chromium-review.googlesource.com/#/c/387006/ - CL in commit queue. Requesting for merge to M54
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21 2016

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e040fbf3ceab0a7e889c737e9923e29099c84cd2

commit e040fbf3ceab0a7e889c737e9923e29099c84cd2
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Mon Sep 19 21:05:51 2016

CHROMIUM: cpufreq_interactive - bind to more input devices

There are non-multitouch input devices, such as joysticks, gamepads and
stylises, that should also cause cCPU frequency boost as long as they
are in use.

BUG= chromium:648404 
TEST=Boot kevin and check CPU frequency while using stylus.

Change-Id: Id72cbeaed287d63e8cfc0554606bc7b3180404b5
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/387006
Reviewed-by: Benson Leung <bleung@chromium.org>

[modify] https://crrev.com/e040fbf3ceab0a7e889c737e9923e29099c84cd2/drivers/cpufreq/cpufreq_interactive.c

Comment 8 by josa...@google.com, Sep 21 2016

Labels: -Merge-Request-54 Merge-Approved-54
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21 2016

Labels: merge-merged-release-R54-8743.B-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/50cbc945a77c8eeae04d29520f18c4f3efb1f23c

commit 50cbc945a77c8eeae04d29520f18c4f3efb1f23c
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Mon Sep 19 21:05:51 2016

CHROMIUM: cpufreq_interactive - bind to more input devices

There are non-multitouch input devices, such as joysticks, gamepads and
stylises, that should also cause cCPU frequency boost as long as they
are in use.

BUG= chromium:648404 
TEST=Boot kevin and check CPU frequency while using stylus.

Change-Id: Id72cbeaed287d63e8cfc0554606bc7b3180404b5
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/387006
Reviewed-by: Benson Leung <bleung@chromium.org>
(cherry picked from commit e040fbf3ceab0a7e889c737e9923e29099c84cd2)
Reviewed-on: https://chromium-review.googlesource.com/387885
Reviewed-by: Dennis Kempin <denniskempin@google.com>
Commit-Queue: Dennis Kempin <denniskempin@google.com>
Tested-by: Dennis Kempin <denniskempin@google.com>

[modify] https://crrev.com/50cbc945a77c8eeae04d29520f18c4f3efb1f23c/drivers/cpufreq/cpufreq_interactive.c

Project Member

Comment 10 by sheriffbot@chromium.org, Sep 25 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 28 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by dtor@chromium.org, Sep 28 2016

Labels: -Merge-Approved-54

Comment 13 by dtor@chromium.org, Oct 4 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Using stylus, see that current frequency jumps by two orders of magnitude.

watch cat /sys/devices/system/cpu/cpu*/cpufreq/cpuinfo_cur_freq

Sign in to add a comment