New issue
Advanced search Search tips

Issue 648381 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Nov 7
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

follow-up cleanups to MD infobars

Project Member Reported by est...@chromium.org, Sep 19 2016 
here are two vaguely related things we should address in the near future:
1. views infobars should use the non-dark native theme always (currently incognito infobars use the dark native theme). This would also allow us to stop hard coding the bg of non-CTA infobar buttons.
2. this [1]

[1] https://codereview.chromium.org/2347773003/diff/1/chrome/browser/ui/views/infobars/infobar_container_view.cc#newcode83
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e2ba781cab15260aaf2b14c3584b22a361a5448

commit 9e2ba781cab15260aaf2b14c3584b22a361a5448
Author: estade <estade@chromium.org>
Date: Tue Sep 20 15:55:24 2016

Remove pre-MD infobar code (on Views).

BUG= 648381 ,  648281 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2347773003
Cr-Commit-Position: refs/heads/master@{#419778}

[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_left_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_left_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_left_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_right_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_right_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_right_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_center_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_center_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_center_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_left_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_left_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_left_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_right_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_right_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_right_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_left_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_left_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_left_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_right_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_right_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_right_pressed.png
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/confirm_infobar.h
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_background.cc
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_background.h
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_container_view.cc
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_view.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49aa74f940257565de95367b42c76208cb37d837

commit 49aa74f940257565de95367b42c76208cb37d837
Author: estade <estade@chromium.org>
Date: Mon Jan 09 20:00:15 2017

Allow a View to specify a non-default native theme (i.e. different from
that of its Widget).

Apply this in the case of infobars.

BUG= 648381 

Review-Url: https://codereview.chromium.org/2613343002
Cr-Commit-Position: refs/heads/master@{#442319}

[modify] https://crrev.com/49aa74f940257565de95367b42c76208cb37d837/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/49aa74f940257565de95367b42c76208cb37d837/ui/views/view.cc
[modify] https://crrev.com/49aa74f940257565de95367b42c76208cb37d837/ui/views/view.h

Comment 3 by robliao@chromium.org, Sep 19

Labels: Hotlist-UITriageDeferred

Comment 4 by est...@chromium.org, Nov 7

Status: Fixed (was: Assigned)
►

Sign in to add a comment