Will suppress.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9397c4c08db43f76d4bf5be9b74fad715f59f51f

commit 9397c4c08db43f76d4bf5be9b74fad715f59f51f
Author: kbr <kbr@chromium.org>
Date: Tue Sep 20 01:43:59 2016

Suppress a couple of flaky tests.

conformance/textures/webgl_canvas/tex-2d-rgb-rgb-unsigned_byte.html
conformance2/textures/video/tex-2d-rgba16f-rgba-half_float.html

BUG= 648337 ,  648377 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2349313003
Cr-Commit-Position: refs/heads/master@{#419636}

[modify] https://crrev.com/9397c4c08db43f76d4bf5be9b74fad715f59f51f/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/9397c4c08db43f76d4bf5be9b74fad715f59f51f/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Also seen once on WebglConformance_conformance_textures_webgl_canvas_tex_2d_rgba_rgba_unsigned_byte :

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/319689

WebglConformance_conformance_textures_webgl_canvas_tex_2d_rgba_rgba_unsigned_byte (gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest) ... Received signal 11 SEGV_MAPERR 0000ffffffff
 [0x000105ef4536]
 [0x7fff9935752a]
 [0x000000000019]
 [0x7fff8eb67e3c]
 [0x7fff980473dc]
 [0x7fff98046f63]
 [0x7fff98045582]
 [0x7fff98043341]
[end of stack trace]
[10035:1295:1020/171300:INFO:CONSOLE(131)] "GL_INVALID_OPERATION : glGenSyncTokenCHROMIUM: fence sync must be flushed before generating sync token", source: http://127.0.0.1:55926/third_party/webgl/src/sdk/tests/js/tests/tex-image-and-sub-image-2d-with-webgl-canvas.js (131)
[10039:1295:1020/171300:FATAL:DrawingBuffer.cpp(727)] Check failed: produceSyncToken.HasData(). 
0   Chromium Framework                  0x000000010de6e683 _ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x000000010de91737 _ZN7logging10LogMessageD2Ev + 71
2   Chromium Framework                  0x00000001113abf44 _ZN5blink13DrawingBuffer21copyToPlatformTextureEPN3gpu5gles214GLES2InterfaceEjjjibbNS_19SourceDrawingBufferE + 484
3   Chromium Framework                  0x0000000112c060f2 _ZN5blink25WebGLRenderingContextBase19texImageCanvasByGPUEPNS_17HTMLCanvasElementEjjji + 242
4   Chromium Framework                  0x0000000112c064a4 _ZN5blink25WebGLRenderingContextBase13texImageByGPUENS0_17TexImageByGPUTypeEPNS_12WebGLTextureEjiijiiiPNS_17CanvasImageSourceE + 612
5   Chromium Framework                  0x0000000112c06aef _ZN5blink25WebGLRenderingContextBase31texImageHelperHTMLCanvasElementENS0_18TexImageFunctionIDEjiijjiiiPNS_17HTMLCanvasElementERNS_14ExceptionStateE + 847
6   Chromium Framework                  0x0000000112c07d2f _ZN5blink25WebGLRenderingContextBase13texSubImage2DEjiiijjPNS_17HTMLCanvasElementERNS_14ExceptionStateE + 47
7   Chromium Framework                  0x0000000112813a73 _ZN5blink31WebGLRenderingContextV8Internal27texSubImage2DMethodCallbackERKN2v820FunctionCallbackInfoINS1_5ValueEEE + 4451
8   Chromium Framework                  0x000000010c226608 _ZN2v88internal25FunctionCallbackArguments4CallEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEE + 408
9   Chromium Framework                  0x000000010c2f0b85 _ZN2v88internal12_GLOBAL__N_119HandleApiCallHelperILb0EEENS0_11MaybeHandleINS0_6ObjectEEEPNS0_7IsolateENS0_6HandleINS0_10HeapObjectEEESA_NS8_INS0_20FunctionTemplateInfoEEENS8_IS4_EENS0_16BuiltinArgumentsE + 1013
10  Chromium Framework                  0x000000010c2ef8da _ZN2v88internalL26Builtin_Impl_HandleApiCallENS0_16BuiltinArgumentsEPNS0_7IsolateE + 330
11  Chromium Framework                  0x000000010c2ef56b _ZN2v88internal21Builtin_HandleApiCallEiPPNS0_6ObjectEPNS0_7IsolateE + 219
12  ???                                 0x0000077068a843a7 0x0 + 8179373589415

Another on WebglConformance_conformance_textures_webgl_canvas_tex_2d_rgba_rgba_unsigned_byte here, I think:

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/318859

WebglConformance_conformance_textures_webgl_canvas_tex_2d_rgba_rgba_unsigned_byte (gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest) ... Received signal 11 SEGV_MAPERR 011ee6c58000
 [0x000107868206]
 [0x7fff94eb652a]
 [0x7fff8adb8796]
 [0x7fff8ad47e3c]
 [0x7fff8dd8c3dc]
 [0x7fff8dd8bf63]
 [0x7fff8dd8a582]
 [0x7fff8dd88341]
[end of stack trace]
[17128:1295:1019/164458:INFO:CONSOLE(86)] "GL_OUT_OF_MEMORY : glCreateGpuMemoryBufferImageCHROMIUM: image_id < 0", source: http://127.0.0.1:58371/third_party/webgl/src/sdk/tests/js/tests/tex-image-and-sub-image-2d-with-webgl-canvas.js (86)
[17128:1295:1019/164458:INFO:CONSOLE(90)] "GL_OUT_OF_MEMORY : glCreateGpuMemoryBufferImageCHROMIUM: image_id < 0", source: http://127.0.0.1:58371/third_party/webgl/src/sdk/tests/js/tests/tex-image-and-sub-image-2d-with-webgl-canvas.js (90)
[17128:1295:1019/164458:INFO:CONSOLE(90)] "GL_OUT_OF_MEMORY : glCreateGpuMemoryBufferImageCHROMIUM: image_id < 0", source: http://127.0.0.1:58371/third_party/webgl/src/sdk/tests/js/tests/tex-image-and-sub-image-2d-with-webgl-canvas.js (90)
[17128:1295:1019/164458:INFO:CONSOLE(133)] "GL_INVALID_OPERATION : glGenSyncTokenCHROMIUM: fence sync must be flushed before generating sync token", source: http://127.0.0.1:58371/third_party/webgl/src/sdk/tests/js/tests/tex-image-and-sub-image-2d-with-webgl-canvas.js (133)
[17136:1295:1019/164458:ERROR:gles2_cmd_decoder.cc(16705)] [.DisplayCompositor-0x7fad21941400]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name
[17136:1295:1019/164458:ERROR:gles2_cmd_decoder.cc(11691)] [.DisplayCompositor-0x7fad21941400]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format
[17136:1295:1019/164458:ERROR:gles2_cmd_decoder.cc(16705)] [.DisplayCompositor-0x7fad21941400]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name
[17136:1295:1019/164458:ERROR:gles2_cmd_decoder.cc(11691)] [.DisplayCompositor-0x7fad21941400]GL ERROR :GL_INVALID_VALUE : glScheduleCALayerCHROMIUM: unsupported texture format
[17132:1295:1019/164458:FATAL:DrawingBuffer.cpp(727)] Check failed: produceSyncToken.HasData(). 
0   Chromium Framework                  0x0000000109206353 _ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x0000000109229407 _ZN7logging10LogMessageD2Ev + 71
2   Chromium Framework                  0x000000010c733744 _ZN5blink13DrawingBuffer21copyToPlatformTextureEPN3gpu5gles214GLES2InterfaceEjjjibbNS_19SourceDrawingBufferE + 484
3   Chromium Framework                  0x000000010df83d92 _ZN5blink25WebGLRenderingContextBase19texImageCanvasByGPUEPNS_17HTMLCanvasElementEjjji + 242
4   Chromium Framework                  0x000000010df84144 _ZN5blink25WebGLRenderingContextBase13texImageByGPUENS0_17TexImageByGPUTypeEPNS_12WebGLTextureEjiijiiiPNS_17CanvasImageSourceE + 612
5   Chromium Framework                  0x000000010df8478f _ZN5blink25WebGLRenderingContextBase31texImageHelperHTMLCanvasElementENS0_18TexImageFunctionIDEjiijjiiiPNS_17HTMLCanvasElementERNS_14ExceptionStateE + 847
6   Chromium Framework                  0x000000010df848a8 _ZN5blink25WebGLRenderingContextBase10texImage2DEjiijjPNS_17HTMLCanvasElementERNS_14ExceptionStateE + 40
7   Chromium Framework                  0x000000010db96d7e _ZN5blink31WebGLRenderingContextV8Internal24texImage2DMethodCallbackERKN2v820FunctionCallbackInfoINS1_5ValueEEE + 3742
8   Chromium Framework                  0x00000001075a0cb8 _ZN2v88internal25FunctionCallbackArguments4CallEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEE + 408
9   Chromium Framework                  0x000000010766ada5 _ZN2v88internal12_GLOBAL__N_119HandleApiCallHelperILb0EEENS0_11MaybeHandleINS0_6ObjectEEEPNS0_7IsolateENS0_6HandleINS0_10HeapObjectEEESA_NS8_INS0_20FunctionTemplateInfoEEENS8_IS4_EENS0_16BuiltinArgumentsE + 1013
10  Chromium Framework                  0x0000000107669afa _ZN2v88internalL26Builtin_Impl_HandleApiCallENS0_16BuiltinArgumentsEPNS0_7IsolateE + 330
11  Chromium Framework                  0x000000010766978b _ZN2v88internal21Builtin_HandleApiCallEiPPNS0_6ObjectEPNS0_7IsolateE + 219
12  ???                                 0x0000381e38e043a7 0x0 + 61702454395815

I have seen the same DCHECK(produceSyncToken.HasData()) firing in WebglConformance_conformance_ogles_GL_radians_radians_001_to_006 here
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/11036

Perhaps this is a more general issue than a flaky test?

The assertion's clearly wrong -- it needs to take the possibility of context loss into consideration.

Kai, could you take this? The DCHECK needs to be transformed into an early-out, at least. However, this may just move the crash around.

[48547:775:1128/140841:FATAL:DrawingBuffer.cpp(712)] Check failed: produceSyncToken.HasData(). 
0 Chromium Framework 0x0000000111ea38d3 _ZN4base5debug10StackTraceC1Ev + 19
1 Chromium Framework 0x0000000111ec7ba7 _ZN7logging10LogMessageD2Ev + 71
2 Chromium Framework 0x000000011570742e _ZN5blink13DrawingBuffer21copyToPlatformTextureEPN3gpu5gles214GLES2InterfaceEjjjibbRKNS_8IntPointERKNS_7IntRectENS_19SourceDrawingBufferE + 462
3 Chromium Framework 0x00000001156cc3da _ZN5blink11ImageBuffer37copyRenderingResultsFromDrawingBufferEPNS_13DrawingBufferENS_19SourceDrawingBufferE + 202
4 Chromium Framework 0x000000011717cf29 _ZN5blink25WebGLRenderingContextBase29paintRenderingResultsToCanvasENS_19SourceDrawingBufferE + 185
5 Chromium Framework 0x0000000116361b9e _ZNK5blink17HTMLCanvasElement11toImageDataENS_19SourceDrawingBufferENS_14SnapshotReasonE + 110
6 Chromium Framework 0x0000000116361995 _ZNK5blink17HTMLCanvasElement17toDataURLInternalERKN3WTF6StringERKdNS_19SourceDrawingBufferE + 517
7 Chromium Framework 0x0000000116361ff4 _ZNK5blink17HTMLCanvasElement9toDataURLERKN3WTF6StringERKNS_11ScriptValueERNS_14ExceptionStateE + 180
8 Chromium Framework 0x0000000115d04fa4 _ZNK5blink17HTMLCanvasElement9toDataURLERKN3WTF6StringERNS_14ExceptionStateE + 36
9 Chromium Framework 0x0000000115d042bd _ZN5blink27HTMLCanvasElementV8Internal23toDataURLMethodCallbackERKN2v820FunctionCallbackInfoINS1_5ValueEEE + 1005
10 Chromium Framework 0x000000010fffb9f7 _ZN2v88internal25FunctionCallbackArguments4CallEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEE + 391
11 Chromium Framework 0x00000001100d9462 _ZN2v88internal12_GLOBAL__N_119HandleApiCallHelperILb0EEENS0_11MaybeHandleINS0_6ObjectEEEPNS0_7IsolateENS0_6HandleINS0_10HeapObjectEEESA_NS8_INS0_20FunctionTemplateInfoEEENS8_IS4_EENS0_16BuiltinArgumentsE + 866
12 Chromium Framework 0x00000001100d7dad _ZN2v88internalL26Builtin_Impl_HandleApiCallENS0_16BuiltinArgumentsEPNS0_7IsolateE + 429
13 Chromium Framework 0x00000001100d79f5 _ZN2v88internal21Builtin_HandleApiCallEiPPNS0_6ObjectEPNS0_7IsolateE + 197

I have a patch for this but haven't been able to upload it. (I suspect an issue with the build tools environment on my laptop.) Anyway, since it seems no one has reliably reproduced it, how do we want to test whether that works? Do we need to remove the suppression along with this change?

Yes, let's try taking out the flaky suppressions at the same time the DCHECK is removed. Note that the patch from https://bugs.chromium.org/p/chromium/issues/detail?id=609252#c59 may have affected the behavior here.

BTW, that fix landed:
https://codereview.chromium.org/2567733002/

I'm not seeing any relevant flakiness on chromium-try-flakes, so I think this is probably fixed.