New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648336 link

Starred by 1 user
Status: Fixed
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
vmp...@chromium.org
schenney@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Clean up TODOs found while researching rasterize_and_record_micro.

Project Member Reported by wkorman@chromium.org, Sep 19 2016 
https://cs.chromium.org/chromium/src/cc/playback/recording_source.h?q=recording_source.h&sq=package:chromium&dr=CSs&l=34

  // TODO(schenney) Remove RECORD_WITH_SK_NULL_CANVAS when we no longer
  // support a non-Slimming Paint path.

note from schenney@ just now:

  This was intended to capture the costs of Blink-paint only, with
  no Skia cost included. But now we get that with the various
  display item list modes.

There are also four TODOs in rasterize_and_record_micro.py that look like they can be cleaned up:

https://cs.chromium.org/chromium/src/tools/perf/measurements/rasterize_and_record_micro.py?type=cs&q=rasterize_and_record_micro+record_time_sk_null_canvas&sq=package:chromium&l=88
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8531e12bcc6df76cbfe95afc60c4ad59717868

commit 8a8531e12bcc6df76cbfe95afc60c4ad59717868
Author: wkorman <wkorman@chromium.org>
Date: Tue Sep 27 00:49:42 2016

Clean up TODOs in rasterize_and_record_micro.py

BUG= 648336 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2352783004
Cr-Commit-Position: refs/heads/master@{#421055}

[modify] https://crrev.com/8a8531e12bcc6df76cbfe95afc60c4ad59717868/tools/perf/measurements/rasterize_and_record_micro.py
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e41c6f8e524772b3b7a8e31313c047f8d53947a

commit 2e41c6f8e524772b3b7a8e31313c047f8d53947a
Author: wkorman <wkorman@chromium.org>
Date: Tue Sep 27 06:47:19 2016

Remove obsolete RECORD_WITH_SK_NULL_CANVAS recording mode.

BUG= 648336 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2355723002
Cr-Commit-Position: refs/heads/master@{#421131}

[modify] https://crrev.com/2e41c6f8e524772b3b7a8e31313c047f8d53947a/cc/debug/rasterize_and_record_benchmark.cc
[modify] https://crrev.com/2e41c6f8e524772b3b7a8e31313c047f8d53947a/cc/playback/recording_source.h
[modify] https://crrev.com/2e41c6f8e524772b3b7a8e31313c047f8d53947a/tools/perf/measurements/rasterize_and_record_micro.py

Comment 3 by wkorman@chromium.org, Sep 27 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment