New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648309 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Mar 2017
Cc:
█ rginda@chromium.org
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

libdot.fs uses deprecated FileError API

Project Member Reported by vapier@chromium.org, Sep 19 2016 
the FileError API was dropped from Chrome earlier this year:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/kJMa2rpAYqI/discussion

apparently it'd been deprecated since Aug 2013.  it doesn't seem to be breaking SecureShell, but we should still fix it.  loading atm shows in the console:
Uncaught ReferenceError: FileError is not defined
    at Object.lib.fs.installFileErrorToString (nassh_deps.concat.js:17119)
    at nassh_deps.concat.js:17063
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/b05d6b9ec958e1faa5deab553619dfa04cbebd65

commit b05d6b9ec958e1faa5deab553619dfa04cbebd65
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Mar 10 23:42:55 2017

libdot: drop FileError handling for DOMError

Starting with Chrome 53, the FileError interface no longer exists.
They're pushing people to work with DOMError objects instead.

We can drop lib.fs.installFileErrorToString as the issue it addresses
no longer exists: DOMError only provides a .name member and does not
provide a .code field at all.

We can also drop lib.fs.getFileErrorMnemonic for the same reason --
there is no code anymore to look up.  Plus, there do not appear to be
any callers of this API.

URL: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
BUG= chromium:648309 
TEST=loading secure shell still works

Change-Id: Ifc03718b8f9a51ae569db79c46c800a93fa255ac
Reviewed-on: https://chromium-review.googlesource.com/448172
Reviewed-by: Rob Ginda <rginda@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b05d6b9ec958e1faa5deab553619dfa04cbebd65/libdot/doc/ChangeLog.md
[modify] https://crrev.com/b05d6b9ec958e1faa5deab553619dfa04cbebd65/libdot/js/lib_fs.js

Comment 2 by vapier@chromium.org, Mar 11 2017

Owner: vapier@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment