AudioBufferOptions.numberOfChannels defaults to 1 |
|||
Issue descriptionSpec recently changed so that numberOfChannels defaults to 1 and the sampleRate defaults to the context.sampleRate. Chrome already (inadvertently) implemented the default for sampleRate. Update implementation to default the numberOfChannels. Spec issue: https://github.com/WebAudio/web-audio-api/issues/962 Resolved: https://github.com/WebAudio/web-audio-api/pull/972
,
Oct 10 2016
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b99bb23039bb2457a509282f8fc9b839072ca8a commit 5b99bb23039bb2457a509282f8fc9b839072ca8a Author: rtoy <rtoy@chromium.org> Date: Tue Oct 11 17:05:47 2016 AudioBuffer numberOfChannels defaults to 1 Also make AudioBufferOptions.length be required. Spec: https://webaudio.github.io/web-audio-api/#audiobufferoptions BUG= 648298 TEST=constructor/audiobuffer.html updated Review-Url: https://codereview.chromium.org/2397793002 Cr-Commit-Position: refs/heads/master@{#424462} [modify] https://crrev.com/5b99bb23039bb2457a509282f8fc9b839072ca8a/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffer.html [modify] https://crrev.com/5b99bb23039bb2457a509282f8fc9b839072ca8a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp [modify] https://crrev.com/5b99bb23039bb2457a509282f8fc9b839072ca8a/third_party/WebKit/Source/modules/webaudio/AudioBufferOptions.idl
,
Oct 17 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rtoy@chromium.org
, Oct 4 2016