arc: Multiple default apps on shelf for Drag&Drop of Play Store app. |
||||||||
Issue descriptionThere are many default app items appear on Chrome shelf in case dragging PlayStore item from App List to shelf. Inner Bug: b/31556052
,
Sep 19 2016
,
Sep 19 2016
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2 commit ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2 Author: khmel <khmel@chromium.org> Date: Mon Sep 19 18:00:13 2016 arc: Fix Drag&Drop for PlayStore item from App List to Shelf. PlayStore is special app that actually represents 2 apps in Chrome. One is OptIn flow as native Platform App, second is Android Play Store app itself. For user we represent them as one app and do special mapping for Chrome shelf. This CL adds missing functionality for correct mapping. TEST=unit_tests TEST=Manually on device with all combination, app was pinned or not before, App (PlayStore and OptIn) was running or not. BUG=b/31556052 BUG= 648285 Review-Url: https://codereview.chromium.org/2349263002 Cr-Commit-Position: refs/heads/master@{#419502} [modify] https://crrev.com/ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc [modify] https://crrev.com/ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
,
Sep 19 2016
Request to merge M54, M53. crrev.com/2349313002 is ready to merge to m53 and was tested manually on minnie.
,
Sep 19 2016
Please do, thanks for the fix!
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2f600968902714a4307ae7c880dc40400de515d commit f2f600968902714a4307ae7c880dc40400de515d Author: khmel <khmel@chromium.org> Date: Mon Sep 19 18:34:59 2016 [Merge-M53] arc: Fix Drag&Drop for PlayStore item from App List to Shelf. PlayStore is special app that actually represents 2 apps in Chrome. One is OptIn flow as native Platform App, second is Android Play Store app itself. For user we represent them as one app and do special mapping for Chrome shelf. This CL adds missing functionality for correct mapping. TEST=unit_tests TEST=Manually on device with all combination, app was pinned or not before, App (PlayStore and OptIn) was running or not. BUG=b/31556052 BUG= 648285 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2349263002 Cr-Commit-Position: refs/heads/master@{#419502} (cherry picked from commit ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2) Review-Url: https://codereview.chromium.org/2349313002 Cr-Commit-Position: refs/branch-heads/2785@{#908} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/f2f600968902714a4307ae7c880dc40400de515d/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc [modify] https://crrev.com/f2f600968902714a4307ae7c880dc40400de515d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d426e37b587062c69745001f7fffaa19f4528d35 commit d426e37b587062c69745001f7fffaa19f4528d35 Author: khmel <khmel@chromium.org> Date: Mon Sep 19 21:14:58 2016 [Merge-M54] arc: Fix Drag&Drop for PlayStore item from App List to Shelf. PlayStore is special app that actually represents 2 apps in Chrome. One is OptIn flow as native Platform App, second is Android Play Store app itself. For user we represent them as one app and do special mapping for Chrome shelf. This CL adds missing functionality for correct mapping. TEST=unit_tests TEST=Manually on device with all combination, app was pinned or not before, App (PlayStore and OptIn) was running or not. BUG=b/31556052 BUG= 648285 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2349263002 Cr-Commit-Position: refs/heads/master@{#419502} (cherry picked from commit ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2) Review-Url: https://codereview.chromium.org/2356513002 Cr-Commit-Position: refs/branch-heads/2840@{#419} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d426e37b587062c69745001f7fffaa19f4528d35/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc [modify] https://crrev.com/d426e37b587062c69745001f7fffaa19f4528d35/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
,
Sep 19 2016
,
Sep 20 2016
Issue 647707 has been merged into this issue.
,
Sep 20 2016
Chrome OS 53.0.2785.129/8530.90.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d426e37b587062c69745001f7fffaa19f4528d35 commit d426e37b587062c69745001f7fffaa19f4528d35 Author: khmel <khmel@chromium.org> Date: Mon Sep 19 21:14:58 2016 [Merge-M54] arc: Fix Drag&Drop for PlayStore item from App List to Shelf. PlayStore is special app that actually represents 2 apps in Chrome. One is OptIn flow as native Platform App, second is Android Play Store app itself. For user we represent them as one app and do special mapping for Chrome shelf. This CL adds missing functionality for correct mapping. TEST=unit_tests TEST=Manually on device with all combination, app was pinned or not before, App (PlayStore and OptIn) was running or not. BUG=b/31556052 BUG= 648285 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2349263002 Cr-Commit-Position: refs/heads/master@{#419502} (cherry picked from commit ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2) Review-Url: https://codereview.chromium.org/2356513002 Cr-Commit-Position: refs/branch-heads/2840@{#419} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d426e37b587062c69745001f7fffaa19f4528d35/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc [modify] https://crrev.com/d426e37b587062c69745001f7fffaa19f4528d35/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by khmel@chromium.org
, Sep 19 2016