New issue
Advanced search Search tips

Issue 648283 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AudioBufferSourceOptions.buffer is nullable

Project Member Reported by rtoy@chromium.org, Sep 19 2016 
It should be valid to do

new AudioBufferSourceNode(context, {buffer: null})

See https://github.com/WebAudio/web-audio-api/issues/980

ConvolverOptions also has this issue, but it was fixed in https://codereview.chromium.org/2352463002/
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2582f835f9351586c831e87b0cf69318cf6c971e

commit 2582f835f9351586c831e87b0cf69318cf6c971e
Author: rtoy <rtoy@chromium.org>
Date: Tue Sep 20 18:52:42 2016

AudioBufferSourceOptions.buffer should be nullable.

It's valid to set the buffer to null in the constructor.

Also added a test for ConvolverOptions which has the same issue, which
was updated in https://codereview.chromium.org/2352463002/

Spec issue: https://github.com/WebAudio/web-audio-api/issues/980

BUG= 648283 ,  626449 ,  647693 
TEST=constructor/audiobuffersource.html, constructor/convolver.html

Review-Url: https://codereview.chromium.org/2348373002
Cr-Commit-Position: refs/heads/master@{#419830}

[modify] https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
[modify] https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
[modify] https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceOptions.idl

Comment 2 by rtoy@chromium.org, Sep 23 2016

Status: Fixed (was: Available)
►

Sign in to add a comment