New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648281 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 649368



Sign in to add a comment

Remove pre-Material Design UI codepaths from top chrome

Project Member Reported by est...@chromium.org, Sep 19 2016

Issue description

MD top chrome has launched to stable on all platforms. We no longer need to support the old raster UI.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e2ba781cab15260aaf2b14c3584b22a361a5448

commit 9e2ba781cab15260aaf2b14c3584b22a361a5448
Author: estade <estade@chromium.org>
Date: Tue Sep 20 15:55:24 2016

Remove pre-MD infobar code (on Views).

BUG= 648381 ,  648281 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2347773003
Cr-Commit-Position: refs/heads/master@{#419778}

[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_left_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_left_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_left_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_right_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_right_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_bottom_right_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_center_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_center_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_center_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_left_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_left_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_left_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_right_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_right_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_right_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_left_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_left_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_left_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_pressed.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_right_hover.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_right_normal.png
[delete] https://crrev.com/38e3c2977c913973fc7237089560ce7fc0822bc4/chrome/app/theme/default_100_percent/common/infobarbutton_top_right_pressed.png
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/confirm_infobar.h
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_background.cc
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_background.h
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_container_view.cc
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/9e2ba781cab15260aaf2b14c3584b22a361a5448/chrome/browser/ui/views/infobars/infobar_view.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55703dc355aea777f1ed3707d456c55f8e99bd4e

commit 55703dc355aea777f1ed3707d456c55f8e99bd4e
Author: estade <estade@chromium.org>
Date: Tue Sep 20 18:38:12 2016

Remove ability to switch to pre-MD UI from about:flags.

Remove this flag now so that people who are using it don't get weird/
broken UI as we remove pre-MD code little by little.

The flag remains to allow toggling between normal and hybrid. The user-
facing strings are rephrased as "normal" and "touch" with no mention of
Material Design. Internal nomenclature is left alone.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2355513002
Cr-Commit-Position: refs/heads/master@{#419825}

[modify] https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e/chrome/app/generated_resources.grd
[modify] https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e/chrome/browser/about_flags.cc
[modify] https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e/chrome/browser/extensions/extension_action_icon_factory_unittest.cc
[modify] https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e/chrome/browser/ui/layout_constants.h
[modify] https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
[modify] https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e/ui/base/material_design/material_design_controller.cc
[modify] https://crrev.com/55703dc355aea777f1ed3707d456c55f8e99bd4e/ui/base/material_design/material_design_controller.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceac6e97046c46b4c10ff7e6412777ba1ce9d55c

commit ceac6e97046c46b4c10ff7e6412777ba1ce9d55c
Author: estade <estade@chromium.org>
Date: Wed Sep 21 19:52:57 2016

Remove pre-MD find bar code in Views.

BUG= 648281 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2356903002
Cr-Commit-Position: refs/heads/master@{#420138}

[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_dialog_left.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_dialog_middle.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_dialog_right.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_dlg_left_bg.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_dlg_right_bg.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_next.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_next_disabled.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_next_hover.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_next_pressed.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_prev.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_prev_disabled.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_prev_hover.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_100_percent/common/find_prev_pressed.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_dialog_left.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_dialog_middle.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_dialog_right.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_dlg_left_bg.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_dlg_right_bg.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_next.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_next_disabled.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_next_hover.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_next_pressed.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_prev.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_prev_disabled.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_prev_hover.png
[delete] https://crrev.com/cfb3e626fa48710631739466f82c9944fd24f0f8/chrome/app/theme/default_200_percent/common/find_prev_pressed.png
[modify] https://crrev.com/ceac6e97046c46b4c10ff7e6412777ba1ce9d55c/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/ceac6e97046c46b4c10ff7e6412777ba1ce9d55c/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/ceac6e97046c46b4c10ff7e6412777ba1ce9d55c/chrome/browser/ui/views/find_bar_view.h

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d

commit 8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d
Author: estade <estade@chromium.org>
Date: Wed Sep 21 20:10:31 2016

Remove non-md code in location bar (Views).

Some of the assets and APIs are left behind because Mac still uses them for now. OmniboxView::GetIcon and ToolbarModel::GetIcon are two examples.

BUG= 648281 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2348853004
Cr-Commit-Position: refs/heads/master@{#420142}

[delete] https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd/chrome/app/theme/default_100_percent/common/omnibox_border.png
[delete] https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd/chrome/app/theme/default_100_percent/common/omnibox_keyword_hint_tab.png
[delete] https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd/chrome/app/theme/default_100_percent/pdf.png
[delete] https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd/chrome/app/theme/default_200_percent/common/omnibox_border.png
[delete] https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd/chrome/app/theme/default_200_percent/common/omnibox_keyword_hint_tab.png
[delete] https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd/chrome/app/theme/default_200_percent/pdf.png
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/keyword_hint_view.h
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/location_icon_view.h
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/selected_keyword_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/selected_keyword_view.h
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/star_view.cc
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/location_bar/star_view.h
[modify] https://crrev.com/8bb3fa56dda5f1eb17f796e0a2fca965e14aa28d/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Comment 5 by est...@chromium.org, Sep 22 2016

Blockedon: 649368
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee

commit f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee
Author: estade <estade@chromium.org>
Date: Thu Sep 22 15:45:35 2016

Remove pre-MD code from bookmark bar (Views).

One small behavioral change: the drag/drop indicator uses
the text color, so it's actually visible on dark themes.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2357353003
Cr-Commit-Position: refs/heads/master@{#420354}

[modify] https://crrev.com/f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
[modify] https://crrev.com/f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af2ccbcc10d941a54c45676bb141ebf1e6f74d25

commit af2ccbcc10d941a54c45676bb141ebf1e6f74d25
Author: estade <estade@chromium.org>
Date: Fri Sep 23 01:18:30 2016

Remove some pre-MD code from toolbar/tabstrip/frame.

Initially I only intended to remove pre-MD code from OpaqueBrowserFrameView, but this led to removals in other files as well. I did not attempt to remove all pre-MD code from all of these files, so, for example, tab.cc still has some pre-MD code.

BUG= 648281 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2360803002
Cr-Commit-Position: refs/heads/master@{#420532}

[delete] https://crrev.com/c9f955347ebd914373fd1c41b12b8e4ea3dfc159/chrome/app/theme/default_100_percent/common/ash/content_top_center.png
[delete] https://crrev.com/c9f955347ebd914373fd1c41b12b8e4ea3dfc159/chrome/app/theme/default_100_percent/common/content_top_center.png
[delete] https://crrev.com/c9f955347ebd914373fd1c41b12b8e4ea3dfc159/chrome/app/theme/default_100_percent/common/content_top_left_corner.png
[delete] https://crrev.com/c9f955347ebd914373fd1c41b12b8e4ea3dfc159/chrome/app/theme/default_100_percent/common/content_top_left_corner_mask.png
[delete] https://crrev.com/c9f955347ebd914373fd1c41b12b8e4ea3dfc159/chrome/app/theme/default_100_percent/common/content_top_right_corner.png
[delete] https://crrev.com/c9f955347ebd914373fd1c41b12b8e4ea3dfc159/chrome/app/theme/default_100_percent/common/content_top_right_corner_mask.png
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/themes/browser_theme_pack.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/layout_constants.h
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/browser_view_layout.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/browser_view_unittest.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_delegate.h
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/af2ccbcc10d941a54c45676bb141ebf1e6f74d25/chrome/browser/ui/views/toolbar/toolbar_view.h

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e7f8463da166c56f6d60bbab42893a1470f9b2b

commit 6e7f8463da166c56f6d60bbab42893a1470f9b2b
Author: estade <estade@chromium.org>
Date: Fri Sep 23 01:26:42 2016

A few more pre-MD code removal cleanups in DownloadItemView.

Things I missed in the first pass.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2363473002
Cr-Commit-Position: refs/heads/master@{#420533}

[modify] https://crrev.com/6e7f8463da166c56f6d60bbab42893a1470f9b2b/chrome/browser/ui/views/download/download_item_view.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b5f8947027c3d01a8474dae08b8caf0e06fc4ea

commit 8b5f8947027c3d01a8474dae08b8caf0e06fc4ea
Author: estade <estade@chromium.org>
Date: Fri Sep 23 22:39:05 2016

Always use vector icons for desktop infobars (when one is defined),
rather than caring about the (deprecated) material design mode.

Make IDR_INFOBAR_SAVE_PASSWORD android-only.

BUG= 648281 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2361843003
Cr-Commit-Position: refs/heads/master@{#420748}

[modify] https://crrev.com/8b5f8947027c3d01a8474dae08b8caf0e06fc4ea/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/8b5f8947027c3d01a8474dae08b8caf0e06fc4ea/chrome/browser/ssl/ssl_add_certificate.cc
[modify] https://crrev.com/8b5f8947027c3d01a8474dae08b8caf0e06fc4ea/components/infobars/core/infobar_delegate.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bac57d0ba546705cb0987bd53138ac1172770bbb

commit bac57d0ba546705cb0987bd53138ac1172770bbb
Author: estade <estade@chromium.org>
Date: Mon Sep 26 22:47:43 2016

Remove pre-MD code from browser/ui/views/tabs/tab.cc

BUG= 648281 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2368653002
Cr-Commit-Position: refs/heads/master@{#421027}

[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/common/tab_active_center.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/common/tab_active_left.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/common/tab_active_right.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/common/tab_alpha_left.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/common/tab_alpha_right.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/common/tab_inactive_center.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/common/tab_inactive_left.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/common/tab_inactive_right.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/mac/tab_inactive_center.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/mac/tab_inactive_left.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_100_percent/mac/tab_inactive_right.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/common/tab_active_center.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/common/tab_active_left.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/common/tab_active_right.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/common/tab_alpha_left.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/common/tab_alpha_right.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/common/tab_inactive_center.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/common/tab_inactive_left.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/common/tab_inactive_right.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/mac/tab_inactive_center.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/mac/tab_inactive_left.png
[delete] https://crrev.com/e83042ee5983abc9d0e2ae34134b5cd213bd618f/chrome/app/theme/default_200_percent/mac/tab_inactive_right.png
[modify] https://crrev.com/bac57d0ba546705cb0987bd53138ac1172770bbb/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/bac57d0ba546705cb0987bd53138ac1172770bbb/chrome/browser/ui/views/tabs/tab.cc

Comment 11 by woxxom@gmail.com, Sep 28 2016

One of the commits caused a regression, supposedly, please see bisect in  https://crbug.com/649948 
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d982acf0da90234b529418522191095473e016a2

commit d982acf0da90234b529418522191095473e016a2
Author: estade <estade@chromium.org>
Date: Thu Sep 29 17:12:49 2016

Remove a couple desktop infobar png assets.

BUG= 648281 
TBR=oshima@chromium.org,rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2372243003
Cr-Commit-Position: refs/heads/master@{#421855}

[delete] https://crrev.com/06026296a7064398df486a54cee379caa3ab22d9/chrome/app/theme/default_100_percent/common/infobar_alt_nav_url.png
[delete] https://crrev.com/06026296a7064398df486a54cee379caa3ab22d9/chrome/app/theme/default_100_percent/common/infobar_theme.png
[delete] https://crrev.com/06026296a7064398df486a54cee379caa3ab22d9/chrome/app/theme/default_200_percent/common/infobar_alt_nav_url.png
[delete] https://crrev.com/06026296a7064398df486a54cee379caa3ab22d9/chrome/app/theme/default_200_percent/common/infobar_theme.png
[modify] https://crrev.com/d982acf0da90234b529418522191095473e016a2/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/d982acf0da90234b529418522191095473e016a2/chrome/browser/extensions/theme_installed_infobar_delegate.cc
[modify] https://crrev.com/d982acf0da90234b529418522191095473e016a2/chrome/browser/extensions/theme_installed_infobar_delegate.h
[modify] https://crrev.com/d982acf0da90234b529418522191095473e016a2/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc
[modify] https://crrev.com/d982acf0da90234b529418522191095473e016a2/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h
[modify] https://crrev.com/d982acf0da90234b529418522191095473e016a2/chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc
[modify] https://crrev.com/d982acf0da90234b529418522191095473e016a2/chrome/browser/ui/website_settings/website_settings_infobar_delegate.h

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51b431e3ba740400f6923a902a694221d4269615

commit 51b431e3ba740400f6923a902a694221d4269615
Author: estade <estade@chromium.org>
Date: Fri Sep 30 19:31:23 2016

Remove a bunch of pre-MD toolbar code and assets.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2374803002
Cr-Commit-Position: refs/heads/master@{#422180}

[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_reload_disabled.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_reload_hover.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_reload_normal.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_reload_pressed.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_stop_disabled.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_stop_hover.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_stop_normal.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_stop_pressed.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_tools_bar.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_tools_bar_high.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_tools_bar_low.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_tools_bar_medium.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_tools_hover.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_tools_normal.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_100_percent/common/browser_tools_pressed.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_reload_disabled.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_reload_hover.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_reload_normal.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_reload_pressed.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_stop_disabled.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_stop_hover.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_stop_normal.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_stop_pressed.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_tools_bar.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_tools_bar_high.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_tools_bar_low.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_tools_bar_medium.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_tools_hover.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_tools_normal.png
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/app/theme/default_200_percent/common/browser_tools_pressed.png
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/themes/browser_theme_pack.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/themes/browser_theme_pack.h
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/themes/theme_properties.h
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/cocoa/image_button_cell_unittest.mm
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.h
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/cocoa/toolbar/app_toolbar_button_cell.h
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/cocoa/toolbar/app_toolbar_button_cell.mm
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/toolbar/app_menu_icon_controller.h
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/browser/ui/toolbar/app_menu_icon_painter.cc
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/browser/ui/toolbar/app_menu_icon_painter.h
[delete] https://crrev.com/230e7a29d98a166df6de4b9518e631dff553a739/chrome/browser/ui/toolbar/app_menu_icon_painter_unittest.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/app_menu_button.h
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/back_button.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/reload_button.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/chrome/test/BUILD.gn
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/51b431e3ba740400f6923a902a694221d4269615/ui/views/controls/button/label_button.h

Labels: Proj-MaterialDesign-NativeUI
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1

commit 85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1
Author: estade <estade@chromium.org>
Date: Mon Oct 03 20:43:56 2016

Remove IsModeMaterial checks in ui/views/

BUG= 648281 

Review-Url: https://codereview.chromium.org/2389453002
Cr-Commit-Position: refs/heads/master@{#422518}

[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/chrome/browser/ui/views/subtle_notification_view.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/button/custom_button_unittest.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/button/md_text_button.h
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/button/vector_icon_button.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/link.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/link.h
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/controls/menu/menu_item_view.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/corewm/tooltip_aura.cc
[modify] https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1/ui/views/examples/vector_example.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f02568a216b975130849079183cc0f7173d6b832

commit f02568a216b975130849079183cc0f7173d6b832
Author: estade <estade@chromium.org>
Date: Tue Oct 04 01:58:16 2016

Clean up NativeTheme (particularly CommonTheme).

- discard pre-MD colors
- consolidate color logic that didn't change from pre-MD to MD
- remove some colors that either aren't used, or are only used in one
  place, or otherwise don't make sense to be part of NativeTheme

BUG= 648281 

Review-Url: https://codereview.chromium.org/2382443007
Cr-Commit-Position: refs/heads/master@{#422665}

[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/profile_chooser_constants.h
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/views/toolbar/app_menu.h
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/native_theme/common_theme.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/native_theme/native_theme.h
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/native_theme/native_theme_dark_aura.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/native_theme/native_theme_mac.mm
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/native_theme/native_theme_win.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/views/controls/button/label_button_unittest.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/views/controls/label.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/views/controls/menu/menu_delegate.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/views/controls/menu/menu_delegate.h
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/views/controls/menu/menu_item_view.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/views/style/platform_style.cc
[modify] https://crrev.com/f02568a216b975130849079183cc0f7173d6b832/ui/views/style/platform_style_mac.mm

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939f99090ea8725dd30ad88825933ee2ca47d0b0

commit 939f99090ea8725dd30ad88825933ee2ca47d0b0
Author: estade <estade@chromium.org>
Date: Wed Oct 05 17:48:28 2016

Remove some more desktop infobar PNGs.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2382563003
Cr-Commit-Position: refs/heads/master@{#423212}

[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_cookie.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_midi.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_plugin_crashed.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_plugin_install.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_restore_session.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/legacy/infobar_desktop_notifications.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/legacy/infobar_geolocation.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_cookie.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_midi.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_plugin_crashed.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_plugin_install.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_restore_session.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/legacy/infobar_desktop_notifications.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/legacy/infobar_geolocation.png
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/android/resource_id.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/download/download_permission_request.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/download/download_permission_request.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/download/download_request_infobar_delegate_android.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/media/midi_permission_infobar_delegate_android.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/pepper_broker_infobar_delegate.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/pepper_broker_infobar_delegate.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/permissions/permission_request_impl.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/plugins/plugin_infobar_delegates.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/plugins/plugin_infobar_delegates.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/collected_cookies_infobar_delegate.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/collected_cookies_infobar_delegate.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/hung_plugin_tab_helper.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/startup/default_browser_infobar_delegate.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/startup/default_browser_infobar_delegate.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/startup/session_crashed_infobar_delegate.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/startup/session_crashed_infobar_delegate.h

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c

commit 7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Oct 07 08:09:37 2016

Revert of Delete pre-MD code from OmniboxResultView (patchset #9 id:160001 of https://codereview.chromium.org/2365263006/ )

Reason for revert:
The downstream Chrome on iOS code has never been ported to the new vector icon and still use MD raster icon. This CL breaks Chrome on iOS downstream (due to missing resources and removal of GetIcon() method).

Original issue's description:
> Delete pre-MD code from OmniboxResultView
>
> BUG= 648281 
>
> Committed: https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707
> Cr-Commit-Position: refs/heads/master@{#423690}

TBR=pkasting@chromium.org,blundell@chromium.org,sky@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 648281 

Review-Url: https://codereview.chromium.org/2399333002
Cr-Commit-Position: refs/heads/master@{#423819}

[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/chrome/browser/chromeos/options/network_config_view.h
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/neterror/resources/neterror.css
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/components_scaled_resources.grd
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/location_bar_http.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/omnibox_calculator.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/omnibox_http.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/omnibox_https_invalid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/omnibox_https_valid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/omnibox_search.png
[rename] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_100_percent/omnibox/omnibox_search_button_loupe.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/location_bar_http.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/omnibox_http.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/omnibox_https_invalid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/omnibox_https_valid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/omnibox_search.png
[rename] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_200_percent/omnibox/omnibox_search_button_loupe.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/default_300_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/resources/omnibox_scaled_resources.grdp
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/toolbar/test_toolbar_model.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/toolbar/test_toolbar_model.h
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/toolbar/toolbar_model.h
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c/components/toolbar/toolbar_model_impl.h

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 7 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d63eff699899a0cbab355472582939c2a1d3e89a

commit d63eff699899a0cbab355472582939c2a1d3e89a
Author: Jackie Quinn <jyquinn@chromium.org>
Date: Fri Oct 07 22:40:27 2016

Revert of Delete pre-MD code from OmniboxResultView (patchset #9 id:160001 of https://codereview.chromium.org/2365263006/ )

Reason for revert:
The downstream Chrome on iOS code has never been ported to the new vector icon and still use MD raster icon. This CL breaks Chrome on iOS downstream (due to missing resources and removal of GetIcon() method).

Original issue's description:
> Delete pre-MD code from OmniboxResultView
>
> BUG= 648281 
>
> Committed: https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707
> Cr-Commit-Position: refs/heads/master@{#423690}

TBR=pkasting@chromium.org,blundell@chromium.org,sky@chromium.org,estade@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 648281 

Review-Url: https://codereview.chromium.org/2399333002
Cr-Commit-Position: refs/heads/master@{#423819}
(cherry picked from commit 7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c)

Review URL: https://codereview.chromium.org/2401213002 .

Cr-Commit-Position: refs/branch-heads/2883@{#6}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/chromeos/options/network_config_view.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/neterror/resources/neterror.css
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/components_scaled_resources.grd
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/location_bar_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_calculator.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_search.png
[rename] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_search_button_loupe.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/location_bar_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_search.png
[rename] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_search_button_loupe.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/omnibox_scaled_resources.grdp
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/test_toolbar_model.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/test_toolbar_model.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/toolbar_model.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/toolbar_model_impl.h

Project Member

Comment 22 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bef2e8794b011307990a194f09937839200bd23

commit 9bef2e8794b011307990a194f09937839200bd23
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Oct 13 18:09:26 2016

Upstream utilities to select icon to display in omnibox.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2417693003
Cr-Commit-Position: refs/heads/master@{#425089}

[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/controlled_setting_mandatory.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_history.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_history_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_http.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_http_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_https_invalid.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_https_valid.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_search.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_search_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_star.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_100_percent/omnibox_star_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/controlled_setting_mandatory.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_history.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_history_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_http.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_http_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_https_invalid.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_https_valid.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_search.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_search_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_star.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_200_percent/omnibox_star_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/controlled_setting_mandatory.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_history.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_history_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_http.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_http_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_https_invalid.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_https_valid.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_search.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_search_incognito.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_star.png
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/default_300_percent/omnibox_star_incognito.png
[modify] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/app/theme/ios_theme_resources.grd
[modify] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/browser/BUILD.gn
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/browser/ui/omnibox/BUILD.gn
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/browser/ui/omnibox/omnibox_util.cc
[add] https://crrev.com/9bef2e8794b011307990a194f09937839200bd23/ios/chrome/browser/ui/omnibox/omnibox_util.h

Project Member

Comment 23 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/cb05dac8d21a5a965cac125b5d56a4712587c5e5

commit cb05dac8d21a5a965cac125b5d56a4712587c5e5
Author: sdefresne <sdefresne@google.com>
Date: Fri Oct 14 20:54:59 2016

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3

commit 7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3
Author: sdefresne <sdefresne@chromium.org>
Date: Mon Oct 17 21:37:07 2016

Reland of Delete pre-MD code from OmniboxResultView

Reland of https://codereview.chromium.org/2365263006/ after the
downstream iOS code was fixed to not uses the deleted resources
or methods.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2422193002
Cr-Commit-Position: refs/heads/master@{#425783}

[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/chrome/browser/chromeos/options/network_config_view.h
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/neterror/resources/neterror.css
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/resources/components_scaled_resources.grd
[rename] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/resources/default_100_percent/neterror/search_glass.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/controlled_setting_mandatory.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/ios/omnibox_history.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/ios/omnibox_history_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/ios/omnibox_http.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/ios/omnibox_http_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/ios/omnibox_https_invalid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/ios/omnibox_https_valid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/ios/omnibox_search.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/ios/omnibox_search_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/location_bar_http.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/omnibox_calculator.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/omnibox_extension_app.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/omnibox_http.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/omnibox_https_invalid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/omnibox_https_valid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_100_percent/omnibox/omnibox_search.png
[rename] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/resources/default_200_percent/neterror/search_glass.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/controlled_setting_mandatory.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/ios/omnibox_history.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/ios/omnibox_history_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/ios/omnibox_http.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/ios/omnibox_http_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/ios/omnibox_https_invalid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/ios/omnibox_https_valid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/ios/omnibox_search.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/ios/omnibox_search_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/location_bar_http.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/omnibox_extension_app.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/omnibox_http.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/omnibox_https_invalid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/omnibox_https_valid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_200_percent/omnibox/omnibox_search.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/controlled_setting_mandatory.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/ios/omnibox_history.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/ios/omnibox_history_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/ios/omnibox_http.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/ios/omnibox_http_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/ios/omnibox_https_invalid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/ios/omnibox_https_valid.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/ios/omnibox_search.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/ios/omnibox_search_incognito.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/default_300_percent/omnibox/omnibox_extension_app.png
[delete] https://crrev.com/2a02c331bbbe9211edaf48cff8938b266153d56f/components/resources/omnibox_scaled_resources.grdp
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/toolbar/test_toolbar_model.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/toolbar/test_toolbar_model.h
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/toolbar/toolbar_model.h
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3/components/toolbar/toolbar_model_impl.h

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c65c5751b770c0f79f60e6eee8ccabe380804146

commit c65c5751b770c0f79f60e6eee8ccabe380804146
Author: estade <estade@chromium.org>
Date: Mon Oct 24 14:03:02 2016

Remove some more !IsModeMaterial code.

Remove last references to non-custom IDR_THEME_TOOLBAR.
Remove some unused SHADE images.
Remove DropdownBarView, which is nothing but a bunch of dead code.

BUG= 648281 
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2441863002
Cr-Commit-Position: refs/heads/master@{#427062}

[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/ash/browser_window_header_shade_left.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/ash/browser_window_header_shade_right.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/ash/browser_window_header_shade_top.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/ash/browser_window_header_shade_top_left.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/ash/browser_window_header_shade_top_right.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/ash/theme_default_active.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/toolbar_shade_left.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/toolbar_shade_right.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/common/toolbar_shade_top.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_100_percent/theme_toolbar_default.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/ash/browser_window_header_shade_left.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/ash/browser_window_header_shade_right.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/ash/browser_window_header_shade_top.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/ash/browser_window_header_shade_top_left.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/ash/browser_window_header_shade_top_right.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/ash/theme_default_active.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/toolbar_shade_left.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/toolbar_shade_right.png
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/app/theme/default_200_percent/common/toolbar_shade_top.png
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/dropdown_bar_host.cc
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/browser/ui/views/dropdown_bar_view.cc
[delete] https://crrev.com/dba76ba326d06727d1e62319189e84cff00c2894/chrome/browser/ui/views/dropdown_bar_view.h
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/find_bar_view.h
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/frame/browser_header_painter_ash.h
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/c65c5751b770c0f79f60e6eee8ccabe380804146/chrome/browser/ui/views/tabs/tab.h

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939f99090ea8725dd30ad88825933ee2ca47d0b0

commit 939f99090ea8725dd30ad88825933ee2ca47d0b0
Author: estade <estade@chromium.org>
Date: Wed Oct 05 17:48:28 2016

Remove some more desktop infobar PNGs.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2382563003
Cr-Commit-Position: refs/heads/master@{#423212}

[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_cookie.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_midi.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_plugin_crashed.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_plugin_install.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/common/infobar_restore_session.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/legacy/infobar_desktop_notifications.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_100_percent/legacy/infobar_geolocation.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_cookie.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_midi.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_plugin_crashed.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_plugin_install.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/common/infobar_restore_session.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/legacy/infobar_desktop_notifications.png
[delete] https://crrev.com/a48062198faa6b7d37ad64e817aa58b33951e69c/chrome/app/theme/default_200_percent/legacy/infobar_geolocation.png
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/android/resource_id.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/download/download_permission_request.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/download/download_permission_request.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/download/download_request_infobar_delegate_android.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/media/midi_permission_infobar_delegate_android.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/pepper_broker_infobar_delegate.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/pepper_broker_infobar_delegate.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/permissions/permission_request_impl.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/plugins/plugin_infobar_delegates.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/plugins/plugin_infobar_delegates.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/collected_cookies_infobar_delegate.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/collected_cookies_infobar_delegate.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/hung_plugin_tab_helper.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/startup/default_browser_infobar_delegate.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/startup/default_browser_infobar_delegate.h
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/startup/session_crashed_infobar_delegate.cc
[modify] https://crrev.com/939f99090ea8725dd30ad88825933ee2ca47d0b0/chrome/browser/ui/startup/session_crashed_infobar_delegate.h

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/255d6d6d2bbc0e8715ad0985d239897f80a4b707

commit 255d6d6d2bbc0e8715ad0985d239897f80a4b707
Author: estade <estade@chromium.org>
Date: Thu Oct 06 21:34:59 2016

Delete pre-MD code from OmniboxResultView

BUG= 648281 

Review-Url: https://codereview.chromium.org/2365263006
Cr-Commit-Position: refs/heads/master@{#423690}

[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/chrome/browser/chromeos/options/network_config_view.h
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/neterror/resources/neterror.css
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/resources/components_scaled_resources.grd
[rename] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/resources/default_100_percent/neterror/search_glass.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/controlled_setting_mandatory.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/ios/omnibox_history.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/ios/omnibox_history_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/ios/omnibox_http.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/ios/omnibox_http_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/ios/omnibox_https_invalid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/ios/omnibox_https_valid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/ios/omnibox_search.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/ios/omnibox_search_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/location_bar_http.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/omnibox_calculator.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/omnibox_extension_app.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/omnibox_http.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/omnibox_https_invalid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/omnibox_https_valid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_100_percent/omnibox/omnibox_search.png
[rename] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/resources/default_200_percent/neterror/search_glass.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/controlled_setting_mandatory.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/ios/omnibox_history.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/ios/omnibox_history_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/ios/omnibox_http.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/ios/omnibox_http_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/ios/omnibox_https_invalid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/ios/omnibox_https_valid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/ios/omnibox_search.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/ios/omnibox_search_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/location_bar_http.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/omnibox_extension_app.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/omnibox_http.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/omnibox_https_invalid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/omnibox_https_valid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_200_percent/omnibox/omnibox_search.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/controlled_setting_mandatory.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/ios/omnibox_history.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/ios/omnibox_history_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/ios/omnibox_http.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/ios/omnibox_http_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/ios/omnibox_https_invalid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/ios/omnibox_https_valid.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/ios/omnibox_search.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/ios/omnibox_search_incognito.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/default_300_percent/omnibox/omnibox_extension_app.png
[delete] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/components/resources/omnibox_scaled_resources.grdp
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/toolbar/test_toolbar_model.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/toolbar/test_toolbar_model.h
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/toolbar/toolbar_model.h
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707/components/toolbar/toolbar_model_impl.h

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d63eff699899a0cbab355472582939c2a1d3e89a

commit d63eff699899a0cbab355472582939c2a1d3e89a
Author: Jackie Quinn <jyquinn@chromium.org>
Date: Fri Oct 07 22:40:27 2016

Revert of Delete pre-MD code from OmniboxResultView (patchset #9 id:160001 of https://codereview.chromium.org/2365263006/ )

Reason for revert:
The downstream Chrome on iOS code has never been ported to the new vector icon and still use MD raster icon. This CL breaks Chrome on iOS downstream (due to missing resources and removal of GetIcon() method).

Original issue's description:
> Delete pre-MD code from OmniboxResultView
>
> BUG= 648281 
>
> Committed: https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707
> Cr-Commit-Position: refs/heads/master@{#423690}

TBR=pkasting@chromium.org,blundell@chromium.org,sky@chromium.org,estade@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 648281 

Review-Url: https://codereview.chromium.org/2399333002
Cr-Commit-Position: refs/heads/master@{#423819}
(cherry picked from commit 7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c)

Review URL: https://codereview.chromium.org/2401213002 .

Cr-Commit-Position: refs/branch-heads/2883@{#6}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/chromeos/options/network_config_view.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/neterror/resources/neterror.css
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/components_scaled_resources.grd
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/location_bar_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_calculator.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_search.png
[rename] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_100_percent/omnibox/omnibox_search_button_loupe.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/location_bar_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_search.png
[rename] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_200_percent/omnibox/omnibox_search_button_loupe.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/controlled_setting_mandatory.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_history.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_history_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_http.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_http_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_https_invalid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_https_valid.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_search.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/ios/omnibox_search_incognito.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/default_300_percent/omnibox/omnibox_extension_app.png
[add] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/resources/omnibox_scaled_resources.grdp
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/test_toolbar_model.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/test_toolbar_model.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/toolbar_model.h
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/d63eff699899a0cbab355472582939c2a1d3e89a/components/toolbar/toolbar_model_impl.h

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d5fe31add4e90541a5164216f9a16b6cf0c7086

commit 3d5fe31add4e90541a5164216f9a16b6cf0c7086
Author: estade <estade@chromium.org>
Date: Sat Oct 29 05:45:07 2016

Some more pre-material cleanups

BUG= 648281 

Review-Url: https://codereview.chromium.org/2444923003
Cr-Commit-Position: refs/heads/master@{#428603}

[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/cocoa/infobars/infobar_controller.mm
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/infobar_container_delegate.cc
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/infobar_container_delegate.h
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/layout_constants.h
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086/ui/base/material_design/material_design_controller.h

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a

commit b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a
Author: kjellander <kjellander@chromium.org>
Date: Tue Nov 01 10:17:29 2016

Revert of Some more pre-material cleanups (patchset #4 id:60001 of https://codereview.chromium.org/2444923003/ )

Reason for revert:
Speculative revert since being the only commit in the first of a long series of flaky failures in interactive_ui_tests on Mac10.10 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8428

Original issue's description:
> Some more pre-material cleanups
>
> BUG= 648281 
>
> Committed: https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086
> Cr-Commit-Position: refs/heads/master@{#428603}

TBR=groby@chromium.org,pkasting@chromium.org,sadrul@chromium.org,estade@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 648281 

Review-Url: https://codereview.chromium.org/2464063002
Cr-Commit-Position: refs/heads/master@{#428969}

[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/cocoa/infobars/infobar_controller.mm
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/infobar_container_delegate.cc
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/infobar_container_delegate.h
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/layout_constants.h
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a/ui/base/material_design/material_design_controller.h

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f50a032e6a78c038902b0d83fa8e79ad2274ed87

commit f50a032e6a78c038902b0d83fa8e79ad2274ed87
Author: kjellander <kjellander@chromium.org>
Date: Tue Nov 01 13:31:09 2016

Reland of Some more pre-material cleanups (patchset #1 id:1 of https://codereview.chromium.org/2464063002/ )

Reason for revert:
Relanding as newer builds experienced the same flakiness: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8533

Original issue's description:
> Revert of Some more pre-material cleanups (patchset #4 id:60001 of https://codereview.chromium.org/2444923003/ )
>
> Reason for revert:
> Speculative revert since being the only commit in the first of a long series of flaky failures in interactive_ui_tests on Mac10.10 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8428
>
> Original issue's description:
> > Some more pre-material cleanups
> >
> > BUG= 648281 
> >
> > Committed: https://crrev.com/3d5fe31add4e90541a5164216f9a16b6cf0c7086
> > Cr-Commit-Position: refs/heads/master@{#428603}
>
> TBR=groby@chromium.org,pkasting@chromium.org,sadrul@chromium.org,estade@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 648281 
>
> Committed: https://crrev.com/b828ed6e000cbe757ca8f1aa2da2bfa3c42b960a
> Cr-Commit-Position: refs/heads/master@{#428969}

TBR=groby@chromium.org,pkasting@chromium.org,sadrul@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 648281 

Review-Url: https://codereview.chromium.org/2466343002
Cr-Commit-Position: refs/heads/master@{#428990}

[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/cocoa/infobars/infobar_controller.mm
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/infobar_container_delegate.cc
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/infobar_container_delegate.h
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/layout_constants.h
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/f50a032e6a78c038902b0d83fa8e79ad2274ed87/ui/base/material_design/material_design_controller.h

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8867dff1a47afb775c2c83cf44b26e16715e2b9

commit b8867dff1a47afb775c2c83cf44b26e16715e2b9
Author: estade <estade@chromium.org>
Date: Thu Nov 03 17:33:33 2016

Remove more pre-MD odds and ends.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2447553003
Cr-Commit-Position: refs/heads/master@{#429631}

[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/browser/extensions/extension_action.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/browser/themes/browser_theme_pack.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/browser/themes/theme_service_browsertest.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/browser/ui/views/location_bar/page_action_image_view.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/common/chrome_constants.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/common/chrome_constants.h
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/common/extensions/api/extension_action/action_info.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/extensions/browser/extension_icon_placeholder.cc
[modify] https://crrev.com/b8867dff1a47afb775c2c83cf44b26e16715e2b9/extensions/common/constants.h

Comment 34 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12e0bd16fed2dc48573a525c704ec4c966691f09

commit 12e0bd16fed2dc48573a525c704ec4c966691f09
Author: estade <estade@chromium.org>
Date: Thu Nov 10 20:45:56 2016

Remove MaterialDesignController::IsModeMaterial

BUG= 648281 

Review-Url: https://codereview.chromium.org/2473863004
Cr-Commit-Position: refs/heads/master@{#431343}

[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/chrome/browser/themes/theme_service_mac.mm
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/chrome/browser/themes/theme_service_unittest.cc
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/chrome/browser/ui/views/frame/browser_frame.cc
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/chrome/browser/ui/views/infobars/infobar_background.cc
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/components/infobars/core/infobar.cc
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/components/infobars/core/infobar.h
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/ui/base/material_design/material_design_controller.cc
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/ui/base/material_design/material_design_controller.h
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/ui/base/material_design/material_design_controller_unittest.cc
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/ui/native_theme/BUILD.gn
[delete] https://crrev.com/d8b550c725757a369fd04dee74f5309ab5637569/ui/native_theme/native_theme_dark_win.cc
[delete] https://crrev.com/d8b550c725757a369fd04dee74f5309ab5637569/ui/native_theme/native_theme_dark_win.h
[modify] https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09/ui/native_theme/native_theme_win.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a02cc8f81da40e6829d1bf1c484cf05299ba9e0

commit 6a02cc8f81da40e6829d1bf1c484cf05299ba9e0
Author: estade <estade@chromium.org>
Date: Thu Dec 15 01:09:55 2016

Remove unused pre-MD find bar assets from mac build.

These are not needed because the pre-MD find bar code was removed.

BUG= 648281 ,522168
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2571143002
Cr-Commit-Position: refs/heads/master@{#438692}

[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_bottom.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_bottom_left.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_bottom_right.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_center.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_left.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_right.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_top.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_top_left.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_100_percent/common/textfield_top_right.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_bottom.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_bottom_left.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_bottom_right.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_center.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_left.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_right.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_top.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_top_left.png
[delete] https://crrev.com/83fa786d1e7ee06d2771b7026da0041c9f68c702/chrome/app/theme/default_200_percent/common/textfield_top_right.png
[modify] https://crrev.com/6a02cc8f81da40e6829d1bf1c484cf05299ba9e0/chrome/app/theme/theme_resources.grd

Status: Fixed (was: Started)
No known remaining cleanups.
Project Member

Comment 39 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff3e5ef957ccb585c7d73a0b011bdd432f5e57e0

commit ff3e5ef957ccb585c7d73a0b011bdd432f5e57e0
Author: estade <estade@chromium.org>
Date: Thu Feb 02 23:42:47 2017

Slightly simplify location bar bg/border painting.

I also renamed some stuff to improve clarity (I couldn't initially
determine why GetBorderColor didn't return the same thing as
kBorderColor). This shouldn't cause any behavioral change. The unneeded
complexity here was probably left over from pre-MD codepaths.

BUG= 648281 

Review-Url: https://codereview.chromium.org/2673503002
Cr-Commit-Position: refs/heads/master@{#447881}

[modify] https://crrev.com/ff3e5ef957ccb585c7d73a0b011bdd432f5e57e0/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/ff3e5ef957ccb585c7d73a0b011bdd432f5e57e0/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/ff3e5ef957ccb585c7d73a0b011bdd432f5e57e0/chrome/browser/ui/views/location_bar/location_bar_view.h

Sign in to add a comment