LogDog Server using HTTP credentials for gRPC. |
||
Issue description
A change in either the gRPC library or the luci-go auth package has broken previously-working code. This code used an HTTP client transport to add OAuth2 tokens to gRPC BigTable requests. Now, we're getting failures:
Connecting to BigTable.
Failed to create BigTable instance. :: {"error":"dialing: unsupported HTTP client specified"}
This error is punted by the gRPC client library when an HTTP client is provided to the gRPC dialer. This needs to be fixed by applying gRPC credentials directly instead. In the meantime, live log streaming is broken.
,
Sep 19 2016
Fix seems to be working on live.
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/e6e5673e8aa0a8e930ac3fcd693e671a6f8a71c1 commit e6e5673e8aa0a8e930ac3fcd693e671a6f8a71c1 Author: dnj <dnj@chromium.org> Date: Mon Sep 19 16:31:12 2016 LogDog: Use gRPC credential directly. Previously, LogDog used an HTTP client with a token source to connect to BigTable, which uses gRPC. This broke at some point and now returns an error. Replace this with the proper direct gRPC credentials. TBR=vadimsh@chromium.org BUG= chromium:648278 - Deployed on production system, no longer encounters HTTP error and can successfully pull from BigTable. Review-Url: https://codereview.chromium.org/2350793002 [modify] https://crrev.com/e6e5673e8aa0a8e930ac3fcd693e671a6f8a71c1/logdog/appengine/coordinator/service.go |
||
►
Sign in to add a comment |
||
Comment 1 by d...@chromium.org
, Sep 19 2016