New issue
Advanced search Search tips

Issue 648254 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Plugin power saver tests broken in official builds after https://codereview.chromium.org/2342893003

Project Member Reported by thakis@chromium.org, Sep 19 2016 
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/6147

PluginPowerSaverBrowserTest.BackgroundTabTinyPlugins (run #1):
[ RUN      ] PluginPowerSaverBrowserTest.BackgroundTabTinyPlugins
[3440:4064:0916/144328:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart
../../chrome/browser/plugins/plugin_power_saver_browsertest.cc(356): error: Value of: PluginLoaded(GetActiveWebContents(), element_id)
  Actual: true
Expected: false
[3440:4064:0916/144329:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: dom_distiller::mojom::DistillabilityService
[3440:4064:0916/144329:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: dom_distiller::mojom::DistillabilityService
[  FAILED  ] PluginPowerSaverBrowserTest.BackgroundTabTinyPlugins, where TypeParam =  and GetParam() =  (568 ms)


PluginPowerSaverBrowserTest.BlockTinyPlugins (run #1):
[ RUN      ] PluginPowerSaverBrowserTest.BlockTinyPlugins
[3900:972:0916/144328:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart
[3900:972:0916/144328:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: dom_distiller::mojom::DistillabilityService
[3900:972:0916/144328:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: dom_distiller::mojom::DistillabilityService
../../chrome/browser/plugins/plugin_power_saver_browsertest.cc(356): error: Value of: PluginLoaded(GetActiveWebContents(), element_id)
  Actual: true
Expected: false

Comment 1 by thakis@chromium.org, Sep 19 2016 

Oh one more:

PluginPowerSaverBrowserTest.ExpandingTinyPlugins (run #1):
[ RUN      ] PluginPowerSaverBrowserTest.ExpandingTinyPlugins
[4128:5220:0916/144311:WARNING:chrome_browser_main_win.cc(419)] Command line too long for RegisterApplicationRestart
[4128:5220:0916/144311:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: dom_distiller::mojom::DistillabilityService
[4128:5220:0916/144311:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: dom_distiller::mojom::DistillabilityService
../../chrome/browser/plugins/plugin_power_saver_browsertest.cc(356): error: Value of: PluginLoaded(GetActiveWebContents(), element_id)
  Actual: true
Expected: false


The linked-to bot uses clang, but it also does official builds. I bet this repros in non-clang official builds as well.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6aa0954dca4bc6eba852b15be7187707fbe56ed

commit b6aa0954dca4bc6eba852b15be7187707fbe56ed
Author: tommycli <tommycli@chromium.org>
Date: Tue Sep 20 00:42:22 2016

Plugin Power Saver: Fix browsertest in official builds.

Official builds don't use the Field Trial config JSON files, so this
CL manually adds the feature flags in the setup portion of the test.

BUG= 648254 

Review-Url: https://codereview.chromium.org/2350773003
Cr-Commit-Position: refs/heads/master@{#419611}

[modify] https://crrev.com/b6aa0954dca4bc6eba852b15be7187707fbe56ed/chrome/browser/plugins/plugin_power_saver_browsertest.cc

Comment 3 by thakis@chromium.org, Sep 21 2016

Status: Fixed (was: Untriaged)
Thanks!
►

Sign in to add a comment