New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648252 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 644109
issue 648253



Sign in to add a comment

Extend UserClassifier to actually support classification of users.

Project Member Reported by jkrcal@chromium.org, Sep 19 2016

Issue description

This includes adding support to get up-to-date usage metrics in real-time (not only when one of the tracked event happens).

Also add a snippets-internals section to debug the classification values.
 

Comment 1 by fi...@chromium.org, Sep 19 2016

Labels: zine-client-v1 M-55 zine-triaged

Comment 2 by jkrcal@chromium.org, Sep 20 2016

Labels: zine-16-09-19
Mostly done, should land today or tomorrow.

Comment 3 by jkrcal@chromium.org, Sep 20 2016

Blocking: 648253
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8048f8d8d5153a0e530529e883c78582853d0b15

commit 8048f8d8d5153a0e530529e883c78582853d0b15
Author: jkrcal <jkrcal@chromium.org>
Date: Wed Sep 21 10:25:24 2016

Extending the UserClassifier to actually support classification.

This CL adds actual classification to the UserClassifier.
So far, only simple classification thresholds are implemented.

The CL also includes a new snippets-internals section and a bit of
refactoring.

In a follow-up CLs, all the parameters will become configurable by
variations.

BUG= 648252 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2346263002
Cr-Commit-Position: refs/heads/master@{#420022}

[modify] https://crrev.com/8048f8d8d5153a0e530529e883c78582853d0b15/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/8048f8d8d5153a0e530529e883c78582853d0b15/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/8048f8d8d5153a0e530529e883c78582853d0b15/chrome/browser/resources/snippets_internals.js
[modify] https://crrev.com/8048f8d8d5153a0e530529e883c78582853d0b15/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/8048f8d8d5153a0e530529e883c78582853d0b15/chrome/browser/ui/webui/snippets_internals_message_handler.h
[modify] https://crrev.com/8048f8d8d5153a0e530529e883c78582853d0b15/components/ntp_snippets/user_classifier.cc
[modify] https://crrev.com/8048f8d8d5153a0e530529e883c78582853d0b15/components/ntp_snippets/user_classifier.h

Status: Fixed (was: Started)

Sign in to add a comment