"fetch-request-css-base-url.html" is flaky |
|||
Issue descriptionOn Win7 (Dbg), the http/tests/serviceworker/fetch-request-css-base-url.html has been flaking recently. See, for example, https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/7394 Flakiness Dashboard link: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fserviceworker%2Ffetch-request-css-base-url.html The actual failure doesn't appear to be a result of any failing assertion, but rather that the iframe has only just been created when the assertions are run, but the |frame| variable is undefined, and so the script throws an exception. I suspect that the "frame.remove" line can just be removed, since the change in https://chromium.googlesource.com/chromium/src/+/025c7a5cefe328486bcd4309c2b945987a09374c ensures that frames created are removed in teardown anyway, and it is just a timing issue that occasionally the message is posted and the assertions are run before the frame variable is assigned. Marking the test as flaky on Win7, but I'll submit the change for review as well.
,
Sep 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4c7dfe047c13a76225f03badacd2e5a46f22982 commit b4c7dfe047c13a76225f03badacd2e5a46f22982 Author: iclelland <iclelland@chromium.org> Date: Tue Sep 20 13:15:33 2016 Remove explict frame removal from fetch-request-css-base-url.html test This was causing occasional test failures on the WebKit Win7 Dbg builder, as the frame variable was sometimes not set when the message from the service worker was being handled. Since the frames created by with_iframe() are auto-removed now, the explicit removal isn't necessary anymore. R=falken@chromium.org BUG= 648247 Review-Url: https://codereview.chromium.org/2349283002 Cr-Commit-Position: refs/heads/master@{#419736} [modify] https://crrev.com/b4c7dfe047c13a76225f03badacd2e5a46f22982/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/b4c7dfe047c13a76225f03badacd2e5a46f22982/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-css-base-url.html
,
Oct 14 2016
,
Oct 17 2016
Flakiness dashboard shows this is fixed after comment #2. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 19 2016