iOS WebUI doesn't support gzipped resources. |
|||||||||
Issue descriptionSteps to reproduce: - Navigate to chrome://signin-internals or chrome://gcm-internals. Observed behavior: Chrome crashes. Expected behavior: The page should be displayed correctly. Additional comments: This was introduced by https://codereview.chromium.org/2036633003/ and we don't seem to have proper tests in place on iOS (especially upstream) to verify this. Removing the 'compress="gzip"' (in components/resources/signin_resources.grdp for example) fixes the crash, and looking at the code, the encoding is assumed to be UTF-8 without any other transformation to do.
,
Nov 2 2016
No update, and I don't have any plans to work on this in the immediate future. Feel free to pick it up if it will help your workflow.
,
Nov 2 2016
,
Nov 2 2016
Kurt, any chance you have bandwidth to work on this?
,
Nov 2 2016
+pkl for escalation
,
Nov 3 2016
iOS doesn't currently support gzipped WebUI resources, so the gzipping of shared resources in signin-internals and other webui pages makes these pages inaccessible on iOS. We use URLFetcher to retrieve resources, and it's unclear with the current implementation what the best way to determine which resources are gzipped is. dbeam@ how would you recommend proceeding for the iOS case? bzanotti@ - could you add all the webui pages you need on iOS to https://cs.chromium.org/chromium/src/ios/chrome/browser/chrome_url_constants.cc?rcl=0&l=54 This will make them show up on the chrome://chrome-urls page as webui pages we support, and be tested via EG test (downstream for now).
,
Nov 3 2016
can we make compress="gzip" do nothing on iOS?
,
Nov 3 2016
,
Nov 4 2016
Thanks for taking care of this. jyquinn@: Updating chrome_url_constants.cc right now, thanks!
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3daa089fcb74b4f03c89c7a56676e07315ffb36 commit a3daa089fcb74b4f03c89c7a56676e07315ffb36 Author: bzanotti <bzanotti@chromium.org> Date: Fri Nov 04 10:21:42 2016 Add chrome://signin-internals to chrome://chrome-urls on iOS BUG= 648241 Review-Url: https://codereview.chromium.org/2470233006 Cr-Commit-Position: refs/heads/master@{#429845} [modify] https://crrev.com/a3daa089fcb74b4f03c89c7a56676e07315ffb36/ios/chrome/browser/chrome_url_constants.cc
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f04f2c7751dc79860899643506094b68758d9de2 commit f04f2c7751dc79860899643506094b68758d9de2 Author: dbeam <dbeam@chromium.org> Date: Fri Nov 04 17:29:34 2016 Ignore compress="gzip" on iOS. It breaks lots of internals pages R=jyquinn@chromium.org BUG= 648241 Review-Url: https://codereview.chromium.org/2468423006 Cr-Commit-Position: refs/heads/master@{#429932} [modify] https://crrev.com/f04f2c7751dc79860899643506094b68758d9de2/tools/grit/grit/node/include.py
,
Nov 4 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/274c8541a630e844d168818ea938008897c2aa98 commit 274c8541a630e844d168818ea938008897c2aa98 Author: jyquinn <jyquinn@google.com> Date: Fri Nov 04 22:29:52 2016
,
Nov 5 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/3e864be07ec9e0d69334bc7e34a832cca9ff6e57 commit 3e864be07ec9e0d69334bc7e34a832cca9ff6e57 Author: rohitrao <rohitrao@google.com> Date: Sat Nov 05 01:59:53 2016
,
Nov 7 2016
This fix landed on Canary a couple of days ago.
,
Nov 7 2016
Verified that chrome://signin-internals is accessible on iPhone 6s Plus iOS Beta 10.2 on build 56.0.2912.0
,
Nov 7 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/249ff69f3a282b39c5c325e3f65ddf96979def23 commit 249ff69f3a282b39c5c325e3f65ddf96979def23 Author: jyquinn <jyquinn@google.com> Date: Mon Nov 07 23:25:37 2016 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bzanotti@chromium.org
, Nov 2 2016