Issue 648240 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	rouslan@chromium.org
Closed:	Dec 2016
Cc:	jinho.b...@samsung.com hs1217....@samsung.com ios-bugs@chromium.org
Components:	Blink>Payments
EstimatedDays:	----
NextAction:	----
OS:	Android , iOS
Pri:	2
Type:	Launch-OWP
Launch-Accessibility:	----
Launch-Exp-Leadership:	----
Launch-Leadership:	----
Launch-Legal:	----
Launch-M-Approved:	----
Launch-M-Target:	57-Stable
Launch-Privacy:	----
Launch-Security:	----
Launch-Test:	----
Launch-UI:	----
Rollout-Type:	----
Hotlist-Merge-Approved merge-merged-2924

Blocking:
issue 587995

Show other hotlists

Hotlists containing this issue:
Kzl

Add error message that can be provided as part of updateWith

Project Member Reported by jinho.b...@samsung.com, Sep 19 2016

Issue description

We have had lots of feedback that merchants need to explain errors to
customers during the payment request. For example, if a shipping address
is not acceptable then the site must be able to indicate why.

This change adds an `error` string to the `PaymentDetails`, which may
only be used as part of `updateWith`.

 - https://github.com/w3c/browser-payment-api/pull/257

Comment 1 by hs1217....@samsung.com, Sep 19 2016

i'm working in progress.(https://codereview.chromium.org/2355463002/)

Comment 2 by jinho.b...@samsung.com, Sep 20 2016

Status: Started (was: Assigned)

Hwanseung Lee already started to work on this. :)

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d40525dcb2a5b7559bdaf0eac857bf0acad369b2

commit d40525dcb2a5b7559bdaf0eac857bf0acad369b2
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Tue Sep 27 13:28:45 2016

[PaymentReqeust] Add error message in PaymentDetails. (in blink side)

When the payment request is updated using updateWith,
the PaymentDetails can contain a message in the error field
that will be displayed to the user.

https://w3c.github.io/browser-payment-api/#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/pull/257

BUG= 648240 

Review-Url: https://codereview.chromium.org/2355463002
Cr-Commit-Position: refs/heads/master@{#421189}

[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h
[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp
[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/Source/modules/payments/PaymentsValidators.h
[modify] https://crrev.com/d40525dcb2a5b7559bdaf0eac857bf0acad369b2/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Comment 4 Deleted

Comment 5 Deleted

Comment 6 by rouslan@chromium.org, Nov 18 2016

Cc: -hs1217....@gmail.com jinho.b...@samsung.com
Owner: rouslan@chromium.org

Adding UI support for this now.

Comment 7 by rouslan@chromium.org, Nov 22 2016

	Screenshot_20161122-130105.png 152 KB View Download

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48ffb7ac26489de9ac469d8e26b4fda16f547191

commit 48ffb7ac26489de9ac469d8e26b4fda16f547191
Author: rouslan <rouslan@chromium.org>
Date: Wed Nov 23 20:09:03 2016

Show custom error message in payments UI.

If the merchant specifies an error message string when rejecting a
shipping address, display this string as an error message in UI.

BUG= 648240 

Review-Url: https://codereview.chromium.org/2529443002
Cr-Commit-Position: refs/heads/master@{#434231}

[modify] https://crrev.com/48ffb7ac26489de9ac469d8e26b4fda16f547191/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/48ffb7ac26489de9ac469d8e26b4fda16f547191/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/48ffb7ac26489de9ac469d8e26b4fda16f547191/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java

Comment 9 by rouslan@chromium.org, Nov 23 2016

Components: Blink>Payments
Labels: Launch-M-Target-57-Stable

Comment 10 by rouslan@chromium.org, Nov 23 2016

Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/9fC_mQmtloc/IgEIalaCAgAJ

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87

commit 1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87
Author: rouslan <rouslan@chromium.org>
Date: Mon Nov 28 16:29:42 2016

Mark PaymentDetails.error as experimental

There has not been a request to implement and ship this feature, so it
should be marked as experimental until such request has been sent out
and consequently approved.

BUG= 648240 

Review-Url: https://codereview.chromium.org/2530713002
Cr-Commit-Position: refs/heads/master@{#434664}

[modify] https://crrev.com/1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[modify] https://crrev.com/1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 12 by rouslan@chromium.org, Nov 28 2016

Labels: Merge-Request-56

Would like to merge https://crrev.com/1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87 ("Mark PaymentDetails.error as experimental") into M-56.

Comment 13 by dimu@chromium.org, Nov 28 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M56 (branch: 2924)

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 28 2016

Labels: -merge-approved-56 merge-merged-2924

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fe37e5f414ecbb0257877d02065733ecc06df39

commit 2fe37e5f414ecbb0257877d02065733ecc06df39
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Nov 28 17:52:30 2016

[Merge M-56] Mark PaymentDetails.error as experimental

There has not been a request to implement and ship this feature, so it
should be marked as experimental until such request has been sent out
and consequently approved.

BUG= 648240 

Review-Url: https://codereview.chromium.org/2530713002
Cr-Commit-Position: refs/heads/master@{#434664}
(cherry picked from commit 1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87)

Review URL: https://codereview.chromium.org/2534993002 .

Cr-Commit-Position: refs/branch-heads/2924@{#114}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/2fe37e5f414ecbb0257877d02065733ecc06df39/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[modify] https://crrev.com/2fe37e5f414ecbb0257877d02065733ecc06df39/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/067e9cc22c9f46e5d96c3c44890063991049ab1b

commit 067e9cc22c9f46e5d96c3c44890063991049ab1b
Author: rouslan <rouslan@chromium.org>
Date: Tue Nov 29 23:08:32 2016

Throw if PaymentRequest() built with 'error' message

https://w3c.github.io/browser-payment-api/#constructor

"9. If details contains a value for error, then throw a TypeError."

BUG= 648240 

Review-Url: https://codereview.chromium.org/2532953006
Cr-Commit-Position: refs/heads/master@{#435103}

[modify] https://crrev.com/067e9cc22c9f46e5d96c3c44890063991049ab1b/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/067e9cc22c9f46e5d96c3c44890063991049ab1b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/067e9cc22c9f46e5d96c3c44890063991049ab1b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f33b96e97d5049370f337b25cda6626ad097474

commit 2f33b96e97d5049370f337b25cda6626ad097474
Author: rouslan <rouslan@chromium.org>
Date: Thu Dec 08 16:49:37 2016

Enable PaymentDetails.error by default

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/9fC_mQmtloc/IgEIalaCAgAJ

BUG= 648240 

Review-Url: https://codereview.chromium.org/2563443003
Cr-Commit-Position: refs/heads/master@{#437265}

[modify] https://crrev.com/2f33b96e97d5049370f337b25cda6626ad097474/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 17 by rouslan@chromium.org, Dec 8 2016

Status: Fixed (was: Started)

►

Issue 648240 link

Issue metadata

Add error message that can be provided as part of updateWith

Issue description

Comment 1 by hs1217....@samsung.com, Sep 19 2016

Comment 1 Deleted

Comment 2 by jinho.b...@samsung.com, Sep 20 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 27 2016

Comment 3 Deleted

Comment 4 Deleted

Comment 5 Deleted

Comment 6 by rouslan@chromium.org, Nov 18 2016

Comment 6 Deleted

Comment 7 by rouslan@chromium.org, Nov 22 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Nov 23 2016

Comment 8 Deleted

Comment 9 by rouslan@chromium.org, Nov 23 2016

Comment 9 Deleted

Comment 10 by rouslan@chromium.org, Nov 23 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Nov 28 2016

Comment 11 Deleted

Comment 12 by rouslan@chromium.org, Nov 28 2016

Comment 12 Deleted

Comment 13 by dimu@chromium.org, Nov 28 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Nov 28 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Nov 29 2016

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Dec 8 2016

Comment 16 Deleted

Comment 17 by rouslan@chromium.org, Dec 8 2016

Comment 17 Deleted

Sign in to add a comment