Require some clarifications:
1. offline bolt is not used in "Download completion" notification, but it is used in omnibox, site setting and most visited pages, do you want to change all of them, including the download completion notifications?

2. if we change the download completion notification, the notification will look different from the android's download completion notification, which is still used for some download scenarios (OMA downloads), this causes some inconsistencies.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a1ab08216d58fe00125ee6408f1850ada6e3d23

commit 2a1ab08216d58fe00125ee6408f1850ada6e3d23
Author: qinmin <qinmin@chromium.org>
Date: Tue Sep 20 00:49:48 2016

Change offline pages icon from offline_bolt to offline_pin

Change the offline page icon first
For download completion notification, still pending clarification

BUG= 648221 

Review-Url: https://codereview.chromium.org/2356643002
Cr-Commit-Position: refs/heads/master@{#419613}

[delete] https://crrev.com/7525c277abe3488dc6d5cd178df25d63bac95565/chrome/android/java/res/drawable-hdpi/offline_bolt.png
[add] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/res/drawable-hdpi/offline_pin.png
[delete] https://crrev.com/7525c277abe3488dc6d5cd178df25d63bac95565/chrome/android/java/res/drawable-mdpi/offline_bolt.png
[add] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/res/drawable-mdpi/offline_pin.png
[delete] https://crrev.com/7525c277abe3488dc6d5cd178df25d63bac95565/chrome/android/java/res/drawable-xhdpi/offline_bolt.png
[add] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/res/drawable-xhdpi/offline_pin.png
[delete] https://crrev.com/7525c277abe3488dc6d5cd178df25d63bac95565/chrome/android/java/res/drawable-xxhdpi/offline_bolt.png
[add] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/res/drawable-xxhdpi/offline_pin.png
[delete] https://crrev.com/7525c277abe3488dc6d5cd178df25d63bac95565/chrome/android/java/res/drawable-xxxhdpi/offline_bolt.png
[add] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/res/drawable-xxxhdpi/offline_pin.png
[modify] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/res/layout/most_visited_item.xml
[modify] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/res/layout/website_settings.xml
[modify] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

Hi, Rachel, the offline bolt icon in omnibox is now replaced by the offline pin icon.

However, for the Download completion notification, I am still wondering whether we need to replace it with the offline pin icon.
Here is the concern:
1.The offline pin icon doesn't match Android DownloadManager's download completion notification, which will still be displayed by OMA download as those download requires DownloadManager to encrypt the content. 

2. Currently chrome shows no download notification if app notification is disabled. If we use the old icon, then Chrome can check app notification settings and ask Android DownloadManager to display the completion notification when download completes. With the new icon, user might see two different download completion icons when enabling/disabling app notification. 

Just documenting my conversation with Jon from yesterday:
- chrome's download notifications are different from the system
- different notifications only show up when user has disabled chrome notifications

We agreed that we're comfortable with this. Thanks!

 Issue 645960  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9d324d288c1d36ae14398e367e0abfa15e97075

commit b9d324d288c1d36ae14398e367e0abfa15e97075
Author: qinmin <qinmin@chromium.org>
Date: Thu Sep 29 22:30:10 2016

Use system download completion notification if app notification is disabled.

Because all download now goes through Chrome, user will not see
notification if app notification is disabled.
This change allows us to use system DownloadManager to display the
completion notification,
in case app notification is disabled.

BUG= 648221 

Review-Url: https://codereview.chromium.org/2387453002
Cr-Commit-Position: refs/heads/master@{#421959}

[modify] https://crrev.com/b9d324d288c1d36ae14398e367e0abfa15e97075/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

on tablet, i am seeing an info icon when opening an offline page instead of the offline pine icon.


This is due to LocationBarLayout.getSecurityIconResource() only affects tablet. Is this working as intended?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94b9f47cb760b4cf81fd7825d11e4736e585c858

commit 94b9f47cb760b4cf81fd7825d11e4736e585c858
Author: qinmin <qinmin@chromium.org>
Date: Fri Sep 30 15:48:11 2016

use offline bolt icon for download completion notification

Also corrected the color of the offline bolt icon (was black, now grey)

BUG= 648221 

Review-Url: https://codereview.chromium.org/2379143002
Cr-Commit-Position: refs/heads/master@{#422122}

[modify] https://crrev.com/94b9f47cb760b4cf81fd7825d11e4736e585c858/chrome/android/java/res/drawable-hdpi/offline_pin.png
[modify] https://crrev.com/94b9f47cb760b4cf81fd7825d11e4736e585c858/chrome/android/java/res/drawable-mdpi/offline_pin.png
[modify] https://crrev.com/94b9f47cb760b4cf81fd7825d11e4736e585c858/chrome/android/java/res/drawable-xhdpi/offline_pin.png
[modify] https://crrev.com/94b9f47cb760b4cf81fd7825d11e4736e585c858/chrome/android/java/res/drawable-xxhdpi/offline_pin.png
[modify] https://crrev.com/94b9f47cb760b4cf81fd7825d11e4736e585c858/chrome/android/java/res/drawable-xxxhdpi/offline_pin.png
[modify] https://crrev.com/94b9f47cb760b4cf81fd7825d11e4736e585c858/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Hey folks!
Not sure if I should file a separate bug for this - but I've realized that the asset I provided was not properly prepared. Sorry for that. 

Please see attached "existing" for the current treatment, and attached "correct" for the requested change.

The correct icons are exported here (they're called "offline_pin_[...]): https://drive.google.com/open?id=0B6x6iYCtKinEVDB3WlVtcHUyeUU

Deleted: existing.png 542 KB

	existing.png 542 KB View Download

Deleted: correct.png 72.2 KB

	correct.png 72.2 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83365b64f51e17c80f9f99f11c342e74aa8b67c2

commit 83365b64f51e17c80f9f99f11c342e74aa8b67c2
Author: qinmin <qinmin@chromium.org>
Date: Fri Oct 14 18:40:10 2016

Fix the look of download success notification

There are some new resources files from rachelis.
And also fixing the background color on the success notification.

BUG= 648221 

Review-Url: https://codereview.chromium.org/2421693002
Cr-Commit-Position: refs/heads/master@{#425399}

[modify] https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2/chrome/android/java/res/drawable-hdpi/offline_pin.png
[modify] https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2/chrome/android/java/res/drawable-mdpi/offline_pin.png
[modify] https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2/chrome/android/java/res/drawable-xhdpi/offline_pin.png
[modify] https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2/chrome/android/java/res/drawable-xxhdpi/offline_pin.png
[modify] https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2/chrome/android/java/res/drawable-xxxhdpi/offline_pin.png
[modify] https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

need to merge the last CL into beta, all previous CLs are already in M55

Your change meets the bar and is auto-approved for M55 (branch: 2883)

[Bulk edit]

Please process this M55 merge by landing the appropriate CLs on branch 2883 by Monday at 5 PM PT, or it will miss our beta candidate build.  Ping me if you have questions / concerns.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a8a129e275e548f6fbaf5396b360e5dd4909956

commit 7a8a129e275e548f6fbaf5396b360e5dd4909956
Author: Min Qin <qinmin@chromium.org>
Date: Fri Oct 14 21:27:19 2016

Fix the look of download success notification

There are some new resources files from rachelis.
And also fixing the background color on the success notification.

TBR=dfalcantara@chromium.org
BUG= 648221 

Review-Url: https://codereview.chromium.org/2421693002
Cr-Commit-Position: refs/heads/master@{#425399}
(cherry picked from commit 83365b64f51e17c80f9f99f11c342e74aa8b67c2)

Review URL: https://codereview.chromium.org/2416283004 .

Cr-Commit-Position: refs/branch-heads/2883@{#118}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-hdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-mdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-xhdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-xxhdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-xxxhdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Verified in 55.0.2283.18 build

Thanks guys! One more thing I noticed in this vein: The icon seems to be getting an additional offline pin badge. (Image attached)

We shouldn't have the redundant badge. Can this easily be removed? (Is there a standard behavior causing this which I didn't consider?)

Deleted: offline-pin.png 672 KB

	offline-pin.png 672 KB View Download

I am not an android UI expert, but this is due to the mandatory small icon android requires.

I am not sure how to remove this though. The android notification UI changes quite a lot across different versions. The problem happens on M, but not on N and L

Thanks!

I'm not sure how this works either - though I don't see similar small icons on other notifications on the same device. Is there someone with some background who might be able to advise us?

Don't know anything about notifications on my end.  Might be worth asking Android Chatty.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a8a129e275e548f6fbaf5396b360e5dd4909956

commit 7a8a129e275e548f6fbaf5396b360e5dd4909956
Author: Min Qin <qinmin@chromium.org>
Date: Fri Oct 14 21:27:19 2016

Fix the look of download success notification

There are some new resources files from rachelis.
And also fixing the background color on the success notification.

TBR=dfalcantara@chromium.org
BUG= 648221 

Review-Url: https://codereview.chromium.org/2421693002
Cr-Commit-Position: refs/heads/master@{#425399}
(cherry picked from commit 83365b64f51e17c80f9f99f11c342e74aa8b67c2)

Review URL: https://codereview.chromium.org/2416283004 .

Cr-Commit-Position: refs/branch-heads/2883@{#118}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-hdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-mdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-xhdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-xxhdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/drawable-xxxhdpi/offline_pin.png
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/7a8a129e275e548f6fbaf5396b360e5dd4909956/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

[Automated comment] removing mislabelled merge-merged-2840

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot