Regression:Spacing issue is observed for "Search for channels" text box and CLEAR SEARCH button in "www.timewarnercable.com"
Reported by
adha...@etouch.net,
Sep 19 2016
|
|||||||||
Issue descriptionChrome Version: 55.0.2864.0 Revision 533dcff13b0b002494a3040d2f90de937a93e76d-refs/heads/master@{#419385} OS: Windows(7,8,10), Mac(10.10.5,10.11.4),Linux(14.04 LTS) TEST URL:https://www.timewarnercable.com/en/tv/channels-lineup.html# What steps will reproduce the problem? (1)Launch chrome and navigate to the above URL. (2)Observe the "Search for channels" text box and CLEAR SEARCH button.(Kindly refer the video) Actual:Spacing between "Search for channels" text box and CLEAR SEARCH button is not seen properly. Expected:Spacing between "Search for channels" text box and CLEAR SEARCH button should be seen properly. This is a Regression issue broken in M-55,will soon update bisect info. Good build:55.0.2845.0 Bad build:55.0.2846.0 Kindly review the attached screen-cast for reference.
,
Sep 19 2016
,
Sep 27 2016
Fixing the spelling error in label.
,
Sep 27 2016
glebl@: Could you please take a look this issue and update the thread accordingly. Thank you!
,
Sep 28 2016
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1833c7446ae72fa3437e73e9323c87f89b034c2f commit 1833c7446ae72fa3437e73e9323c87f89b034c2f Author: glebl <glebl@chromium.org> Date: Thu Sep 29 19:58:22 2016 Fieldset should allow whitespaces even though LayoutFlexibleBox doesn't. Restore the correct behaviour for canHaveWhitespaceChildren to return true for <fieldset> because it was changed when LayoutFieldSet was switched to use LayoutFlexibleBox. Revert some incorrectly rebaselined tests from https://crrev.com/419570. For example: it's expected to have a trailing empty LayoutText for a fieldset layout object. See fieldset-align-expected.txt BUG= 648209 Review-Url: https://codereview.chromium.org/2373223002 Cr-Commit-Position: refs/heads/master@{#421911} [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/fast/css/invalidation/fieldset-disabled-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/fast/forms/fieldset/validation-in-fieldset-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/fast/forms/focus-selection-input-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/fast/forms/focus-selection-textarea-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/fast/forms/validity-property-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/platform/linux/fast/forms/fieldset/fieldset-align-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/platform/linux/fast/forms/focus-selection-textarea-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/fieldset/fieldset-align-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/platform/mac/fast/forms/fieldset/fieldset-align-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/platform/mac/fast/forms/focus-selection-textarea-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/LayoutTests/platform/win/fast/forms/fieldset/fieldset-align-expected.txt [delete] https://crrev.com/38991f06ebb579440a3bf3f3fbb8792a60b610d4/third_party/WebKit/LayoutTests/platform/win/fast/forms/focus-selection-textarea-expected.txt [modify] https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f/third_party/WebKit/Source/core/dom/Text.cpp
,
Sep 29 2016
,
Oct 4 2016
Verified the issue on windows 10 and Mac 10.11.6 using chrome dev version #55.0.2880.0 as per the comment #0. Observed that the fix is working as expected. Attaching screencast for reference. Hence, adding the verified labels. Note:: Issue verified on 55.0.2879.0 for Linux as the 55.0.2880.0 build got failed for linux due to issue 652581.
,
Oct 28 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 28 2016
CL listed at comment #6 landed before M55 branch. No M55 merge is needed. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by msrchandra@chromium.org
, Sep 19 2016Owner: glebl@chromium.org
Status: Assigned (was: Unconfirmed)