New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648197 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 295792
issue 429053



Sign in to add a comment

deqp/functional/gles3/texturespecification/basic_copyteximage2d.html fails on Intel Mac OSX

Project Member Reported by qiankun....@intel.com, Sep 19 2016

Issue description

<b>Version: <Kenneth, what is the frequency?></b>
<b>OS: <please tell me it's not XP></b>

What steps will reproduce the problem?
(1) open chrome with command line: --enable-unsafe-es3-apis on Mac with an Intel integrated graphics card.
(2) open url: https://www.khronos.org/registry/webgl/sdk/tests/deqp/functional/gles3/texturespecification/basic_copyteximage2d.html?webglVersion=2


What is the expected output?
All tests should pass.

What do you see instead?
cube map related tests fail.

glCopyTexImage2D has bug on Intel Mac drivers. It copies nothing to first face calling glCopyTexImage2D if the
CUBE_MAP_POSITIVE_X texture is not allocated yet. 

 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45903b6bfa81d0257af4da576e8edee825093b6b

commit 45903b6bfa81d0257af4da576e8edee825093b6b
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Fri Sep 23 04:28:58 2016

Force CUBE_MAP_POSITIVE_X texture allocation before CopyTexImage2D on Intel Mac

CopyTexImage2D has bug for cube map texture target on Intel Mac, if the
CUBE_MAP_POSITIVE_X texture is not allocated yet.

This CL works around this bug by doing TexImage2D to allocate the CUBE_MAP_POSITIVE_X
texture before CopyTexImage2D if target is one face of a cube map texture.

BUG= 648197 
TEST=deqp/functional/gles3/texturespecification/basic_copyteximage2d.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2348243002
Cr-Commit-Position: refs/heads/master@{#420575}

[modify] https://crrev.com/45903b6bfa81d0257af4da576e8edee825093b6b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/45903b6bfa81d0257af4da576e8edee825093b6b/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/45903b6bfa81d0257af4da576e8edee825093b6b/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/45903b6bfa81d0257af4da576e8edee825093b6b/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/45903b6bfa81d0257af4da576e8edee825093b6b/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/45903b6bfa81d0257af4da576e8edee825093b6b/gpu/config/gpu_driver_bug_workaround_type.h

basic_copyteximage2d.html also fails on Intel Mac 10.12. The failures are similar as failures on Intel Mac 10.11. But the work around solutions are different. For 10.11, positive x face of target level should be allocated, while 10.12, positive x face of level 0 and level 1 should be allocated.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45c5754736e2dffd0bcd34c5499c07a80acae58b

commit 45c5754736e2dffd0bcd34c5499c07a80acae58b
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Tue Oct 11 14:41:39 2016

Work around CopyTexImage2D issue on Intel Mac OSX 10.12

CopyTexImage2D for cube map target has bug on Intel Mac OSX 10.12. If
positive x face of the first two levels are not set, CopyTexImage2D will
copy incorrect pixel data to cube map texture. This bug is similar to
the bug fixed by https://codereview.chromium.org/2348243002/. But
solutions are different. This bug can be worked around by setting
positive x face of level 0 and 1.

BUG= 648197 
TEST=deqp/functional/gles3/texturespecification/basic_copyteximage2d.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2369313002
Cr-Commit-Position: refs/heads/master@{#424422}

[modify] https://crrev.com/45c5754736e2dffd0bcd34c5499c07a80acae58b/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/45c5754736e2dffd0bcd34c5499c07a80acae58b/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/45c5754736e2dffd0bcd34c5499c07a80acae58b/gpu/config/gpu_driver_bug_workaround_type.h

Status: Fixed (was: Assigned)

Sign in to add a comment