New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 648138 link

Starred by 3 users
Status: Verified
Owner:
michae...@chromium.org
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
█ brajkumar@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [MD Settings] 'Remove' option doesn't work properly for added language under 'Languages' section.

Reported by dchau...@etouch.net, Sep 19 2016 
Chrome Version: 55.0.2865.0 (Official Build)9ea2a739531edffad0859fdfd0a53f1f039026e4-refs/heads/master@{#419399} 32/64-bit.
OS: Windows (7,8,8.1,10).

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/ page and go to 'Languages' section.
2. Click on 'Add languages' button and add any language (For Ex: 'Hindi') from 'Add languages' overlay.
3. Select 'Hindi' language by clicking on it, click to open papper drop-down list of 'Hindi' language and observe the 'Remove' button.

'Remove' option doesn't get disabled even 'Hindi' language is selected.
'Remove' option should get disabled when 'Hindi' language is selected.

This is a regression issue, broken in M-55 series, below is manual regression range.

Good build: 55.0.2841.0
Bad build: 55.0.2842.0

Note: 
1. This issue is not seen on 'Mac' and 'Linux' OS.
2. To reproduce the issue frequently, repeat the above steps 2-3 times.

Kindly review the attached screen-cast for reference.
Language Screenshot.png
34.9 KB View Download
Actual behavior.mp4
617 KB View Download
Expected behavior.mp4
729 KB View Download

Comment 1 by msrchandra@chromium.org, Sep 20 2016

Labels: ReleaseBlock-Stable hasbisect-per-revision
Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2841.0 (Revision: 414854).
Bad build: 55.0.2842.0 (Revision: 414942).

You are probably looking for a change made after 414890 (known good), but no later than 414891 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/16e132a1b213a07254d25b50a42ba9e9304d3f75..b44ce49d6fa9df4aa44b14c7d5df3416ff1392ea

From the CL above, assigning the issue to the concern owner --
@michaelpg -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note: Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 2 by msrchandra@chromium.org, Sep 26 2016

Cc: brajkumar@chromium.org
 Issue 649642  has been merged into this issue.

Comment 3 by ajha@chromium.org, Sep 29 2016 

michaelpg@: Could you please take at this and update the thread.

Comment 4 by brajkumar@chromium.org, Oct 4 2016 

Still this issue is seen on Windows-10 using chrome latest Dev M55-55.0.2879.0.

michaelpg@ Since this issue is marked as RB-Stable could you please take a look in to it.

Thanks!

Comment 5 by ajha@chromium.org, Oct 13 2016 

michaelpg@: Please take a look at this update the thread accordingly.

Comment 6 by pbomm...@chromium.org, Oct 18 2016 

michaelpg@ can we know what's the status of the fix,since we are about to promote M55 to Beta and we need to get the fix into branch soon which is by 4Pm on 19th-oct.

Comment 7 by michae...@chromium.org, Oct 18 2016

Labels: -ReleaseBlock-Stable OS-Chrome
1. Sorry I haven't updated this yet.
2. Surprised this is still an issue.
3. MD Settings is not launched yet and should not block branches.

Comment 8 by kkaluri@chromium.org, Dec 5 2016

Labels: Proj-MaterialDesign-WebUI

Comment 9 by michae...@chromium.org, Dec 17 2016 

I believe this was fixed by https://codereview.chromium.org/2573643005 -- there was a data binding breakage when updating which language to show the menu for. I'll verify when I can.

Comment 10 by dbeam@chromium.org, Jan 7 2017

Labels: Hotlist-MD-Settings-Languages

Comment 11 by michae...@chromium.org, Feb 13 2017

Status: Fixed (was: Assigned)

Comment 12 by rookrishna@chromium.org, Mar 2 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment