EC: Crash reporting |
||
Issue descriptionNow that we fixed Issue 527904 , we have EC panicinfo in feedback reports. However, it would be useful to automatically report EC panicinfo to the crash server, just like Chrome/kernel crashes. As an example, it could allow us to tell the occurrence rate of https://code.google.com/p/chrome-os-partner/issues/detail?id=57544
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a6a158b23b7d732f0b32f7f3d93687860e9cc5c0 commit a6a158b23b7d732f0b32f7f3d93687860e9cc5c0 Author: Nicolas Boichat <drinkcat@google.com> Date: Wed Oct 05 21:51:33 2016 crash: Add signature to EC crashes Let's simply hash the panicinfo to obtain a somewhat unique signature for the crash. BUG=chromium:648134 TEST=EC console: crash assert; /sbin/crash_sender; crash is displayed in chrome://crashes; crash/ shows a signature Change-Id: Ieecb2fde8d5308992b0e37823853a111b0de5c2e Reviewed-on: https://chromium-review.googlesource.com/394086 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/a6a158b23b7d732f0b32f7f3d93687860e9cc5c0/crash-reporter/ec_collector.cc
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a3e6a4c59742a3855afc5590596a0c42ebe5a768 commit a3e6a4c59742a3855afc5590596a0c42ebe5a768 Author: Nicolas Boichat <drinkcat@google.com> Date: Thu Oct 06 16:11:15 2016 crash: Move HashString function to CrashCollector class This function can also be useful in the EC collector, let's move it to the super-class. BUG=chromium:648134 TEST=emerge-elm -av crash-reporter Change-Id: Ib7ada7633501d79e147d68ed67c7b8b9c163a3ab Reviewed-on: https://chromium-review.googlesource.com/394150 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/a3e6a4c59742a3855afc5590596a0c42ebe5a768/crash-reporter/kernel_collector.h [modify] https://crrev.com/a3e6a4c59742a3855afc5590596a0c42ebe5a768/crash-reporter/kernel_collector.cc [modify] https://crrev.com/a3e6a4c59742a3855afc5590596a0c42ebe5a768/crash-reporter/crash_collector.cc [modify] https://crrev.com/a3e6a4c59742a3855afc5590596a0c42ebe5a768/crash-reporter/crash_collector.h
,
Oct 7 2016
Some more TODOs: 1. Reporting kind of works: https://crash.corp.google.com/browse?stbtiq=6ddc219900000000#0 , but "Process type" is blank, which makes searching for EC crashes impossible... => Already fixed by crash server CL. 2. It would be nice if the binary data was presented base64-encoded, so that one could more easily copy and paste and for analysis by ec_parse_panicinfo... (this processing could be done on the DUT, arguably). 3. Include EC version in crash report.
,
Dec 6 2016
For 2, I now see that the process of parsing large number of crashes on http://crash is quite slow, as the signatures for similar crashes are often quite different (so one needs to download the file, pipe it to ec_parse_panicinfo, and repeat for lots of crashes). There are 2 ways to improve on this: a. Parse the panic data on DUT itself (ec_parse_panicinfo is a 10kb executable, so we could afford to ship it with every single image) b. Have the crash server do the parsing (ivanpe: is that easy/possible to do?) |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 7 2016