DevTools: touch emulation doesn't work for OOPIF.
Reported by
jshan...@etouch.net,
Sep 19 2016
|
||||||||||
Issue descriptionChrome Version: 55.0.2864.0 Revision 533dcff13b0b002494a3040d2f90de937a93e76d-refs/heads/master@{#419385} OS: Windows(7,8,10), Mac(10.10.5,10.11.4),Linux(14.04 LTS) URL: http://www.orimi.com/pdf-test.pdf Steps: 1. Launch Chrome and navigate to above URL. 2. Press 'F12' key to open dev-tool, click on 'Toggle device toolbar' icon and hover mouse on pdf page 3. Observe the mouse pointer. Actual: Device mode pointer (grey round mouse pointer) is not seen after emulating the pdf page i.e glimpse of device mode pointer is seen on emulating page, it does not stays. Expected: Device mode pointer (grey round mouse pointer) should be seen after emulating pdf page. This is a regression issue broken in 'M-55', will soon update bisect info: Good Build: 55.0.2841.0 Bad Build: 55.0.2842.0
,
Sep 19 2016
,
Sep 19 2016
,
Sep 19 2016
,
Sep 19 2016
This is broken because devtools doesn't support out-of-process iframes. The mouse move events usually get filtered here: https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/touch_emulator.cc?l=148 , but RenderWidgetHosts for out-of-process iframes don't have a TouchEmulator, so the move events go through. I don't think this should be a release blocker, re-add the label if you disagree.
,
Sep 19 2016
This is not a blocker. We are going to address this in Q4.
,
Sep 20 2016
+wjmaclean@ who is also working around TouchEmulator.
,
Sep 27 2016
Fixing the spelling error in label.
,
Oct 4 2016
,
Oct 6 2016
Issue 653036 has been merged into this issue.
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15e28404267139f257d4767194f780cb448c675d commit 15e28404267139f257d4767194f780cb448c675d Author: dgozman <dgozman@chromium.org> Date: Wed Mar 08 02:31:55 2017 [DevTools] Make touch emulation work with OOPIF. We now send touch emulation commands to all targets with TouchEmulation capability. BUG= 648126 Review-Url: https://codereview.chromium.org/2731383002 Cr-Commit-Position: refs/heads/master@{#455353} [modify] https://crrev.com/15e28404267139f257d4767194f780cb448c675d/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/15e28404267139f257d4767194f780cb448c675d/third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js [modify] https://crrev.com/15e28404267139f257d4767194f780cb448c675d/third_party/WebKit/Source/devtools/front_end/sdk/Target.js [modify] https://crrev.com/15e28404267139f257d4767194f780cb448c675d/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15e28404267139f257d4767194f780cb448c675d commit 15e28404267139f257d4767194f780cb448c675d Author: dgozman <dgozman@chromium.org> Date: Wed Mar 08 02:31:55 2017 [DevTools] Make touch emulation work with OOPIF. We now send touch emulation commands to all targets with TouchEmulation capability. BUG= 648126 Review-Url: https://codereview.chromium.org/2731383002 Cr-Commit-Position: refs/heads/master@{#455353} [modify] https://crrev.com/15e28404267139f257d4767194f780cb448c675d/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/15e28404267139f257d4767194f780cb448c675d/third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js [modify] https://crrev.com/15e28404267139f257d4767194f780cb448c675d/third_party/WebKit/Source/devtools/front_end/sdk/Target.js [modify] https://crrev.com/15e28404267139f257d4767194f780cb448c675d/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
,
Mar 8 2017
This should be fixed for regular iframes. Note that pdf will not work since we disable plugins in mobile device emulation to be closer to real devices. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by msrchandra@chromium.org
, Sep 19 2016Owner: nasko@chromium.org
Status: Assigned (was: Unconfirmed)