New issue
Advanced search Search tips

Issue 648113 link

Starred by 2 users
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Feb 2017
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 650607



Sign in to add a comment

CSS: will-change offset-path should establish a stacking context

Project Member Reported by ericwilligers@chromium.org, Sep 19 2016 
The motion path property offset-path (previously motion-path) should be included in hasPropertyThatCreatesStackingContext, as any non-initial value for offset-path should create a stacking context.

We should have a layout test for will-change: offset-path.


We should also verify the effectiveness of
css3/motion-path/path-establishes-stacking-context.html
in verifying that a stacking context is established when offset-path is not-none.

Comment 1 by suzyh@chromium.org, Sep 21 2016

Labels: Hotlist-Interop

Comment 2 by ericwilligers@chromium.org, Sep 27 2016

Blocking: 650607
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40c7b346c56c248c7337bfb33d46517439a0740f

commit 40c7b346c56c248c7337bfb33d46517439a0740f
Author: ericwilligers <ericwilligers@chromium.org>
Date: Thu Sep 29 07:08:34 2016

CSS Motion Path: offset-position,offset-path establish stacking context

When offset-path or offset-position are not their initial values,
a stacking context is created. Similarly, a stacking context is
created when either is mentioned by will-change.

https://drafts.fxtf.org/motion-1/#offset-path-property
https://drafts.fxtf.org/motion-1/#offset-position-property

BUG= 648113 

Review-Url: https://codereview.chromium.org/2369143003
Cr-Commit-Position: refs/heads/master@{#421767}

[add] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/offsetParent.html
[modify] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context-expected.html
[modify] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html
[add] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/path-will-change-establishes-stacking-context-expected.html
[add] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/path-will-change-establishes-stacking-context.html
[add] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/position-establishes-stacking-context-expected.html
[add] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/position-establishes-stacking-context.html
[add] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/position-will-change-establishes-stacking-context-expected.html
[add] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/LayoutTests/css3/motion-path/position-will-change-establishes-stacking-context.html
[modify] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/40c7b346c56c248c7337bfb33d46517439a0740f/third_party/WebKit/Source/core/style/ComputedStyle.h

Comment 4 by ericwilligers@chromium.org, Oct 11 2016

Status: Fixed (was: Assigned)

Comment 5 by ericwilligers@chromium.org, Feb 2 2017

Status: Started (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e289eb73fd434c373ec84258a740c9e0f3cdb7fd

commit e289eb73fd434c373ec84258a740c9e0f3cdb7fd
Author: ericwilligers <ericwilligers@chromium.org>
Date: Fri Feb 03 05:00:09 2017

CSS: will-change offset-path establishes a stacking context

hasWillChangeTransformHint now takes offset-path and offset-position
into account.

BUG= 648113 

Review-Url: https://codereview.chromium.org/2671763002
Cr-Commit-Position: refs/heads/master@{#447948}

[modify] https://crrev.com/e289eb73fd434c373ec84258a740c9e0f3cdb7fd/third_party/WebKit/LayoutTests/transforms/containing-block.html
[modify] https://crrev.com/e289eb73fd434c373ec84258a740c9e0f3cdb7fd/third_party/WebKit/Source/core/style/ComputedStyle.cpp

Comment 7 by ericwilligers@chromium.org, Feb 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment