New issue
Advanced search Search tips

Issue 648052 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 2
Type: Feature

Blocking:
issue 587995



Sign in to add a comment

Add support for shipping type in the user interface

Project Member Reported by jinho.b...@samsung.com, Sep 18 2016

Issue description

The api allows the page to influence how the shipping address is described.
 - https://github.com/w3c/browser-payment-api/pull/270
 - https://w3c.github.io/browser-payment-api/#idl-def-paymentshippingtype
 
I filed a spec bug for this:
  https://github.com/w3c/browser-payment-api/issues/271
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac3f96f1115b079eec5e48700588022673b9986d

commit ac3f96f1115b079eec5e48700588022673b9986d
Author: jinho.bang <jinho.bang@samsung.com>
Date: Fri Sep 23 17:23:47 2016

PaymentRequest: Add support for shipping type. (in blink side)

This CL is adding support for shipping type. The API allows the page to
influence how the shipping address is described.

Related spec change:
  https://github.com/w3c/browser-payment-api/pull/270
  https://github.com/w3c/browser-payment-api/pull/285

BUG= 648052 

Review-Url: https://codereview.chromium.org/2351533002
Cr-Commit-Position: refs/heads/master@{#420643}

[modify] https://crrev.com/ac3f96f1115b079eec5e48700588022673b9986d/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/ac3f96f1115b079eec5e48700588022673b9986d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ac3f96f1115b079eec5e48700588022673b9986d/third_party/WebKit/Source/modules/payments/PaymentOptions.idl
[modify] https://crrev.com/ac3f96f1115b079eec5e48700588022673b9986d/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/ac3f96f1115b079eec5e48700588022673b9986d/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/ac3f96f1115b079eec5e48700588022673b9986d/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[modify] https://crrev.com/ac3f96f1115b079eec5e48700588022673b9986d/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Cc: jinho.b...@samsung.com
Components: UI>Browser>Autofill>Payments
Labels: -Type-Launch-OWP Type-Feature
Owner: rouslan@chromium.org
Adding Android UI for this.
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae

commit 6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae
Author: rouslan <rouslan@chromium.org>
Date: Wed Oct 26 17:41:40 2016

Add support for shipping type in web payments

This API lets the page influence how the shipping address is described.
 - https://github.com/w3c/browser-payment-api/pull/270
 - https://w3c.github.io/browser-payment-api/#idl-def-paymentshippingtype

BUG= 648052 

Review-Url: https://codereview.chromium.org/2453463004
Cr-Commit-Position: refs/heads/master@{#427738}

[modify] https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[add] https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae/chrome/android/java/src/org/chromium/chrome/browser/payments/ShippingStrings.java
[modify] https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae/chrome/android/java_sources.gni
[modify] https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae/components/payments/payment_request.mojom
[modify] https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment