Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 3 users
Status: Fixed
Owner:
Closed: Jun 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android, iOS
Pri: 2
Type: Feature

Blocking:
issue 587995



Sign in to add a comment
Support collection of payer name without shipping address.
Project Member Reported by jinho.b...@samsung.com, Sep 18 2016 Back to list
Cc: rouslan@chromium.org
For UI, my suggestion is that.. (even if my thinking is not important)
 - Rename ContantEditor to PayerInfoEditor
 - Add a Payer Name field on the payment sheet UI (if requestPayerName is true).

What do you think?
Excellent suggestion :-)
Labels: -Type-Launch-OWP Type-Feature
Cc: jdonnelly@chromium.org
Justin, you are subscribed to Blink>Payments, or should I cc you on bugs that are relevant for iOS?
I'm subscribed now, thanks.
Project Member Comment 8 by bugdroid1@chromium.org, Sep 22 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25ee6c8c02d34d0176db8db484af8fb92cbab0d

commit e25ee6c8c02d34d0176db8db484af8fb92cbab0d
Author: jinho.bang <jinho.bang@samsung.com>
Date: Thu Sep 22 03:43:33 2016

PaymentRequest: Add support for payerName. (in blink side)

Support collection of payer name without shipping address.
This CL is a initial implementation for requestPayerName in blink side.
So, it's behind a runtime flag to avoid breaking existing behavior.
If once we implement the related UI, then can remove the flag.

Related spec change:
  https://github.com/w3c/browser-payment-api/pull/270

BUG= 648051 

Review-Url: https://codereview.chromium.org/2348103002
Cr-Commit-Position: refs/heads/master@{#420255}

[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/Source/modules/payments/PaymentOptions.idl
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/Source/modules/payments/PaymentResponse.h
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Cc: -rouslan@chromium.org jinho.b...@samsung.com
Owner: rouslan@chromium.org
I will add UI.
Hi rouslan@,

Did you already start to work on this UI?
If not so, can I try to it without string resources?
Status: Assigned
I have not started working on this. You can take this, if you want. What do you mean by "without string resources"? You can add the English string "Name" here:

https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chrome_strings.grd?rcl=0&l=2593
Status: Started
Okay thanks. I'm starting to work on this.
WIP CL: https://codereview.chromium.org/2368073002/
(But it's not ready to request review yet)
Project Member Comment 14 by bugdroid1@chromium.org, Oct 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2

commit 04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2
Author: jinho.bang <jinho.bang@samsung.com>
Date: Fri Oct 21 03:47:25 2016

PaymentRequest: Add payer name field to payer info editor. (android)

This CL is adding a name field to collect payer name from user on Payment UI.

Blink side change:
  https://codereview.chromium.org/2348103002/

Related spec change:
  https://github.com/w3c/browser-payment-api/pull/270

Intent to implement and ship:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_L5nKV3SSYw

BUG= 648051 

Review-Url: https://chromiumcodereview.appspot.com/2368073002
Cr-Commit-Position: refs/heads/master@{#426718}

[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java
[add] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameAndFreeShippingTest.java
[add] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/test/data/android/payments/contact_details.js
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/test/data/android/payments/contact_details_and_free_shipping.js
[add] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/test/data/android/payments/name.js
[add] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/test/data/android/payments/name_and_free_shipping.js
[add] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/test/data/android/payments/payment_request_name_and_free_shipping_test.html
[add] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/chrome/test/data/android/payments/payment_request_name_test.html
[modify] https://crrev.com/04dad8e7c11b7d2e44ca5d36bf6167278ed3e2b2/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Cc: -jdonnelly@chromium.org
Owner: jdonnelly@chromium.org
Status: Assigned
Only iOS work remaining.
Project Member Comment 17 by bugdroid1@chromium.org, Nov 10 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58f500b5bb9149f63c2c42c1977ead5a2692eb25

commit 58f500b5bb9149f63c2c42c1977ead5a2692eb25
Author: corona10 <corona10@gmail.com>
Date: Thu Nov 10 16:18:27 2016

[Payment] Clean up PaymentResponse::toJSONForBinding

When https://codereview.chromium.org/2476393003/ is landed.
We could clean up toJSONForBinding.
BUG= 648051 

Review-Url: https://codereview.chromium.org/2491513002
Cr-Commit-Position: refs/heads/master@{#431269}

[modify] https://crrev.com/58f500b5bb9149f63c2c42c1977ead5a2692eb25/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Cc: mahmadi@chromium.org
Status: Fixed
AFAIK, this has been fixed. Moe: Is "requestPayerName" implemented on iOS as well?
Yes, we do collect info on iOS orthogonal to shipping.
Sign in to add a comment