New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648047 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 647807
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in TInfoSinkBase::operator<<

Project Member Reported by ClusterFuzz, Sep 18 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4712454548619264

Fuzzer: libfuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow WRITE 9
Crash Address: 0x618000000425
Crash State:
  TInfoSinkBase::operator<<
  TOutputGLSLBase::writeVariableType
  TOutputGLSLBase::visitAggregate
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=419036:419121

Minimized Testcase (0.73 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94XsYlqrrIUDNXtYXQ5-SS-cXl4Uvl44Vzh9PvvRjdGuW41jLgoa27byM7kmYAco2nccydbstb4b302kfmAh-ayyno4xEgIoM2FazqdDn9mbsIIOVD0p2PETPB09YUy3-1UiLeCEwh1CpOeSnP2MFA8Pn1FWQ?testcase_id=4712454548619264

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 19 2016

Labels: M-55
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 19 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 19 2016

Labels: Pri-1
Cc: jmad...@chromium.org
Components: Internals>GPU>ANGLE
Owner: qiankun....@intel.com
Status: Assigned (was: Untriaged)
Hello,

Clusterfuzz thinks your recent CL has caused this security bug:
https://chromium.googlesource.com/chromium/src/+/626d9576addcbc392fefbf02fdec0d822d782ae1

Feel free to re-assign as appropriate.  Thanks!
Cc: -oetu...@nvidia.com qiankun....@intel.com
Owner: oetu...@nvidia.com
Shifting ownership.
Olli, ping me and I'll send you the problematic shader.
Mergedinto: 647807
Status: Duplicate (was: Assigned)
I think this is a result of the fuzzer not using the right defines. Should hopefully be fixed already. Seems to pass when I use top-of-tree angle.
Cc: oetu...@nvidia.com
Owner: cwallez@chromium.org
Project Member

Comment 10 by ClusterFuzz, Sep 22 2016

ClusterFuzz has detected this issue as fixed in range 420165:420262.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4712454548619264

Fuzzer: libfuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow WRITE 9
Crash Address: 0x618000000425
Crash State:
  TInfoSinkBase::operator<<
  TOutputGLSLBase::writeVariableType
  TOutputGLSLBase::visitAggregate
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=419036:419121
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=420165:420262

Minimized Testcase (0.73 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94XsYlqrrIUDNXtYXQ5-SS-cXl4Uvl44Vzh9PvvRjdGuW41jLgoa27byM7kmYAco2nccydbstb4b302kfmAh-ayyno4xEgIoM2FazqdDn9mbsIIOVD0p2PETPB09YUy3-1UiLeCEwh1CpOeSnP2MFA8Pn1FWQ?testcase_id=4712454548619264

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 28 2016

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment