New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 648029 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Chrome 53 broke Hardware Acceleration for adobe flash player on Windows 81. enterprise

Reported by larry....@yahoo.com, Sep 18 2016

Issue description

Chrome Version       : 53.0.2785.116
OS Version: 6.3
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1.  launch www.vudu.com
2.  click tab "new trailers" in "new" 
3.  Click and player any trailer  in "new trailers"


What is the expected result?

Video playback is smooth without dropped frame or pause, it is SD video

What happens instead of that?

Pause, dropped frame, shutter

Please provide any additional information below. Attach a screenshot if
possible.

The player is adobe flash, default mode is Hardware acceleration is enabled.
Disable hardware acceleration is not an acceptable solution, because HD movie title requires Hardware acceleration.

Previous version Chrome 52 51, 50 .. works fine.


UserAgentString: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36



 
Components: Internals>Plugins>Flash
Labels: -Type-Bug M-53 Type-Bug-Regression

Comment 2 by gov...@chromium.org, Sep 18 2016

Cc: pbomm...@chromium.org lafo...@chromium.org
Components: -Internals>Plugins>Flash Internals>Compositing Internals>Media>Hardware
Owner: jbau...@chromium.org
Status: Assigned (was: Unconfirmed)
Please find the regression range for the issue below : 

https://chromium.googlesource.com/chromium/src/+log/53.0.2768.0..53.0.2770.0?pretty=fuller&n=10000

Suspecting Cl : https://chromium.googlesource.com/chromium/src/+/6384f843ccb11bfc9ccd3b183115ac2e2ca10589


Note : I don't have a Win8.1 Corp machine to perform the more refined bisect. I will check into that tomorrow 

Comment 4 by larry....@yahoo.com, Sep 18 2016

Thanks for your quick reply.
More info, when playing the trailer in "new trailer" from video from www.vudu.com, move the mouse over the movie window, you will find a bar at the bottom , right click button on bar, menu pops up. select the first item "Vudu Movie playback info"  If the hardware decoding value is "yes" , there is no problem; If the hardware decoding is "no", the video has problem to play.  Previous version Chrome shows "yes" for hardware decoding when hardware acceleration is enabled. Chrome 53 does not work in this way. Even if Hardware acceleration is enabled, hardware decoding value is still no. I think that't the root reason video frame dropped.
If you need more info, please let me know.
Note, please play the trailer in "new" -> "new trailers"  They are encrypted SD video.    For encrypted HD video, result is much worse.
For non encrypted SD video, not so obvious.

Regards,
-Larry 

    On Sunday, September 18, 2016 1:58 PM, pbomm… via monorail <monorail+v2.2239043687@chromium.org> wrote:
 

  Updates:
 Components: -Internals>Plugins>Flash Internals>Compositing Internals>Media>Hardware
 Owner: jbau...@chromium.org
 Status: Assigned

Comment 5 by larry....@yahoo.com, Sep 18 2016

Web address to try to play the trailer
VUDU - Watch Movies

  
|  
|   |  
VUDU - Watch Movies
   |  |

  |

 
 

    On Sunday, September 18, 2016 4:02 PM, Larry Cui <larry.cui@yahoo.com> wrote:
 

 Thanks for your quick reply.
More info, when playing the trailer in "new trailer" from video from www.vudu.com, move the mouse over the movie window, you will find a bar at the bottom , right click button on bar, menu pops up. select the first item "Vudu Movie playback info"  If the hardware decoding value is "yes" , there is no problem; If the hardware decoding is "no", the video has problem to play.  Previous version Chrome shows "yes" for hardware decoding when hardware acceleration is enabled. Chrome 53 does not work in this way. Even if Hardware acceleration is enabled, hardware decoding value is still no. I think that't the root reason video frame dropped.
If you need more info, please let me know.
Note, please play the trailer in "new" -> "new trailers"  They are encrypted SD video.    For encrypted HD video, result is much worse.
For non encrypted SD video, not so obvious.

Regards,
-Larry 

    On Sunday, September 18, 2016 1:58 PM, pbomm… via monorail <monorail+v2.2239043687@chromium.org> wrote:
 

  Updates:
 Components: -Internals>Plugins>Flash Internals>Compositing Internals>Media>Hardware
 Owner: jbau...@chromium.org
 Status: Assigned

Comment 6 by larry....@yahoo.com, Sep 19 2016

web address to play new trailers:

http://www.vudu.com/movies/#new/new_trailers
Should be fixed by https://codereview.chromium.org/2351723004/

Comment 8 Deleted

Cc: gov...@chromium.org
Labels: M-54 Merge-Request-54
Once the fix has been confirmed we should merge it to M54 and maybe M53 (though admittedly just shy of the bar for being a Stability/Security/Critical regression).
Labels: ReleaseBlock-Stable
Yeah, lets merge to M54 first once fix is confirmed. 

And I agree with laforge@, this is just a shy of the bar for being a Critical regression for M53.
Who will confirm the fix on Windows 8.1 or Windows 10? 

The sample video address is http://www.vudu.com/movies/#new/new_trailers

Where can I download the new chrome.exe?


 larry.cui@ the Cl should make to Chrome Canary tomorrow and which can be found here https://www.google.com/chrome/browser/canary.html

Comment 14 by dimu@chromium.org, Sep 21 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Please confirm whether this change is baked/verified in Canary and safe to merge?If yes, merge your change to M54 (branch: 2840) ASAP so that we could take this for next Beta Release.
Yeah, this change is safe and is working in canary, so merging now.
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 21 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7727179f3d585a012b8611c0e065aca8c19e862a

commit 7727179f3d585a012b8611c0e065aca8c19e862a
Author: John Bauman <jbauman@chromium.org>
Date: Wed Sep 21 19:31:09 2016

Don't attempt to use NV12 with hardware decoding in Flash.

The ppapi interface and plugin itself don't support it.

BUG= 648029 

Review-Url: https://codereview.chromium.org/2351723004
Cr-Commit-Position: refs/heads/master@{#419637}
(cherry picked from commit 8fe054d0f760fdff716bf9c676f691abdcd4850d)

Review URL: https://codereview.chromium.org/2360023002 .

Cr-Commit-Position: refs/branch-heads/2840@{#469}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/7727179f3d585a012b8611c0e065aca8c19e862a/content/renderer/pepper/ppb_video_decoder_impl.cc

Status: Fixed (was: Assigned)
Verified, fixed my problem.
Please include this fix in chrome release as soon as possible.



This fix is not included in Dev 55 or Beta 54 updated on Sept 21. Only in Canary 55

http://www.chromium.org/getting-involved/dev-channel

When will it be released?

Comment 21 by ajha@chromium.org, Sep 28 2016

Labels: TE-Verified-54.0.2840.41 TE-Verified-M54
I was able to reproduce the issue on the latest stable(53.0.2785.116) on Windows-8.1 Pro and can confirm the same is merged and working fine on the latest M-54(54.0.2840.41).


Adding the verified label therefore. 
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7727179f3d585a012b8611c0e065aca8c19e862a

commit 7727179f3d585a012b8611c0e065aca8c19e862a
Author: John Bauman <jbauman@chromium.org>
Date: Wed Sep 21 19:31:09 2016

Don't attempt to use NV12 with hardware decoding in Flash.

The ppapi interface and plugin itself don't support it.

BUG= 648029 

Review-Url: https://codereview.chromium.org/2351723004
Cr-Commit-Position: refs/heads/master@{#419637}
(cherry picked from commit 8fe054d0f760fdff716bf9c676f691abdcd4850d)

Review URL: https://codereview.chromium.org/2360023002 .

Cr-Commit-Position: refs/branch-heads/2840@{#469}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/7727179f3d585a012b8611c0e065aca8c19e862a/content/renderer/pepper/ppb_video_decoder_impl.cc

Sign in to add a comment