New issue
Advanced search Search tips

Issue 647996 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

ClangToTiOS fails to compile

Project Member Reported by thakis@chromium.org, Sep 18 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/ClangToTiOS/builds/8622/steps/compile/logs/stdio

FAILED: obj/ios/chrome/browser/browser/open_url_util.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ios/chrome/browser/browser/open_url_util.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=281798 -DCR_XCODE_VERSION=0700 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_BUILD_NO_OPTS -DSK_SUPPORT_GPU=0 -DDISABLE_FTP_SUPPORT=1 -DLEVELDB_PLATFORM_CHROMIUM=1 -I../.. -Igen -I../../third_party/libwebp -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../breakpad/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/boringssl/src/include -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -Igen/components -Igen/components -Igen/components/strings -Igen/components/strings -Igen/components/strings -Igen/components/strings -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -Igen/ui/resources -Igen/ui/resources -Igen/ios/chrome -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fcolor-diagnostics -arch armv7 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O0 -gdwarf-2 -isysroot /Applications/Xcode7.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.0.sdk -stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wno-unused-function -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++11 -fobjc-call-cxx-cdtors -fno-rtti -fno-exceptions -c ../../ios/chrome/browser/open_url_util.mm -o obj/ios/chrome/browser/browser/open_url_util.o
../../ios/chrome/browser/open_url_util.mm:14:40: error: instance method '-openURL:options:completionHandler:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
    [[UIApplication sharedApplication] openURL:url
                                       ^~~~~~~~~~~
/Applications/Xcode7.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:103:40: note: receiver is instance of class declared here
NS_CLASS_AVAILABLE_IOS(2_0) @interface UIApplication : UIResponder
                                       ^
1 error generated.

clang 281796:281798

Probably due to https://codereview.chromium.org/2340873002 though. Are non-trunk bots all happy?
 
Cc: d...@chromium.org
Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)
It loos like only ClangToTiOS is failing.

thakis@ Can we put Xcode 8 on ClangToTiOS too?

If not, we should revert / add compiler guards around -openURL.

dba@ thoughts?

Comment 2 by thakis@chromium.org, Sep 19 2016

If all the other iOS bots have xcode8, that bot should too.
Ah, I see, https://codereview.chromium.org/2347943002 needed to include ClangToTiOS too.
Status: Started (was: Assigned)
started: https://codereview.chromium.org/2353453003/
Status: Fixed (was: Started)
https://build.chromium.org/p/chromium.fyi/builders/ClangToTiOS is now green.

Looks like https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS is red because it doesn't have Xcode 8.  I'll file that in a different bug.

Sign in to add a comment