New issue
Advanced search Search tips

Issue 647879 link

Starred by 2 users
Status: Archived
Owner:
msw@chromium.org
Closed: Jun 2017
Cc:
msw@chromium.org
jamescook@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 681072



Sign in to add a comment

mash: Shelf doesn't show pinned apps from prefs.

Project Member Reported by msw@chromium.org, Sep 17 2016 
mash: Shelf doesn't show pinned apps from prefs.

Running with --login-manager shows the expected pinned apps.
Using the same user-data-dir & profile with --login-manager and --mash doesn't.

GetPinnedAppsFromPrefs returns early because |app_service| is null.
The profile instance has a blank GetProfileUserName (maybe login dummy profile).
I think this is just called too early (before login in mash, after login in cash)
I'm working on it...

Comment 1 by msw@chromium.org, Sep 17 2016

Cc: sky@chromium.org
Ah, ChromeLauncherControllerMus::ActiveUserChanged should call ChromeMashShelfController::PinAppsFromPrefs().

Instead of piecing together missing bits of ChromeLauncherControllerMus in this reactionary fashion, it might make sense to instead re-use the classic ash implementation (ChromeLauncherControllerImpl) and just avoid ash::Shell-dependent functionality when running in mash for now. That might require substantial refactoring (ChromeLauncherControllerImpl is-a ash::ShelfDelegate, etc.), but it might be a better path forward...

Comment 2 by yye...@google.com, Sep 26 2016 

An enterprise customer is reporting that on CrOS version 53.0.2785.103, pinned apps aren't persisting in the shelf on logout/log back in.  This occurs when apps are pinned locally (not via policy).

Can someone please confirm this the same issue listed in this bug?
If so, do we have an ETA on a fix?

Comment 3 by msw@chromium.org, Sep 26 2016 

That's an unrelated issue; Proj-Mustash-Mash is not available to users yet.

Comment 4 by msw@chromium.org, Jan 13 2017

Blocking: 681072

Comment 5 by msw@chromium.org, Jan 27 2017

Cc: msw@chromium.org
 Issue 686289  has been merged into this issue.

Comment 6 by msw@chromium.org, Jan 27 2017

Labels: -Pri-2 Pri-1

Comment 7 by msw@chromium.org, Jun 7 2017

Status: Fixed (was: Started)
This is now fixed with ShelfModel synchronization added by my CL:
  https://codereview.chromium.org/2833173002/

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment