CHECK failure, multibuffer_reader.cc:119 |
||||
Issue descriptionHit this while seeking on the test page from crbug 646434. Sorry for the mangled symbols (this is normal for a Mac debug build, and I wasn't able to reproduce). [45533:1295:0916/153003:FATAL:multibuffer_reader.cc(119)] Check failed: len <= max_buffer_forward_ (1 vs. 0) 0 libbase.dylib 0x0000000115502d7e _ZN4base5debug10StackTraceC2Ev + 30 1 libbase.dylib 0x0000000115502de5 _ZN4base5debug10StackTraceC1Ev + 21 2 libbase.dylib 0x000000011559a2c0 _ZN7logging10LogMessageD2Ev + 80 3 libbase.dylib 0x0000000115597e75 _ZN7logging10LogMessageD1Ev + 21 4 libmedia_blink.dylib 0x000000013006092e _ZN5media17MultiBufferReader4WaitExRKN4base8CallbackIFvvELNS1_8internal8CopyModeE1ELNS4_10RepeatModeE1EEE + 558 5 libmedia_blink.dylib 0x000000013005883c _ZN5media21MultibufferDataSource8ReadTaskEv + 3068 6 libmedia_blink.dylib 0x000000013005d222 _ZN4base8internal13FunctorTraitsIMN5media21MultibufferDataSourceEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_ + 130 7 libmedia_blink.dylib 0x000000013005d192 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5media21MultibufferDataSourceEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ + 82 8 libmedia_blink.dylib 0x000000013005d138 _ZN4base8internal7InvokerINS0_9BindStateIMN5media21MultibufferDataSourceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE + 72 9 libmedia_blink.dylib 0x000000013005d08c _ZN4base8internal7InvokerINS0_9BindStateIMN5media21MultibufferDataSourceEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE + 44 10 libbase.dylib 0x00000001154c142b _ZNK4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEE3RunEv + 59 11 libbase.dylib 0x00000001155048b4 _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 676 12 libblink_platform.dylib 0x000000012caa6967 _ZN5blink9scheduler16TaskQueueManager24ProcessTaskFromWorkQueueEPNS0_8internal9WorkQueueE + 1639 13 libblink_platform.dylib 0x000000012caa2e22 _ZN5blink9scheduler16TaskQueueManager6DoWorkEN4base9TimeTicksEb + 1410 14 libblink_platform.dylib 0x000000012caac307 _ZN4base8internal13FunctorTraitsIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEvE6InvokeIRKNS_7WeakPtrIS4_EEJRKS5_RKbEEEvS7_OT_DpOT0_ + 199 15 libblink_platform.dylib 0x000000012caac0f0 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbERKNS_7WeakPtrIS6_EEJRKS7_RKbEEEvOT_OT0_DpOT1_ + 128 16 libblink_platform.dylib 0x000000012caac06a _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEJNS_7WeakPtrIS5_EES6_bEEEFvvEE7RunImplIRKS8_RKNSt3__15tupleIJSA_S6_bEEEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE + 138 17 libblink_platform.dylib 0x000000012caabf5c _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEJNS_7WeakPtrIS5_EES6_bEEEFvvEE3RunEPNS0_13BindStateBaseE + 44 18 libbase.dylib 0x00000001154c142b _ZNK4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEE3RunEv + 59 19 libbase.dylib 0x00000001155048b4 _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 676 20 libbase.dylib 0x00000001155e932d _ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 877 21 libbase.dylib 0x00000001155e9914 _ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE + 68 22 libbase.dylib 0x00000001155ea38d _ZN4base11MessageLoop6DoWorkEv + 669 23 libbase.dylib 0x00000001155fb3d8 _ZN4base24MessagePumpCFRunLoopBase7RunWorkEv + 104 24 libbase.dylib 0x00000001155fb35c ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28 25 libbase.dylib 0x000000011559e25a _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10 26 libbase.dylib 0x00000001155fa8d5 _ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 101 27 CoreFoundation 0x00007fff8d64f881 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 28 CoreFoundation 0x00007fff8d62efbc __CFRunLoopDoSources0 + 556 29 CoreFoundation 0x00007fff8d62e4df __CFRunLoopRun + 927 30 CoreFoundation 0x00007fff8d62ded8 CFRunLoopRunSpecific + 296 31 Foundation 0x00007fff9a619ed9 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 270 32 libbase.dylib 0x00000001155fbeb9 _ZN4base20MessagePumpNSRunLoop5DoRunEPNS_11MessagePump8DelegateE + 137 33 libbase.dylib 0x00000001155fb0ba _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 122 34 libbase.dylib 0x00000001155e8b3a _ZN4base11MessageLoop10RunHandlerEv + 298 35 libbase.dylib 0x00000001156b24a5 _ZN4base7RunLoop3RunEv + 85 36 libcontent.dylib 0x000000011dcc5ba1 _ZN7content12RendererMainERKNS_18MainFunctionParamsE + 4465 37 libcontent.dylib 0x000000011e1edc27 _ZN7content23RunNamedProcessTypeMainERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEERKNS_18MainFunctionParamsEPNS_19ContentMainDelegateE + 599 38 libcontent.dylib 0x000000011e1efb16 _ZN7content21ContentMainRunnerImpl3RunEv + 1462 39 libcontent.dylib 0x000000011e1ed48d _ZN7content11ContentMainERKNS_17ContentMainParamsE + 349 40 libchrome_dll.dylib 0x0000000101750fd3 ChromeMain + 83 41 Chromium Helper 0x0000000101514d7c main + 780 42 Chromium Helper 0x0000000101514a64 start + 52 43 ??? 0x0000000000000015 0x0 + 21
,
Sep 22 2016
I think this is fixed, Dan can you verify?
,
Sep 22 2016
This occurred while seeking in the frozen state of issue 646434 . Since that isn't reproducible anymore, this isn't either. I guess we'll count that as verified :-)
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b39d634c0efdd5912bfca4336ba9dc908e67fe10 commit b39d634c0efdd5912bfca4336ba9dc908e67fe10 Author: Fredrik Hubinette <hubbe@google.com> Date: Thu Sep 22 22:36:17 2016 Fix a timing bug in multibuffer. When "cancel on defer is on", the multibuffer reader can sometimes get delete before it is allowed to deliver a pending read callback. This basically hangs the multibuffer data source as it waits for the read callback forever. BUG= 648395 , 647867 , 646434 Review-Url: https://codereview.chromium.org/2357773003 Cr-Commit-Position: refs/heads/master@{#419995} (cherry picked from commit 3b2a5629da155db59d3449a6d640c107e91aa14d) Review URL: https://codereview.chromium.org/2362953002 . Cr-Commit-Position: refs/branch-heads/2840@{#500} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b39d634c0efdd5912bfca4336ba9dc908e67fe10/media/blink/multibuffer_data_source.cc [modify] https://crrev.com/b39d634c0efdd5912bfca4336ba9dc908e67fe10/media/blink/multibuffer_data_source.h [modify] https://crrev.com/b39d634c0efdd5912bfca4336ba9dc908e67fe10/media/blink/multibuffer_data_source_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b39d634c0efdd5912bfca4336ba9dc908e67fe10 commit b39d634c0efdd5912bfca4336ba9dc908e67fe10 Author: Fredrik Hubinette <hubbe@google.com> Date: Thu Sep 22 22:36:17 2016 Fix a timing bug in multibuffer. When "cancel on defer is on", the multibuffer reader can sometimes get delete before it is allowed to deliver a pending read callback. This basically hangs the multibuffer data source as it waits for the read callback forever. BUG= 648395 , 647867 , 646434 Review-Url: https://codereview.chromium.org/2357773003 Cr-Commit-Position: refs/heads/master@{#419995} (cherry picked from commit 3b2a5629da155db59d3449a6d640c107e91aa14d) Review URL: https://codereview.chromium.org/2362953002 . Cr-Commit-Position: refs/branch-heads/2840@{#500} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b39d634c0efdd5912bfca4336ba9dc908e67fe10/media/blink/multibuffer_data_source.cc [modify] https://crrev.com/b39d634c0efdd5912bfca4336ba9dc908e67fe10/media/blink/multibuffer_data_source.h [modify] https://crrev.com/b39d634c0efdd5912bfca4336ba9dc908e67fe10/media/blink/multibuffer_data_source_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Sep 21 2016