Issue metadata
Sign in to add a comment
|
ash::ShelfModel::Move |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 53.0.2785.123 (Official Build) beta (32-bit) Platform 8530.87.0 (Official Build) beta-channel veyron_minnie ARC 3274401 What steps will reproduce the problem? Move apps from the shelf What do you see instead? Browser is crashed Reproduced only once. Crash report: https://crash.corp.google.com/browse?stbtiq=ed16921e00000000 hread 0 CRASHED [SIGABRT @ 0x000003e8000079b7 ] MAGIC SIGNATURE THREAD 0x00007f103c610b82 (libc-2.19.so -raise.c:56 ) raise 0x00007f103c61289f (libc-2.19.so -abort.c:89 ) abort 0x00007f103cf0f624 (libstdc++.so.6.0.20 -vterminate.cc:95 ) __gnu_cxx::__verbose_terminate_handler 0x00007f103cf0d365 (libstdc++.so.6.0.20 -eh_terminate.cc:47 ) __cxxabiv1::__terminate 0x00007f103cf0d3b0 (libstdc++.so.6.0.20 -eh_terminate.cc:57 ) std::terminate 0x00007f103cf0d620 (libstdc++.so.6.0.20 -eh_throw.cc:87 ) __cxxabiv1::__cxa_throw 0x00007f103cf6a5d0 (libstdc++.so.6.0.20 -functexcept.cc:101 ) std::__throw_out_of_range_fmt 0x00007f103f28bae1 (chrome -stl_vector.h:898 ) std::vector<CJS_Value, std::allocator<CJS_Value> >::_M_range_check 0x00007f104180ab08 (chrome -stl_vector.h:864 ) ash::ShelfModel::Move 0x00007f10418422d5 (chrome -shelf_view.cc:1478 ) ash::ShelfView::CancelDrag 0x00007f1041842594 (chrome -shelf_view.cc:1597 ) ash::ShelfView::ShelfItemRemoved 0x00007f104180a1f7 (chrome -shelf_model.cc:71 ) ash::ShelfModel::RemoveItemAt 0x00007f10416f1ab6 (chrome -chrome_launcher_controller_impl.cc:1116 ) ChromeLauncherControllerImpl::LauncherItemClosed 0x00007f10418420f3 (chrome -shelf_view.cc:1279 ) ash::ShelfView::FinalizeRipOffDrag 0x00007f104184294b (chrome -shelf_view.cc:789 ) ash::ShelfView::PointerReleasedOnButton 0x00007f1042ec13f6 (chrome -event_dispatcher.cc:191 ) ui::EventDispatcher::DispatchEvent 0x00007f1042ec17e0 (chrome -event_dispatcher.cc:139 ) ui::EventDispatcher::ProcessEvent 0x00007f1042ec18c6 (chrome -event_dispatcher.cc:86 ) ui::EventDispatcherDelegate::DispatchEventToTarget 0x00007f1042ec19c8 (chrome -event_dispatcher.cc:58 ) ui::EventDispatcherDelegate::DispatchEvent 0x00007f1042025b4b (chrome -root_view.cc:447 ) views::internal::RootView::OnMouseReleased 0x00007f104202ae58 (chrome -widget.cc:1208 ) views::Widget::OnMouseEvent 0x00007f1041846c61 (chrome -shelf_widget.cc:818 ) ash::ShelfWidget::OnMouseEvent 0x00007f1042ec13f6 (chrome -event_dispatcher.cc:191 ) ui::EventDispatcher::DispatchEvent 0x00007f1042ec17e0 (chrome -event_dispatcher.cc:139 ) ui::EventDispatcher::ProcessEvent 0x00007f1042ec18c6 (chrome -event_dispatcher.cc:86 ) ui::EventDispatcherDelegate::DispatchEventToTarget 0x00007f1042ec19c8 (chrome -event_dispatcher.cc:58 ) ui::EventDispatcherDelegate::DispatchEvent 0x00007f1042ec1fc6 (chrome -event_processor.cc:35 ) ui::EventProcessor::OnEventFromSource 0x00007f1042ec2362 (chrome -event_source.cc:73 ) ui::EventSource::DeliverEventToProcessor 0x00007f1042ec259d (chrome -event_source.cc:51 ) ui::EventSource::SendEventToProcessor 0x00007f1041834b9e (chrome -ash_window_tree_host_platform.cc:110 ) ash::AshWindowTreeHostPlatform::DispatchEvent 0x00007f1042ec497f (chrome -callback.h:389 ) ui::DispatchEventFromNativeUiEvent 0x00007f1040057335 (chrome -drm_window_host.cc:185 ) ui::DrmWindowHost::DispatchEvent 0x00007f103fccd29c (chrome -platform_event_source.cc:83 ) ui::PlatformEventSource::DispatchEvent 0x00007f1042ed5616 (chrome -event_factory_evdev.cc:318 ) ui::EventFactoryEvdev::DispatchMouseButtonEvent 0x00007f103ed2881c (chrome -callback.h:389 ) base::debug::TaskAnnotator::RunTask 0x00007f103ed1711f (chrome -message_loop.cc:493 ) base::MessageLoop::DoWork 0x00007f103ed0fd92 (chrome -message_pump_libevent.cc:217 ) base::MessagePumpLibevent::Run 0x00007f103f5bb957 (chrome -run_loop.cc:35 ) base::RunLoop::Run 0x00007f1042d0ed64 (chrome -chrome_browser_main.cc:1943 ) ChromeBrowserMainParts::MainMessageLoopRun 0x00007f1041ac2cba (chrome -browser_main_loop.cc:942 ) content::BrowserMainLoop::RunMainMessageLoopParts 0x00007f10418f76b4 (chrome -browser_main_runner.cc:155 ) content::BrowserMainRunnerImpl::Run 0x00007f10418f7592 (chrome -browser_main.cc:46 ) content::BrowserMain 0x00007f103f569660 (chrome -content_main_runner.cc:785 ) content::ContentMainRunnerImpl::Run 0x00007f103f56813a (chrome -content_main.cc:20 ) content::ContentMain 0x00007f103f1f7abe (chrome -chrome_main.cc:84 ) ChromeMain 0x00007f103c5fbfb5 (libc-2.19.so -libc-start.c:292 ) __libc_start_main 0x00007f103f1f7910 (chrome + 0x011a6910 ) _start
,
Sep 16 2016
In past 2 months I also saw this crash stack once. Will take a look.
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e9607e4cd1197c7b9c4f2bfbeb76b825c91ef8f commit 5e9607e4cd1197c7b9c4f2bfbeb76b825c91ef8f Author: khmel <khmel@chromium.org> Date: Mon Sep 26 18:40:15 2016 Fix crash on item drag in shelf. This handles the case when app list sync model may contain the same ordinals for different items (which is valid case). BUG=b/31708401 BUG= 647855 TEST=Manually on device TEST=Extended unit_tests Review-Url: https://codereview.chromium.org/2366073002 Cr-Commit-Position: refs/heads/master@{#420944} [modify] https://crrev.com/5e9607e4cd1197c7b9c4f2bfbeb76b825c91ef8f/chrome/browser/ui/ash/chrome_launcher_prefs.cc [modify] https://crrev.com/5e9607e4cd1197c7b9c4f2bfbeb76b825c91ef8f/chrome/browser/ui/ash/chrome_launcher_prefs.h [modify] https://crrev.com/5e9607e4cd1197c7b9c4f2bfbeb76b825c91ef8f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/5e9607e4cd1197c7b9c4f2bfbeb76b825c91ef8f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
,
Sep 27 2016
,
Sep 27 2016
,
Sep 27 2016
I think we need to merge this into M54 at least, not sure about M53. Activating request to merge into M54.
,
Sep 27 2016
,
Sep 27 2016
Ops, wrong bug, sorry. I was talking about 629624.
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff commit be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff Author: khmel <khmel@chromium.org> Date: Thu Sep 29 01:36:22 2016 [Merge-M54] Fix crash on item drag in shelf. This handles the case when app list sync model may contain the same ordinals for different items (which is valid case). BUG=b/31708401 BUG= 647855 BUG=629624 TEST=Manually on device TEST=Extended unit_tests TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2366073002 Review-Url: https://codereview.chromium.org/2378353002 Cr-Original-Commit-Position: refs/heads/master@{#420944} Cr-Commit-Position: refs/branch-heads/2840@{#573} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/chrome/browser/ui/ash/chrome_launcher_prefs.cc [modify] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/chrome/browser/ui/ash/chrome_launcher_prefs.h [modify] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
,
Oct 14 2016
Issue 656060 has been merged into this issue.
,
Oct 14 2016
,
Oct 14 2016
Which build of 55 should this be live in? What's remaining to close this?
,
Oct 14 2016
I am closing this bug. I was waiting for M53 decision. It seems no longer actual for M53
,
Oct 14 2016
,
Oct 19 2016
Verified on 54.0.2840.68/8743.69.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff commit be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff Author: khmel <khmel@chromium.org> Date: Thu Sep 29 01:36:22 2016 [Merge-M54] Fix crash on item drag in shelf. This handles the case when app list sync model may contain the same ordinals for different items (which is valid case). BUG=b/31708401 BUG= 647855 BUG=629624 TEST=Manually on device TEST=Extended unit_tests TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2366073002 Review-Url: https://codereview.chromium.org/2378353002 Cr-Original-Commit-Position: refs/heads/master@{#420944} Cr-Commit-Position: refs/branch-heads/2840@{#573} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/chrome/browser/ui/ash/chrome_launcher_prefs.cc [modify] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/chrome/browser/ui/ash/chrome_launcher_prefs.h [modify] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bhthompson@google.com
, Sep 16 2016