New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647854 link

Starred by 3 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
█ rnimmagadda@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Regression] Omnibox text shifts up when selected

Project Member Reported by shrike@chromium.org, Sep 16 2016 
Version: 55.0.2861.0
OS: 10.11

What steps will reproduce the problem?
(1) Type www.apple.com into the Omnibox and go to that URL
(2) Click inside the Omnibox

What is the expected output?
The URL should be in the same location as it was before clicking in the Omnibox

What do you see instead?
The URL text moves up slightly. This is on a Retina machine and it looks like the shift is 1px.

I note that the shift doesn't occur with a site like imdb.com. That makes me wonder if it's related to the security state changes.
JitteryOmniboxText.mov
388 KB Download

Comment 1 by rnimmagadda@chromium.org, Sep 21 2016

Cc: rnimmagadda@chromium.org
Labels: Needs-Feedback
Unable to repro this issue on MAC (10.11.6) for Google Chrome Canary Version - 55.0.2866.0

Screen-recording is attached.

@shrike: We are unable to see the Secure Button in the Omnibar and upon clicking inside the omnibox the URL is not misplaced.

Could you please verify the same on Canary Latest Version - 55.0.2866.0

Thank you.
647854.mov
23.0 MB Download

Comment 2 by shrike@chromium.org, Sep 21 2016

Labels: -Needs-Feedback -Needs-Bisect M-55
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
Confirmed on Canary 55.0.2867.0.

This is a Retina issue so you have to have a Retina machine to reproduce. And the verbose security code is now behind the material-security-verbose flag - it looks like the problem only manifests when you enable this flag (I chose Show all, non-animated).

spqchan@ - assigning to you because this appears to be a side-effect of your changes.

Comment 3 by shrike@chromium.org, Oct 7 2016

Labels: ReleaseBlock-Beta
Now that the cl in  Issue 649682  has landed, this bug is live on Canary (55.0.2883.0). The fix fix this needs to be cherry-picked back to M55.

Comment 4 by gov...@chromium.org, Oct 7 2016 


**** Bulk edit -  please ignore if not applicable ****

This bug  is reported as M55 Beta blocker and we're getting closer to M55 Beta promotion. 
Please plan to have fix ready and merged to M55 branch (2883) by 5:00 PM PT, Monday(10/10) so it has enough baking time in Dev before Beta promotion. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd65c0438820420be292ee912324e2e4f009bc6d

commit bd65c0438820420be292ee912324e2e4f009bc6d
Author: spqchan <spqchan@chromium.org>
Date: Wed Oct 12 17:42:50 2016

[Mac] Restore the graphics state for the Security State Decoration

BUG= 647854 

Review-Url: https://codereview.chromium.org/2410283003
Cr-Commit-Position: refs/heads/master@{#424783}

[modify] https://crrev.com/bd65c0438820420be292ee912324e2e4f009bc6d/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Comment 7 by spqc...@chromium.org, Oct 12 2016

Labels: Merge-Request-55

Comment 8 by dimu@chromium.org, Oct 13 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 13 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddd1c13794ba91ca22bf70f7c5386b8087988289

commit ddd1c13794ba91ca22bf70f7c5386b8087988289
Author: spqchan <spqchan@chromium.org>
Date: Thu Oct 13 18:02:31 2016

[Mac] Restore the graphics state for the Security State Decoration

BUG= 647854 

Review-Url: https://codereview.chromium.org/2410283003
Cr-Commit-Position: refs/heads/master@{#424783}
(cherry picked from commit bd65c0438820420be292ee912324e2e4f009bc6d)

Review URL: https://codereview.chromium.org/2418813003 .

Cr-Commit-Position: refs/branch-heads/2883@{#89}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/ddd1c13794ba91ca22bf70f7c5386b8087988289/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Comment 10 by spqc...@chromium.org, Oct 13 2016

Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddd1c13794ba91ca22bf70f7c5386b8087988289

commit ddd1c13794ba91ca22bf70f7c5386b8087988289
Author: spqchan <spqchan@chromium.org>
Date: Thu Oct 13 18:02:31 2016

[Mac] Restore the graphics state for the Security State Decoration

BUG= 647854 

Review-Url: https://codereview.chromium.org/2410283003
Cr-Commit-Position: refs/heads/master@{#424783}
(cherry picked from commit bd65c0438820420be292ee912324e2e4f009bc6d)

Review URL: https://codereview.chromium.org/2418813003 .

Cr-Commit-Position: refs/branch-heads/2883@{#89}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/ddd1c13794ba91ca22bf70f7c5386b8087988289/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Comment 12 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment