New issue
Advanced search Search tips

Issue 647851 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 248883



Sign in to add a comment

Clean up or remove GetSessionStartupPref method

Project Member Reported by tmartino@chromium.org, Sep 16 2016

Issue description

The GetSessionStartupPref method in StartupBrowserCreator is deceptive: it's actually hiding some policy logic and may modify the contents of the pref.

Some of that logic is crufty and obsolete and can be removed. Other bits are still relevant but probably belong in a broader behavior-checking function. And none of it is unit-tested.

Unfortunately, there are ~4 callers of this method outside SBC/SBCImpl, so there will be a little extra legwork.
 
Status: WontFix (was: Assigned)
Decided against this cleanup for the time being.

Sign in to add a comment