New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647848 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 648672
issue 665643



Sign in to add a comment

Consolidate Blimp Client Settings Tracking

Project Member Reported by mlliu@chromium.org, Sep 16 2016

Issue description

Now our settings are a bit disorganized. Eventually we want to make the settings live in c++, can be changed by the use, and some of them can be saved persistently on the c++ side
 
As part of this work, we should remove //blimp/client/core/common, which is added in https://codereview.chromium.org/2376573002
Blocking: 597756
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5026f9cb132373a27d9660d8beab832dc90d7184

commit 5026f9cb132373a27d9660d8beab832dc90d7184
Author: nyquist <nyquist@chromium.org>
Date: Thu Sep 29 22:57:15 2016

Cleanup blimp/client/core code organization.

The //blimp/client/core directory had some files that were located
directly there without being in a sub-directory. This ended up being
confusing for other developers, so this CL cleans this up by adding a
//blimp/client/core/context directory. It also creates a directory for
the switches.

This CL also temporarily adds a common directory that both the context
classes and other code can depend on. That in turn can then of course
not depend on anything else in //blimp/client/core.

Lastly, it also cleans up the //blimp/client/core/settings directory
to now contain the Java-files it refers to.

In addition, the documentation is updated to include information about
this change, plus add information about the relatively new support
directory.

BUG= 647848 

Review-Url: https://codereview.chromium.org/2376573002
Cr-Commit-Position: refs/heads/master@{#421968}

[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/BUILD.gn
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/README.md
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/BlimpPreferencesTest.java
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/BUILD.gn
[add] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/common/BUILD.gn
[add] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/common/DEPS
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/common/android/java/src/org/chromium/blimp/core/common/PreferencesUtil.java
[add] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/BUILD.gn
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/android/blimp_client_context_impl_android.cc
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/android/blimp_client_context_impl_android.h
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/android/blimp_jni_registrar.cc
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/android/dummy_blimp_client_context_android.cc
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/android/dummy_blimp_client_context_android.h
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/android/dummy_blimp_jni_registrar.cc
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/blimp_client_context_impl.cc
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/blimp_client_context_impl.h
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/blimp_client_context_impl_unittest.cc
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/dummy_blimp_client_context.cc
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/context/dummy_blimp_client_context.h
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/session/BUILD.gn
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/session/assignment_source.cc
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/session/assignment_source_unittest.cc
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/session/identity_source.cc
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/settings/BUILD.gn
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java
[add] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/switches/BUILD.gn
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/switches/android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/switches/blimp_client_switches.cc
[rename] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/core/switches/blimp_client_switches.h
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/client/session/blimp_client_session.cc
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/engine/BUILD.gn
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/engine/browser_tests/blimp_browser_test.cc
[modify] https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184/blimp/engine/browser_tests/navigation_browsertest.cc

Comment 4 by mdw@chromium.org, Oct 24 2016

Is this fixed?

Comment 5 by mlliu@chromium.org, Oct 24 2016

#4, not yet.:-/ I'm working on a CL to get the settings framework setup on the c++ side (https://codereview.chromium.org/2349073002/), should be able to checked in early this week. and after that I need to setup the JNI hookups for the settings
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee3a405c87a05fdf014fae275d5b25fb95e4cda1

commit ee3a405c87a05fdf014fae275d5b25fb95e4cda1
Author: mlliu <mlliu@chromium.org>
Date: Fri Oct 28 22:34:52 2016

Blimp Settings framework on the c++ side

This CL includes:
1. Settings class: where the settings are, through which the settings can
be set and retrieved. It is owned by BlimpClientContextImpl. Hook it up
with BlimpClientContext, so that a PrefService* is passed to store the
settings that needs to be saved persistently.

2. SettingsObserver interface, whose implementations will trigger
different actions on the change of the settings.

3. Added blimp_enabled_, record_whole_document_ and show_network_stats_ to Settings class.

4. SettingsFeature takes a Settings* in the constructor. Add a PushSettings() to the necessary settings to the engine.

BUG= 647848 

Review-Url: https://codereview.chromium.org/2349073002
Cr-Commit-Position: refs/heads/master@{#428524}

[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/app/BUILD.gn
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/app/linux/DEPS
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/app/session/blimp_client_session.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/BUILD.gn
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/DEPS
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/context/BUILD.gn
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/context/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/context/android/blimp_client_context_impl_android.h
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/context/blimp_client_context_impl.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/context/blimp_client_context_impl.h
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/context/blimp_client_context_impl_unittest.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/context/dummy_blimp_client_context.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/BUILD.gn
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/settings.cc
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/settings.h
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/settings_feature.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/settings_feature.h
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/settings_observer.h
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/settings_prefs.cc
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/settings_prefs.h
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/settings/settings_unittest.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/switches/blimp_client_switches.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/core/switches/blimp_client_switches.h
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/public/BUILD.gn
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/public/DEPS
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/client/public/blimp_client_context.h
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/engine/BUILD.gn
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/engine/browser_tests/integration_test.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/blimp/engine/browser_tests/navigation_browsertest.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/chrome/browser/BUILD.gn
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/chrome/browser/android/blimp/blimp_client_context_factory.cc
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/chrome/browser/android/preferences/browser_prefs_android.cc
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/chrome/browser/android/preferences/browser_prefs_android.h
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/chrome/browser/android/preferences/command_line_pref_store_android.cc
[add] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/chrome/browser/android/preferences/command_line_pref_store_android.h
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/ee3a405c87a05fdf014fae275d5b25fb95e4cda1/chrome/browser/prefs/chrome_command_line_pref_store.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2a0d1de87e89bbc1836e7dc083731108aeec22e

commit c2a0d1de87e89bbc1836e7dc083731108aeec22e
Author: mlliu <mlliu@chromium.org>
Date: Tue Nov 08 05:08:28 2016

Add Settings[, Oberser] java code and JNI bridge.

This CL addes the Settings[, Oberser] java code, a compound observer
proxy SettingsObserverProxy, and the JNI bridge between the java and
native code. Users of the java API should be blimp internal code,
calling getSettings() on the BlimpClientContextImpl to get the Settings
java object.

BUG= 647848 

Review-Url: https://codereview.chromium.org/2463423002
Cr-Commit-Position: refs/heads/master@{#430524}

[modify] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/context/android/blimp_client_context_impl_android.cc
[modify] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/context/android/blimp_client_context_impl_android.h
[modify] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/context/android/blimp_jni_registrar.cc
[modify] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/context/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
[modify] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/context/blimp_client_context_impl.cc
[modify] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/context/blimp_client_context_impl.h
[modify] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/context/blimp_client_context_impl_unittest.cc
[modify] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/BUILD.gn
[add] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/EmptySettingsObserver.java
[add] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/Settings.java
[add] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/SettingsObserver.java
[add] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/SettingsObserverProxy.java
[add] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/android/settings_android.cc
[add] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/android/settings_android.h
[add] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/android/settings_observer_proxy.cc
[add] https://crrev.com/c2a0d1de87e89bbc1836e7dc083731108aeec22e/blimp/client/core/settings/android/settings_observer_proxy.h

Comment 8 by mlliu@chromium.org, Nov 14 2016

Status: Started (was: Assigned)
Blocking: -597756 648672
Summary: Consolidate Blimp Client Settings Tracking (was: Blimp Settings)
Blocking: 665643
Status: WontFix (was: Started)
Obsolete, WontFix.
Labels: Archive-Blimp

Sign in to add a comment