New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in blink::HTMLCanvasElement::toDataURLInternal

Project Member Reported by ClusterFuzz, Sep 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4942847902220288

Fuzzer: inferno_twister_custom_bundle
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000020
Crash State:
  blink::HTMLCanvasElement::toDataURLInternal
  blink::HTMLCanvasElement::toDataURL
  blink::HTMLCanvasElementV8Internal::toDataURLMethodCallback
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=418536:418563

Minimized Testcase (19.20 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96kzwospTOsjegb5WursFDVLa9iDLTItBZ1pt3oeUz6KbXNlj3dtaehGQs6KWbXY1d3VUiL709F4tg4Vvg1QqWyv3s91B3FeoHqsUbzOXvjUlTnr3Qc4AtM1r5pJydnCuVEcSiAgBKWyekzjVUxYXAAYFZq2fQq_bi3OmFo6cbN_clIiVU?testcase_id=4942847902220288

Issue manually filed by: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>HTML
Labels: M-55 Te-Logged
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)

Author: junov
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/9d280866e11c2c038005452c8d14fb3ffa91ac2c
Time: Wed Sep 14 14:59:02 2016
File HTMLCanvasElement.cpp is changed in this cl (and is part of stack frame #2, "blink::HTMLCanvasElement::toDataURLInternal"; frame #3, "blink::HTMLCanvasElement::toDataURL")
Minimum distance from crash line to modified line: 12. (file: HTMLCanvasElement.cpp, crashed on: 661, modified: 649).

Suspected Project: chromium
Suspected Component: Blink>HTML

junov@, could you please take a look and please help us to find correct owner if it is not related your changes.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7049607698f748d6c8f6024557fe2a9c4362ec2e

commit 7049607698f748d6c8f6024557fe2a9c4362ec2e
Author: junov <junov@chromium.org>
Date: Fri Sep 23 16:32:31 2016

Make toDataURL robust with respect to allocation failures

It is not safe to assume that ImageData::create always returns
a valid point.  Internally it uses DOMUint8ClampedArray::createOrNull
which returns null instead of crashing when allocation fails.
This change adds the appropriate null pointer checks to take
that into account.

BUG= 647824 
NOTRY=true

Review-Url: https://codereview.chromium.org/2361493003
Cr-Commit-Position: refs/heads/master@{#420625}

[modify] https://crrev.com/7049607698f748d6c8f6024557fe2a9c4362ec2e/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Comment 3 by junov@chromium.org, Sep 23 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by ClusterFuzz, Sep 24 2016

ClusterFuzz has detected this issue as fixed in range 420502:420630.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4942847902220288

Fuzzer: inferno_twister_custom_bundle
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000020
Crash State:
  blink::HTMLCanvasElement::toDataURLInternal
  blink::HTMLCanvasElement::toDataURL
  blink::HTMLCanvasElementV8Internal::toDataURLMethodCallback
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=418536:418563
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=420502:420630

Minimized Testcase (19.20 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96kzwospTOsjegb5WursFDVLa9iDLTItBZ1pt3oeUz6KbXNlj3dtaehGQs6KWbXY1d3VUiL709F4tg4Vvg1QqWyv3s91B3FeoHqsUbzOXvjUlTnr3Qc4AtM1r5pJydnCuVEcSiAgBKWyekzjVUxYXAAYFZq2fQq_bi3OmFo6cbN_clIiVU?testcase_id=4942847902220288

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment