New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647821 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Crash in content::RenderWidgetHostViewChildFrame::GetParentView

Project Member Reported by ClusterFuzz, Sep 16 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4635878100303872

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: UNKNOWN
Crash Address: 0x00000006
Crash State:
  content::RenderWidgetHostViewChildFrame::GetParentView
  content::RenderWidgetHostInputEventRouter::SendMouseEnterOrLeaveEvents
  content::RenderWidgetHostInputEventRouter::RouteMouseEvent
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_syzyasan_chrome&range=419110:419128

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv94KmV5P2GFDujgjTrkB7smvv7i3ka15zsJHyOMAgPPXtUQPmvP6cgz5f3bN_WWxju6LE21pXnX2VoffGX8J8b9FUursiIJSHgFX6IqHi9M6XyRnX4xBT1EAxXbYpOXOR2clcebqA8eLiYL649ZyP9LiYHQkHw?testcase_id=4635878100303872


Additional requirements: Requires Gestures

Issue manually filed by: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>WrongResult Tests>Flaky Internals>Sandbox>SiteIsolation
Labels: M-55 Te-Logged
Owner: kenrb@chromium.org
Status: Assigned (was: Untriaged)

Author: kenrb
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/a12ade9d1326ecce585dda08a027d8061e9f06c6
Time: Fri Jul 29 17:06:51 2016
The CL last changed line 303 of file render_widget_host_view_child_frame.cc, which is stack frame 0.

Author: kenrb
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/89ed0412083300318a04a2d4302a77f4d8b76cc9
Time: Wed Sep 14 19:05:48 2016
The CL last changed line 383 of file render_widget_host_input_event_router.cc, which is stack frame 1.

kenrb@, could you please take a look and please help us to find correct owner if it is not related your changes.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83e4f9ac895d5b42a4b114f3ef964676a40476ff

commit 83e4f9ac895d5b42a4b114f3ef964676a40476ff
Author: kenrb <kenrb@chromium.org>
Date: Tue Oct 11 20:36:27 2016

Clear last MouseMove root view in RWHIER if that view gets destroyed

Cluster-fuzz has reported some difficult-to-reproduce crashes in the
MouseEnter/Leave generation code in RenderWidgetHostInputEventRouter,
and there are some very sparse crash reports appearing for that also.

These might be caused by race conditions from RenderWidgetHostView
tree modifications that get slightly out of sync from the Surface
state that is used for hit testing (Surfaces aren't invalidated until
RWHVs are deleted, which for some RWHVs is not immediate upon them
having Destroy() called).

This CL speculatively tries to address the crashes by having
SendMouseEnterOrLeaveEvents abort when it discovers the RWHV tree out
of sync, and also clearing last_mouse_move_root_view_ when that
gets destroyed.

BUG= 647821 ,  652209 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2396083002
Cr-Commit-Position: refs/heads/master@{#424533}

[modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/83e4f9ac895d5b42a4b114f3ef964676a40476ff/content/browser/renderer_host/render_widget_host_view_base.h

Components: -Tools>Test>FindIt>WrongResult
Labels: Test-Predator-Wrong
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 3 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68f883645ff0c2f46fa75128af0642e87e7095bd

commit 68f883645ff0c2f46fa75128af0642e87e7095bd
Author: Ken Buchanan <kenrb@chromium.org>
Date: Thu Nov 03 20:54:24 2016

Clear last MouseMove root view in RWHIER if that view gets destroyed

Cluster-fuzz has reported some difficult-to-reproduce crashes in the
MouseEnter/Leave generation code in RenderWidgetHostInputEventRouter,
and there are some very sparse crash reports appearing for that also.

These might be caused by race conditions from RenderWidgetHostView
tree modifications that get slightly out of sync from the Surface
state that is used for hit testing (Surfaces aren't invalidated until
RWHVs are deleted, which for some RWHVs is not immediate upon them
having Destroy() called).

This CL speculatively tries to address the crashes by having
SendMouseEnterOrLeaveEvents abort when it discovers the RWHV tree out
of sync, and also clearing last_mouse_move_root_view_ when that
gets destroyed.

BUG= 647821 ,  652209 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2396083002
Cr-Commit-Position: refs/heads/master@{#424533}
(cherry picked from commit 83e4f9ac895d5b42a4b114f3ef964676a40476ff)

Review URL: https://codereview.chromium.org/2477893002 .

Cr-Commit-Position: refs/branch-heads/2883@{#445}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/68f883645ff0c2f46fa75128af0642e87e7095bd/content/browser/renderer_host/render_widget_host_view_base.h

Project Member

Comment 5 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by kenrb@chromium.org, Dec 22 2016

Status: Fixed (was: Assigned)

Sign in to add a comment