Blimp: Thread DCHECK failure when an image fails to decode |
||||
Issue descriptionVersion: e34a6457a83b0d60dda1ce4776e84eeee2e97aa6 OS: Goobuntu What steps will reproduce the problem? (1) Run Blimp linux client (2) Load a page with an image (3) ImageDecode error occurs (4) thread check fails What is the expected output? ImageDecode error fails gracefully What do you see instead? thread check fail Please use labels and text to provide additional information.
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ecbaf9d15c6bff239e1a38502de55146d3e56e6 commit 6ecbaf9d15c6bff239e1a38502de55146d3e56e6 Author: kmarshall <kmarshall@chromium.org> Date: Mon Sep 19 17:17:59 2016 Blimp: relocate thread-unsafe member getter in DropConnection code. There is logic in the ClientSession/ClientContext which attempts to drop a connection on the IO thread. Unfortunately, in doing so, it called a thread-unsafe member getter within the call to PostTask. This CL moves the getter into a helper method which runs entirely on the IO thread. R=nyquist@chromium.org,wez@chromium.org CC=steimel@chromium.org BUG= 647814 Review-Url: https://codereview.chromium.org/2344893009 Cr-Commit-Position: refs/heads/master@{#419491} [modify] https://crrev.com/6ecbaf9d15c6bff239e1a38502de55146d3e56e6/blimp/client/core/blimp_client_context_impl.cc [modify] https://crrev.com/6ecbaf9d15c6bff239e1a38502de55146d3e56e6/blimp/client/core/blimp_client_context_impl.h [modify] https://crrev.com/6ecbaf9d15c6bff239e1a38502de55146d3e56e6/blimp/client/session/blimp_client_session.cc [modify] https://crrev.com/6ecbaf9d15c6bff239e1a38502de55146d3e56e6/blimp/client/session/blimp_client_session.h
,
Nov 14 2016
,
Nov 14 2016
,
Dec 9 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by steimel@chromium.org
, Sep 16 2016