New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647812 link

Starred by 1 user
Status: Fixed
Owner:
d...@chromium.org
Closed: Sep 2016
Cc:
█ iannucci@chromium.org
tandrii@chromium.org
dpranke@chromium.org
mark@chromium.org
aga...@chromium.org
chrome-trooper-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Crashpad bots failing in gclient sync

Project Member Reported by scottmg@chromium.org, Sep 16 2016 
Three Windows bots here https://build.chromium.org/p/client.crashpad/console

e.g. https://build.chromium.org/p/client.crashpad/builders/crashpad_win_x64_dbg/builds/225/steps/steps/logs/stdio

Could Not Find e:\b\build\slave\cache_dir\chromium.googlesource.com-external-github.com-google-googletest.lock
Loaded .gclient config in E:\b\build\slave\crashpad_win_x64_dbg\build:
cache_dir = 'E:\\b\\build\\slave\\cache_dir'
solutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'crashpad', 'url': 'https://chromium.googlesource.com/crashpad/crashpad.git'}]
Error: 
Your .gclient file seems to be broken. The requested URL is different from what
is actually checked out in E:\b\build\slave\crashpad_win_x64_dbg\build\crashpad.

The .gclient file contains:
URL: https://chromium.googlesource.com/crashpad/crashpad.git (git)
Cache mirror: E:\b\build\slave\cache_dir\chromium.googlesource.com-crashpad-crashpad (exists=True)

The local checkout in E:\b\build\slave\crashpad_win_x64_dbg\build\crashpad reports:
https://chromium.googlesource.com/chromium/tools/build.git (git)

You should ensure that the URL listed in .gclient is correct and either change
it or fix the checkout. If you're managing your own git checkout in
E:\b\build\slave\crashpad_win_x64_dbg\build\crashpad but the URL in .gclient is for an svn repository, you probably
want to set 'managed': False in .gclient.


Does this mean anything to anyone? There's a fairly large range (Sep 9 good to Sept 16 bad) but I don't know of anything that was changed in the bot config.

Comment 1 by tandrii@chromium.org, Sep 16 2016

Cc: iannucci@chromium.org
Labels: Infra-Troopers
+Robbie sinec you've been touching bot_update.

Comment 2 by dpranke@chromium.org, Sep 16 2016 

This builder isn't using bot_update .

Comment 3 by d...@chromium.org, Sep 16 2016 

#2 is correct: all builders should be converted to use bot_update. Any idea who is an owner for this one?

Comment 4 by tandrii@chromium.org, Sep 16 2016 

Ah, sorry, I was confused. bot_update actually has extra handling for broken .gclient files, so it's a really good idea to convert it, actually.

Comment 5 by d...@chromium.org, Sep 16 2016 

Prospective fix: https://codereview.chromium.org/2349013002

Comment 6 by dpranke@chromium.org, Sep 16 2016 

Note that my comment was not saying that not using bot_update was the problem. I have no problem w/ switching to bot_update, but if we think that every builder should be using bot_update, we should probably make that well known in recipe-land and audit it.

Comment 7 by tandrii@chromium.org, Sep 16 2016 

I've looked at your recipe and your gclient config definition in depot_tools: all seem sane. So, IMO, the checkout on your bots for some reason got corrupted.

Two ways out:

convert to bot_update, which should be 1 line change - just replace api.gclient.checkout()
with api.bot_update.ensure_checkout()

or wipe out builder dirs on slave.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e549894cc4f86f3f2107e3686d561ff83331a267

commit e549894cc4f86f3f2107e3686d561ff83331a267
Author: dnj <dnj@chromium.org>
Date: Fri Sep 16 21:43:25 2016

crashpad/continuous: Use bot_update.

BUG= chromium:647812 
TEST=expectations

Review-Url: https://codereview.chromium.org/2349013002

[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_dbg.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_dbg_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_rel.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_rel_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.py
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e549894cc4f86f3f2107e3686d561ff83331a267

commit e549894cc4f86f3f2107e3686d561ff83331a267
Author: dnj <dnj@chromium.org>
Date: Fri Sep 16 21:43:25 2016

crashpad/continuous: Use bot_update.

BUG= chromium:647812 
TEST=expectations

Review-Url: https://codereview.chromium.org/2349013002

[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_dbg.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_dbg_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_rel.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_mac_rel_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel_clobber.json
[modify] https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267/scripts/slave/recipes/crashpad/continuous.py

Comment 10 by scottmg@chromium.org, Sep 16 2016

Owner: d...@chromium.org
Status: Fixed (was: Untriaged)
Thanks, bots look good now.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/3bd42f067be6f20a3fd59ff85b117dd0677df627

commit 3bd42f067be6f20a3fd59ff85b117dd0677df627
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 16 22:42:08 2016
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/192eee39cef6172b15898d9e3c68c129a87366bb

commit 192eee39cef6172b15898d9e3c68c129a87366bb
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 16 23:06:23 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
  https://crrev.com/79d8d758281609aa49b9b9af7e18cc187c2ee814 Disable CompilerInfoCache for a while (shinyak@chromium.org)
  https://crrev.com/a8f07009101d46553ea5d4bce1353ecb365dd3a5 Revert "Roll recipe dependencies (nontrivial)." (tandrii@chromium.org)
  https://crrev.com/cbca79967afa4f28df6b0ede337db6138eeb167b Add asan=1 to GYP_DEFINES for Dart asan builds (whesse@google.com)
  https://crrev.com/25b922d8edc1927c3af4bb4a8f7db6434096dca0 WebRTC: Disable iOS API Framework Builder. (ehmaldonado@chromium.org)
  https://crrev.com/769dbabae3b7ff11023dd1b393fcd2a12e165c65 Make sure goma_ctl is running during wasm_llvm build (sbc@chromium.org)
  https://crrev.com/2e89429885f7c2503565cb12d564d0f6f58a42f1 Fix Webkit capitalization for N CTS tests. (mikecase@chromium.org)
  https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267 crashpad/continuous: Use bot_update. (dnj@chromium.org)
  https://crrev.com/f74386f7e19ff3f32693d222262d1a3ee79799ef Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org)
  https://crrev.com/15a248123d9032061486cd2d4b3f64369c93a9a5 Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ ) (tandrii@chromium.org)
  https://crrev.com/7f245d07b2282f9847072fccddf7162a7e632a2d Bump git-on-windows bleeding edge version to 2.10.0. (vadimsh@chromium.org)
  https://crrev.com/6ac12ffd596e338c43e25dc3889e8ac552c2e885 Make bot_update.py print git version it uses. (vadimsh@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641, chromium:647812 , webrtc:6372 ,647446

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2343293002
Cr-Commit-Position: refs/heads/master@{#419319}

[modify] https://crrev.com/192eee39cef6172b15898d9e3c68c129a87366bb/infra/config/recipes.cfg
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7d6811c4c58a9e280bca7bf65a8dfde001bef42a

commit 7d6811c4c58a9e280bca7bf65a8dfde001bef42a
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 16 23:37:07 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/ba9de887ec268453298caa8641de3cc91dbfb818 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/e1d15cd7795cc1c5465983af8a49669242857107 Add rtc_stats_unittests to the test suite (ehmaldonado@chromium.org)
  https://crrev.com/37294244d9d54d639a083d382da68c50f8fe14e5 Add linux_chromium_headless_dbg trybot (perezju@chromium.org)
  https://crrev.com/f0f4c4a27746dee8a53234f03e452dba556deb55 Reland of Enable the ninja up-to-date check for Android builders (agrieve@chromium.org)
  https://crrev.com/2744734cf3aa1d8a02d0f0b7abf99635e9f2aa48 Revert of Enable the ninja up-to-date check for Android builders (patchset #1 id:1 of https://codereview.chromium.org/2343563003/ ) (agrieve@chromium.org)
  https://crrev.com/1575589a1d8f61fee45ec53ccbf77f073fd38847 recipe_modules/chromite: Use "build_type". (dnj@chromium.org)
  https://crrev.com/5799bab975aa3eda6785f36d9f7879549074b28b Reland of Enable the ninja up-to-date check for Android builders (agrieve@chromium.org)
  https://crrev.com/ecdf065c9d2a6e28d86c8ad333432b497158ee7a chromium.android: Enable swarming on Android arm64 builder (bpastene@chromium.org)
  https://crrev.com/7a71133c89aa2a770fc2326188306cf6a3a6f1e1 Revert of Enable the ninja up-to-date check for Android builders (patchset #1 id:1 of https://codereview.chromium.org/2343953002/ ) (agrieve@chromium.org)
  https://crrev.com/c65424c419105e0720cc0de09fb9e7a36c3d4601 Pass ninja -n in the ninja -d explain step to avoid more work (agrieve@chromium.org)
  https://crrev.com/8091fad9d075ecec116e1740360ff955a7654c4a Remove use_isolate from Marshmallow 64 bit Tester (bpastene@chromium.org)
  https://crrev.com/2f0a7c064259dc0e0bf375c2d1771544f5647a1c Changed sequence of package_build step to be before package_build_for_bisect (miimnk@google.com)
  https://crrev.com/194bd0247efb60371dbcae87731f13dce4fa7934 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/d2845f7e87aa167cf7df78003b5768f948803d07 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/eb686c79229ef3cf3b39e6a0807f4c98e3e93cf9 Add BuildBucket manifest scheduling support. (dnj@chromium.org)
  https://crrev.com/537cdb699a70d5d55f3eefb923eae1dc5104a8eb Add goma to wasm waterfall (sbc@chromium.org)
  https://crrev.com/b6d326d6f6f9608bba307109cc4a1c5efc5946bb Run the ninja "up-to-date" check for all compiles, but just as an fyi (agrieve@chromium.org)
  https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
  https://crrev.com/79d8d758281609aa49b9b9af7e18cc187c2ee814 Disable CompilerInfoCache for a while (shinyak@chromium.org)
  https://crrev.com/a8f07009101d46553ea5d4bce1353ecb365dd3a5 Revert "Roll recipe dependencies (nontrivial)." (tandrii@chromium.org)
  https://crrev.com/cbca79967afa4f28df6b0ede337db6138eeb167b Add asan=1 to GYP_DEFINES for Dart asan builds (whesse@google.com)
  https://crrev.com/25b922d8edc1927c3af4bb4a8f7db6434096dca0 WebRTC: Disable iOS API Framework Builder. (ehmaldonado@chromium.org)
  https://crrev.com/769dbabae3b7ff11023dd1b393fcd2a12e165c65 Make sure goma_ctl is running during wasm_llvm build (sbc@chromium.org)
  https://crrev.com/2e89429885f7c2503565cb12d564d0f6f58a42f1 Fix Webkit capitalization for N CTS tests. (mikecase@chromium.org)
  https://crrev.com/e549894cc4f86f3f2107e3686d561ff83331a267 crashpad/continuous: Use bot_update. (dnj@chromium.org)
  https://crrev.com/f74386f7e19ff3f32693d222262d1a3ee79799ef Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/1a9a50a459c9e3c081719d3e835cac213c319136 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/f46c20fcee6e6a0a7d75788847632cd4ac18e2e9 codereview.settings: add GIT_NUMBER_FOOTER setting. (tandrii@chromium.org)
  https://crrev.com/5d0a0421ce27046c94177511a05699316ec8097a git_cl: update outdated TODOs. (tandrii@chromium.org)
  https://crrev.com/73449b0bd49eab1e152f419102123d734896da98 Gerrit git cl land: abort if not uploaded. (tandrii@chromium.org)
  https://crrev.com/bf42940536f6c0c123a9e6278c20bc38729b3717 git cl land to refs/pending: remove unused arg. (tandrii@chromium.org)
  https://crrev.com/7475196d4c32d66e1c199bf24945b7ae28255e13 repo: update to v1.12.17-cr1 (vapier@chromium.org)
  https://crrev.com/adcd4b78d5f35da535ccf82a221afb9fa389f631 presubmit_support: Remove a noisy logging.debug() (thakis@chromium.org)
  https://crrev.com/18ca30ca804679ee624a52e73017d234a8c0008f Teach bot_update to remove partially deleted git repos. (vadimsh@chromium.org)
  https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org)
  https://crrev.com/15a248123d9032061486cd2d4b3f64369c93a9a5 Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ ) (tandrii@chromium.org)
  https://crrev.com/7f245d07b2282f9847072fccddf7162a7e632a2d Bump git-on-windows bleeding edge version to 2.10.0. (vadimsh@chromium.org)
  https://crrev.com/6ac12ffd596e338c43e25dc3889e8ac552c2e885 Make bot_update.py print git version it uses. (vadimsh@chromium.org)
  https://crrev.com/7e16cf303221bbcf81d632924e19ddc888da9c3b owners.py: partial fix for owners-check perf regression (nick@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=646165,none,646838,632008,webrtc:6372,chromium:647812,642493,647446,chromium:627996,642793,635641,645662,chromium:632203,647046,609225,642759

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2345413002

[modify] https://crrev.com/7d6811c4c58a9e280bca7bf65a8dfde001bef42a/infra/config/recipes.cfg
►

Sign in to add a comment