Invalidations not working on Android |
||||||
Issue descriptionENVIRONMENT and STATS Chrome version: 55.0.2860.0 dev Devices tested: Nexus7, Nexus 9 REPRO STEPS 1. Sign in to Chrome on a desktop. 2. Sign in to Chrome on Android. 3. Make some changes on desktop like adding bookmarks, autofill entries, open tabs etc 4. On Android chrome open chrome://invalidations ACTUAL RESULTS No invalidations are seen in the log and the changes made on desktop are not synced to Android. EXPECTED RESULTS Invalidations working properly and the changes made on desktop Chrome are synced to Android Chrome. ADDITIONAL INFO Working fine in 54.0.2840.25 beta which has the fix for crbug.com/645646
,
Sep 19 2016
I can reproduce this using Chrome Dev with my personal account. Starting investigation now.
,
Sep 19 2016
I have confirmed that http://crrev.com/2297193003 is the culprit. For some reason it breaks registering for invalidations: ActivityManager: Unable to start service Intent { act=org.chromium.components.sync.notifier.ACTION_REGISTER_TYPES cmp=com.google.android.apps.chrome/org.chromium.components.invalidation.InvalidationClientService (has extras) } U=0: not found I have confirmed that it works on the revision immediately before that one and fails on it. Assigning to tedchoc@ to either revert the CL (which does not revert cleanly) or fix it.
,
Sep 23 2016
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c622eb2571e5a9c659c2aee70086af636472032f commit c622eb2571e5a9c659c2aee70086af636472032f Author: tedchoc <tedchoc@chromium.org> Date: Fri Sep 23 20:33:48 2016 Fix invalidations after ChromeInvalidationClientService introduction. This change, http://crrev.com/2297193003, introduced a chrome specific InvalidationClientService, but it did not properly update all the appropriate references. This pulls the registered service from the AndroidManifest.xml if applicable. Does it through this indirection as components/ is unaware of chrome/. BUG= 647774 Review-Url: https://codereview.chromium.org/2352943002 Cr-Commit-Position: refs/heads/master@{#420718} [modify] https://crrev.com/c622eb2571e5a9c659c2aee70086af636472032f/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java [modify] https://crrev.com/c622eb2571e5a9c659c2aee70086af636472032f/chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/InvalidationServiceTest.java [modify] https://crrev.com/c622eb2571e5a9c659c2aee70086af636472032f/chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java [modify] https://crrev.com/c622eb2571e5a9c659c2aee70086af636472032f/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java [modify] https://crrev.com/c622eb2571e5a9c659c2aee70086af636472032f/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationService.java [modify] https://crrev.com/c622eb2571e5a9c659c2aee70086af636472032f/tools/android/eclipse/.classpath
,
Sep 26 2016
,
Sep 30 2016
Invalidations are working fine now. Verified in 55.0.2876.0 dev |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by maxbogue@chromium.org
, Sep 19 2016