git cl format || git cl presubmit does not handle spacing for empty curly brackets properly |
||||
Issue description
Version: 55.0.2861.0
OS: All
What steps will reproduce the problem?
(1) In a header file in blink define a method as void foo() {};
(2) Run 'git cl format'
(3) the method changes to void foo(){};
(4) Run 'git cl upload' after committing.
What is the expected output?
Presubmit should pass.
What do you see instead?
Presubmit fails complaining about the missing space between () and {}.
,
Sep 16 2016
-> thakis so he can forward to someone else, I've never used clang-format.
,
Sep 16 2016
Remove the ; after {} and it'll work.
,
Sep 20 2016
thakis@ is right! I shouldn't have even put ; there. Thanks!
,
Sep 20 2016
cool :-)
,
Sep 20 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ekaramad@chromium.org
, Sep 16 2016