[Mac] Click and drag from tab close button should restore icon to its original state |
|||
Issue descriptionVersion: 52.0.2743.82 OS: 10.11 What steps will reproduce the problem? (1) Click and hold a tab close button - note that the icon changes to an x in a red circle (2) With the mouse held down, drag outside of the close button What is the expected output? The button should return to its original appearance (a gray x) What do you see instead? The button remains an x in a red circle. When I release the mouse the tab does not close, which is correct. The icon should change to reflect what will happen when I release the mouse.
,
May 23 2017
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40f734ce03b4693acb36388b7892dc67f863b65b commit 40f734ce03b4693acb36388b7892dc67f863b65b Author: shrike <shrike@chromium.org> Date: Thu Jun 01 22:44:29 2017 [Mac] Update tab close button when user drags outside When clicking inside a button and dragging the mouse out of the button's bounds, a button should update its appearance to show that its action will not fire if the user releases the mouse. This cl fixes a problem with the tab close button where it would always show the mouse down state, even if you clicked and dragged outside of it. This cl also does a little refactoring, moving common init-time code to a commonInit method (like its HoverCloseButton subclass). R=avi@chromium.org BUG= 647757 Review-Url: https://codereview.chromium.org/2898343002 Cr-Commit-Position: refs/heads/master@{#476463} [modify] https://crrev.com/40f734ce03b4693acb36388b7892dc67f863b65b/chrome/browser/ui/cocoa/hover_close_button.mm [modify] https://crrev.com/40f734ce03b4693acb36388b7892dc67f863b65b/ui/base/cocoa/hover_button.h [modify] https://crrev.com/40f734ce03b4693acb36388b7892dc67f863b65b/ui/base/cocoa/hover_button.mm
,
Jun 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by spqc...@chromium.org
, May 23 2017